diff options
Diffstat (limited to 'meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/2833-drm-amd-powerplay-Zero-initialize-freq-in-smu_v11_0_.patch')
| -rw-r--r-- | meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/2833-drm-amd-powerplay-Zero-initialize-freq-in-smu_v11_0_.patch | 47 |
1 files changed, 47 insertions, 0 deletions
diff --git a/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/2833-drm-amd-powerplay-Zero-initialize-freq-in-smu_v11_0_.patch b/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/2833-drm-amd-powerplay-Zero-initialize-freq-in-smu_v11_0_.patch new file mode 100644 index 00000000..10841444 --- /dev/null +++ b/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/2833-drm-amd-powerplay-Zero-initialize-freq-in-smu_v11_0_.patch @@ -0,0 +1,47 @@ +From 8ed86f7ce47aae9b2cc51c6360eb11e61458edb9 Mon Sep 17 00:00:00 2001 +From: Nathan Chancellor <natechancellor@gmail.com> +Date: Wed, 3 Jul 2019 22:52:15 -0700 +Subject: [PATCH 2833/2940] drm/amd/powerplay: Zero initialize freq in + smu_v11_0_get_current_clk_freq + +clang warns (trimmed for brevity): + +drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1098:10: warning: +variable 'freq' is used uninitialized whenever '?:' condition is false +[-Wsometimes-uninitialized] + ret = smu_get_current_clk_freq_by_table(smu, clk_id, &freq); + ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +If get_current_clk_freq_by_table is ever NULL, freq will fail to be +properly initialized. Zero initialize it to avoid using uninitialized +stack values. + +smu_get_current_clk_freq_by_table expands to a ternary operator +conditional on smu->funcs->get_current_clk_freq_by_table being not NULL. +When this is false, freq will be uninitialized. Zero initialize freq to +avoid using random stack values if that ever happens. + +Fixes: e36182490dec ("drm/amd/powerplay: fix dpm freq unit error (10KHz -> Mhz)") +Link: https://github.com/ClangBuiltLinux/linux/issues/585 +Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> +Signed-off-by: Alex Deucher <alexander.deucher@amd.com> +--- + drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c +index e03088c693ec..c60899de88bb 100644 +--- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c ++++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c +@@ -1090,7 +1090,7 @@ static int smu_v11_0_get_current_clk_freq(struct smu_context *smu, + uint32_t *value) + { + int ret = 0; +- uint32_t freq; ++ uint32_t freq = 0; + + if (clk_id >= SMU_CLK_COUNT || !value) + return -EINVAL; +-- +2.17.1 + |