diff options
Diffstat (limited to 'meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/1841-crypto-ccp-no-need-to-check-return-value-of-debugfs_.patch')
| -rw-r--r-- | meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/1841-crypto-ccp-no-need-to-check-return-value-of-debugfs_.patch | 94 |
1 files changed, 94 insertions, 0 deletions
diff --git a/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/1841-crypto-ccp-no-need-to-check-return-value-of-debugfs_.patch b/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/1841-crypto-ccp-no-need-to-check-return-value-of-debugfs_.patch new file mode 100644 index 00000000..69913a1a --- /dev/null +++ b/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/1841-crypto-ccp-no-need-to-check-return-value-of-debugfs_.patch @@ -0,0 +1,94 @@ +From 3895fee679f7e9934941046078bee61a1c3e9c5f Mon Sep 17 00:00:00 2001 +From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> +Date: Tue, 22 Jan 2019 16:14:21 +0100 +Subject: [PATCH 1841/2940] crypto: ccp - no need to check return value of + debugfs_create functions + +When calling debugfs functions, there is no need to ever check the +return value. The function can work or not, but the code logic should +never do something different based on this. + +Cc: Tom Lendacky <thomas.lendacky@amd.com> +Cc: Gary Hook <gary.hook@amd.com> +Cc: Herbert Xu <herbert@gondor.apana.org.au> +Cc: "David S. Miller" <davem@davemloft.net> +Cc: linux-crypto@vger.kernel.org +Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> +Acked-by: Gary R Hook <gary.hook@amd.com> +Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> +--- + drivers/crypto/ccp/ccp-debugfs.c | 36 +++++++------------------------- + 1 file changed, 7 insertions(+), 29 deletions(-) + +diff --git a/drivers/crypto/ccp/ccp-debugfs.c b/drivers/crypto/ccp/ccp-debugfs.c +index 1a734bd2070a..4bd26af7098d 100644 +--- a/drivers/crypto/ccp/ccp-debugfs.c ++++ b/drivers/crypto/ccp/ccp-debugfs.c +@@ -286,10 +286,7 @@ void ccp5_debugfs_setup(struct ccp_device *ccp) + { + struct ccp_cmd_queue *cmd_q; + char name[MAX_NAME_LEN + 1]; +- struct dentry *debugfs_info; +- struct dentry *debugfs_stats; + struct dentry *debugfs_q_instance; +- struct dentry *debugfs_q_stats; + int i; + + if (!debugfs_initialized()) +@@ -299,24 +296,14 @@ void ccp5_debugfs_setup(struct ccp_device *ccp) + if (!ccp_debugfs_dir) + ccp_debugfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL); + mutex_unlock(&ccp_debugfs_lock); +- if (!ccp_debugfs_dir) +- return; + + ccp->debugfs_instance = debugfs_create_dir(ccp->name, ccp_debugfs_dir); +- if (!ccp->debugfs_instance) +- goto err; + +- debugfs_info = debugfs_create_file("info", 0400, +- ccp->debugfs_instance, ccp, +- &ccp_debugfs_info_ops); +- if (!debugfs_info) +- goto err; ++ debugfs_create_file("info", 0400, ccp->debugfs_instance, ccp, ++ &ccp_debugfs_info_ops); + +- debugfs_stats = debugfs_create_file("stats", 0600, +- ccp->debugfs_instance, ccp, +- &ccp_debugfs_stats_ops); +- if (!debugfs_stats) +- goto err; ++ debugfs_create_file("stats", 0600, ccp->debugfs_instance, ccp, ++ &ccp_debugfs_stats_ops); + + for (i = 0; i < ccp->cmd_q_count; i++) { + cmd_q = &ccp->cmd_q[i]; +@@ -325,21 +312,12 @@ void ccp5_debugfs_setup(struct ccp_device *ccp) + + debugfs_q_instance = + debugfs_create_dir(name, ccp->debugfs_instance); +- if (!debugfs_q_instance) +- goto err; +- +- debugfs_q_stats = +- debugfs_create_file("stats", 0600, +- debugfs_q_instance, cmd_q, +- &ccp_debugfs_queue_ops); +- if (!debugfs_q_stats) +- goto err; ++ ++ debugfs_create_file("stats", 0600, debugfs_q_instance, cmd_q, ++ &ccp_debugfs_queue_ops); + } + + return; +- +-err: +- debugfs_remove_recursive(ccp->debugfs_instance); + } + + void ccp5_debugfs_destroy(void) +-- +2.17.1 + |