diff options
Diffstat (limited to 'meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.14.71/2147-drm-amd-powerplay-initialize-a-variable-before-using.patch')
| -rw-r--r-- | meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.14.71/2147-drm-amd-powerplay-initialize-a-variable-before-using.patch | 42 |
1 files changed, 42 insertions, 0 deletions
diff --git a/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.14.71/2147-drm-amd-powerplay-initialize-a-variable-before-using.patch b/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.14.71/2147-drm-amd-powerplay-initialize-a-variable-before-using.patch new file mode 100644 index 00000000..b0eda758 --- /dev/null +++ b/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.14.71/2147-drm-amd-powerplay-initialize-a-variable-before-using.patch @@ -0,0 +1,42 @@ +From 3336c5ac2499ea3a0a0e94820383bbd9bcd68893 Mon Sep 17 00:00:00 2001 +From: Nicolas Iooss <nicolas.iooss_linux@m4x.org> +Date: Sun, 3 Sep 2017 14:00:57 +0200 +Subject: [PATCH 2147/4131] drm/amd/powerplay: initialize a variable before + using it + +Function vega10_apply_state_adjust_rules() only initializes +stable_pstate_sclk_dpm_percentage when +data->registry_data.stable_pstate_sclk_dpm_percentage is not between 1 +and 100. The variable is then used to compute stable_pstate_sclk, which +therefore uses an uninitialized value. + +Fix this by initializing stable_pstate_sclk_dpm_percentage to +data->registry_data.stable_pstate_sclk_dpm_percentage. + +This issue has been found while building the kernel with clang. The +compiler reported a -Wsometimes-uninitialized warning. + +Reviewed-by: Alex Deucher <alexander.deucher@amd.com> +Fixes: f83a9991648b ("drm/amd/powerplay: add Vega10 powerplay support (v5)") +Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> +Signed-off-by: Alex Deucher <alexander.deucher@amd.com> +--- + drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +index 629806d..99c488c 100644 +--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c ++++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +@@ -3138,6 +3138,8 @@ static int vega10_apply_state_adjust_rules(struct pp_hwmgr *hwmgr, + minimum_clocks.memoryClock = hwmgr->display_config.min_mem_set_clock; + + if (PP_CAP(PHM_PlatformCaps_StablePState)) { ++ stable_pstate_sclk_dpm_percentage = ++ data->registry_data.stable_pstate_sclk_dpm_percentage; + PP_ASSERT_WITH_CODE( + data->registry_data.stable_pstate_sclk_dpm_percentage >= 1 && + data->registry_data.stable_pstate_sclk_dpm_percentage <= 100, +-- +2.7.4 + |