summaryrefslogtreecommitdiffstats
path: root/meta/recipes-support
AgeCommit message (Collapse)Author
2015-05-03libcap: Avoid passing "-e" to makeMike Crowe
oe-core 51540b64f62234c145fc32cfa3fbbaaebbeece08 altered libcap.inc (at the time) to append to EXTRA_OEMAKE rather than assign to it. The default value for EXTRA_OEMAKE contains "-e". This means that the change caused "-e" to be passed to make for the first time. Unfortunately passing "-e" subtly changes the behaviour of libcap's Make.Rules under recursive make when prefix="" (which it is for us since we're using meta-micro.) Without "-e" the prefix comes from the command line in both the parent and submakes. This takes precedence over any attempt to reassign it with a simple "=" operation so the headers are correctly installed in (empty string)/include. With "-e" the prefix still comes from the command line in the parent make but from the environment in the submake. The attempt to assign it fails in the parent make as before, but not in the submake so the headers are installed incorrectly in /usr/include. In all four cases the "ifdef prefix" else clause is executed. So, let's assign EXTRA_OEMAKE in order to avoid using "-e" at all. (From OE-Core rev: a8d35fa4fd76ea4a70063492cd5eab0858f2edb6) Signed-off-by: Mike Crowe <mac@mcrowe.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-05-03libtasn1: Upgrade 4.0 -> 4.5Jussi Kukkonen
* Remove configure.ac-patch as unnecessary (From OE-Core rev: d30cb87b6515b8ef3b953d9563354b471cfbdb86) Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-05-03gnutls: Upgrade 3.3.12 -> 3.3.14Jussi Kukkonen
(From OE-Core rev: 037e49ffa24a175a34fd6d225206f007da6fe8c3) Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-30curl: Fix wrong assumption about sizeof off_t on largefile systemsKhem Raj
This issue was reported on poky ml as well see https://lists.yoctoproject.org/pipermail/poky/2013-December/009435.html Change-Id: Iedf22467889893111fde0433e411fd0546a38546 (From OE-Core rev: 3c58712465494e441c4036a7cf21d2e6d343efab) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-30nspr: remove nspr-CVE-2014-1545.patchRobert Yang
It is a backport patch, and verified that the patch is in the source. (From OE-Core rev: a7e723bd78e280ae48e6de725b2881b35ae21f5c) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-29gpgme: Fix to use pkg-config in .m4 filesRichard Purdie
pkg-config is less error prone than -config files so switch to using it (we already do for most of the rest of the gpg stack). (From OE-Core rev: 046c7fd45fcf0c9226f76d51425978264930653b) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-28libunwind: don't use gold for mipsRobert Yang
The gold doesn't work for mips or mips64: configure:3867: checking whether the C compiler works configure:3889: mips-poky-linux-gcc -meb -mabi=32 -mhard-float -march=mips32r2 --sysroot=/buildarea/lyang1/test_uni/tmp/sysroots/qemumips -O2 -pipe -g -feliminate-unused-debug-types -Wl,-O1 -Wl,--as-needed -fuse-ld=gold conftest.c >&5 collect2: fatal error: cannot find 'ld' (From OE-Core rev: 3c6746748a845b5156f81fe7a01caa58ee29e938) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-27libsoup-2.4: Upgrade 2.46.0 -> 2.50.0Jussi Kukkonen
(From OE-Core rev: 0731fb03b5cc40502f90912fb2e72b54b777509d) Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-27curl: upgrade to 7.42.0Maxin B. John
Upgrade include these security fixes: 1. CVE-2015-3143 2. CVE-2015-3144 3. CVE-2015-3145 4. CVE-2015-3148 (From OE-Core rev: 9d2cb0e2183c24b4cf42c078d75c10ba1e4b6e56) Signed-off-by: Maxin B. John <maxin.john@enea.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-24nss: improve the script signlibs.shJackie Huang
The *.chk files are installed in ${libdir} by nss, which is already known, no need to 'find' to get the file list, and 'ls' is more faster than 'find'. (From OE-Core rev: 7eba8ba126e8757d0b1d5c3a758748e42c3646ff) Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-21curl: remove extra dev and staticdev from PACKAGESRobert Yang
There should be only one dev and dbg package. (From OE-Core rev: eb972e9b4b4210fa1c35fc0fae0ada27264b2e66) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-21recipes: Fix charset.alias for muslKhem Raj
This is same gnulib fix replicated across needed recipes Change-Id: I756713407111a726eae98e26c9c1ff64981371c0 (From OE-Core rev: fbe6d2c12aa9f7956bc87efeb68cb64b26b60c7a) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-21libunwind: use gold for all archsRobert Yang
At least the following boards have build errors without using gold: qemux86, qemux86-64, qemuarm, qemuaarch64, qemuppc. The error is: ld: copy reloc against protected `_Uaarch64_local_addr_space' is invalid ld: failed to set dynamic section sizes: Bad value ld: copy reloc against protected `_Uaarch64_local_addr_space' is invalid ld: failed to set dynamic section sizes: Bad value | collect2: error: ld returned 1 exit status So use gold for all archs to fix the problem. (From OE-Core rev: 3dd233ac0c80393824100c54bb525236f8290fd2) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-21lz4: update package to 128 and SRC_URIArmin Kuster
The main reason for the update is to use github as the project moved away from googlecode. (From OE-Core rev: 090727384bed38c4317a25d2ecf4c7855a3ffaaa) Signed-off-by: Armin Kuster <akuster@mvista.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-19gmp: remove referencing paths from the build hostJunling Zheng
Currently ${D}${includedir}/gmp.h references the path of build host incorrectly, remove it. (From OE-Core rev: 97d56a5b8e4f15eb32095f242eb2fd62fc5d85f2) Signed-off-by: Junling Zheng <zhengjunling@huawei.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-19libgcrypt: modified the license of dumpsexp.Lei Maohui
Because dumpsexp.c is GPLv3. So pick up the dumpsexp and modified license to GPLv3. (From OE-Core rev: 18cc7893e453bb10e395ff81dd10c0b5872a1742) Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-19libunwind: fix build with aarch64Robert Yang
Referred to RP's fix for x86 and x86-64: 34d517a5626ce2465f776367349bd9e66bf8ed1f libunwind: Build with gold to avoid build failures Fixed: aarch64-poky-linux/4.9.2/ld: copy reloc against protected `_Uaarch64_local_addr_space' is invalid aarch64-poky-linux/4.9.2/ld: failed to set dynamic section sizes: Bad value aarch64-poky-linux/4.9.2/ld: copy reloc against protected `_Uaarch64_local_addr_space' is invalid aarch64-poky-linux/4.9.2/ld: failed to set dynamic section sizes: Bad value | collect2: error: ld returned 1 exit status (From OE-Core rev: 31d84f67f74b31b479409cfa446b14ac67bb3707) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-19aspell: inherit binconfig-disabledRobert Yang
There is a pspell-config. (From OE-Core rev: 53c8a954e699b3ae3e7a0a2b3860cf7c9ad1288e) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-13libgpg-error 1.18: simplify tupple handling and add armv8b supportKoen Kooi
Add a default option to the case statement and remove the duplicates. Also add support for armv8b architectures. (From OE-Core rev: 8d207e55031c0b93387e728f4312b8cb34ad5b12) Signed-off-by: Koen Kooi <koen.kooi@linaro.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-13libfm-extra: Add own nls.m4Khem Raj
It helps to build when NLS is disabled distro-wide otherwise it has dependency on gettext to provide it Change-Id: Ib6920629b5ab1a1938cc5dfa447078f6fca234c7 (From OE-Core rev: 67a76eae50182da4426f35a96802f5d08b38e69b) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-13vte: Pass _GNU_SOURCE via CFLAGSKhem Raj
It uses function extentions like ptsname_r() so we need to let build know about it Change-Id: I5a06d08c56529a6b2cf3adf264656ae03b95c1d4 (From OE-Core rev: 1aa0346cf2a2104cfc969bfeb4ac58fa923d5fcb) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-13libproxy: Include select.h for posix complianceKhem Raj
unearthed with musl Change-Id: I527139905785f253e41dd6a2f0cf555eee752a3a (From OE-Core rev: 615ade48bfb8f1d1287e4ec79f4e2f4b610bdb5b) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-13aspell: remove libpspell-dev from PACKAGESRobert Yang
There should be only one dev and dbg package. (From OE-Core rev: b2a59adec6804dfeb85f2aef6bd8f7b2d07929b4) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-13acl/attr: remove extra dev and staticdev from PACKAGESRobert Yang
There should be only one dev and dbg package. (From OE-Core rev: 93afa6fcc0f84f305fad97407ef408e7a1e37652) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-13at-spi2-core: Upgrade to 2.16.0Jussi Kukkonen
* Add new org.a11y.atspi.Registry D-Bus service file (From OE-Core rev: e4cbbfb167e22211abf41b90b71cab2fe5b330da) Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-13at-spi2-atk: Upgrade to 2.16.0Jussi Kukkonen
(From OE-Core rev: dae6fccacfc7dbf3b2e5e1e0cb6de69d01671458) Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-13atk: Upgrade to 2.16.0Jussi Kukkonen
(From OE-Core rev: 191fbdecfd1eecb95fb433f6854bb6862561987c) Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-10at-spi2-core: Add nls.m4 from gettextKhem Raj
This is needed for building it with musl, since we disable NLS, I think it will fails in same way with glibc if NLS was disabled there too Change-Id: I95c6858adfb33361cab466999e0bacb47c1e1fde (From OE-Core rev: 5dc86b1a45581e2b6ae845b818e2323645c9cff4) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-10libusb-compat: Include sys/types.h in usb.hKhem Raj
Fixes compile errors when usb.h is included in other packages, it expects sys/types.h to be there, instead it should include it itself Change-Id: Ib49477b7d3f3cd97d65c9578bdc33f2ee33f5a26 (From OE-Core rev: 577b5c6ce6753b9ae3587da47caf6ecfac358668) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-10libdaemon: Explicitly include unisttd.h instead of sys/unistd.hKhem Raj
Fixes build errors on musl Change-Id: Ia00bdc9c0578c8d5e1249c9d433079d795e83cb2 (From OE-Core rev: bdd9bd8beaf49133cd62b27255897cdbd2b42b49) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-10libgpg-error: Fix native build on i686Gary Thomas
Most modern x86 systems return i686 as the system type. This patch handles i486, i586 and i686 correctly. (From OE-Core rev: 1b24eaa71702c07e525d8a62c08c0983e9917468) Signed-off-by: Gary Thomas <gary@mlbassoc.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-10nss: Fix build in x32 ABIAníbal Limón
When try to build nss with x32 ABI enabled fails because it need to be specified USE_X32 env var. [YOCTO #7420] (From OE-Core rev: 2898c2cf94bd690ebfc4ab5f4d220e6ea05aca82) Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-10curl: upgrade to 7.41.0Chen Qi
(From OE-Core rev: ab2ca0f4e0fc2e644bf248ede350d0c5eec326ed) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-08gnupg: 2.1.1 -> 2.1.2Robert Yang
(From OE-Core rev: bd24517116455492abbc429196e5c9db4c1be1c7) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-08libgcrypt: 1.6.2 -> 1.6.3Robert Yang
(From OE-Core rev: 7a5882310a6619a926f047c517fe6fa3f5f32e7a) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-08libunwind: Build with gold to avoid build failuresRichard Purdie
The library fails to build with binutils 2.25 and standard ld. This issue is fixed in gcc 5 with no plans to backport to gcc 4. Easiest workaround for now is to use gold as the linker for the library since gold does not have the issue. The bug is x86 only. (From OE-Core rev: 34d517a5626ce2465f776367349bd9e66bf8ed1f) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-08pinentry: update to 9.1Armin Kuster
Fix build problems on AIX. Update to automake 1.14. remove "PR" (From OE-Core rev: ac4a858d5b841e2224753b164b5c380f98153080) Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-08libevent: update 2.0.21 -> 2.0.22Andre McCurdy
(From OE-Core rev: 08285ef71e1b506e5802eedeefc6a6650af3cb48) Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-08libevent: control openssl support via PACKAGECONFIGAndre McCurdy
(From OE-Core rev: 1969c49b16b158324eec95da8ea56a70f8863ec9) Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-08nss: generate debug infoJoe Slater
Because the build of nss seems to ignore CFLAGS, we never have put source code in the -dbg package. We do not address the CFLAGS issue, but we do add -g to the definition of CC so that we will generate debug info. We also let package.bbclass populate the -dbg package instead of forcing the contents locally. (From OE-Core rev: 0ec01bbd845b61798366441b2c7e5b8738db6b32) Signed-off-by: Joe Slater <jslater@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-08lzop: Fix build using x32 ABIAníbal Limón
When tries to build lzop using x32 ABI fails trying to get FLAGS register that is 64-bit and destination variable is 32-bit size_t. [YOCTO #7424] (From OE-Core rev: 6122c5e02b96ab786204d08b470177d824004d24) Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-02createrepo: Implement --dbpath command line optionEd Bartosh
--dbpath option can be used in cases where users don't want createrepo to use system rpm db to avoid possible collisiouns with other programs. For bitbake builds it would be possible to specify different databases even for every createrepo run. Considering that rootfs builds can run multiple createrepo in parallel, it can help to avoid race conditions caused by accessing or creating the same rpm database by multiple createrepo instances at the same time. (From OE-Core rev: 7dc6d50ac1fc20a262b62330d950a8e30acdf0b6) Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-02db: fix parallel issueRobert Yang
Fixed parallel issue: libtool: link: `bt_rec.lo' is not a valid libtool object Makefile:867: recipe for target 'libdb-6.0.la' failed make: *** [libdb-6.0.la] Error 1 (From OE-Core rev: b125feb069fd199c657df804453bd70e0e1939e2) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-03-25libunwind: use xz, because it fails to detect liblzma provided by lzmaAndreas Oberritter
(From OE-Core rev: 53bafb0d22a84186d215eb8f106ccff69f1b0480) Signed-off-by: Andreas Oberritter <obi@opendreambox.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-03-25ca-certificates: clean up before do_compile()Andreas Oberritter
Otherwise the script which converts mozilla certificates extracts each certificate twice. (From OE-Core rev: 3aae6a3c2786713115451f6b6fe151ba69369c1d) Signed-off-by: Andreas Oberritter <obi@opendreambox.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-03-22nss: move /usr/bin/smime to nss-smimeMartin Jansa
* remove perl runtime dependency from main package (From OE-Core rev: c799c753d56fcb9468d32d7622817ecf7932cdf4) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-03-16curl: remove samba from PACKAGECONFIG[smb] DEPENDSAndre McCurdy
Enabling support for the smb protocol does not create a build time dependency on samba. (From OE-Core rev: b4c7921001a30e0162cacbe12b1a5b888b36db57) Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-03-16libevent: fix SRC_URIRobert Yang
The wget reported errors for the past URI since it can't follow the redirection well: Connecting to cloud.github.com (cloud.github.com)|54.192.140.6|:443... connected. OpenSSL: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure Unable to establish SSL connection. (From OE-Core rev: b2d7193da713120c97a452ca56742aca15911bee) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-03-16libunwind: backport patch to link against libgcc_s intead of libgccJonathan Liu
(From OE-Core rev: 9906f949627b64f9fc36bc129bb37c8dd84dc27c) Signed-off-by: Jonathan Liu <net147@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-03-10libgpg-error: Add -P option to CPPFLAGSKhem Raj
Fixes https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1301822.html libgpg-error FTBFS when built with gcc-5. Here is the relevant excerpt: | Making all in src | make[4]: Entering directory '/tmp/buildd/libgpg-error/libgpg-error-1.17/src' | gawk -f ./mkstrtable.awk -v textidx=3 \ | ./err-sources.h.in >err-sources.h | gawk -f ./mkstrtable.awk -v textidx=3 \ | ./err-codes.h.in >err-codes.h | gawk -f ./mkerrnos.awk ./errnos.in >code-to-errno.h | gawk -f ./mkerrcodes1.awk ./errnos.in >_mkerrcodes.h | gcc -E -D_FORTIFY_SOURCE=2 _mkerrcodes.h | grep GPG_ERR_ | \ | gawk -f ./mkerrcodes.awk >mkerrcodes.h | rm _mkerrcodes.h | gcc -I. -I. -o mkerrcodes ./mkerrcodes.c | In file included from ./mkerrcodes.c:26:0: | ./mkerrcodes.h:9:5: error: expected expression before ',' token | { , "GPG_ERR_E2BIG" }, | ^ It makes invalid assumptions on undefined behaviour of gcc. To see why, let us look at the contents of the intermediate steps: _mkerrcodes.h (deleted): | ... | #ifdef E2BIG | E2BIG GPG_ERR_E2BIG | #endif | #ifdef WSAE2BIG | WSAE2BIG GPG_ERR_E2BIG | #endif | ... gcc -E -D_FORTIFY_SOURCE=2 _mkerrcodes.h | grep -v '^$': | ... | # 26 "_mkerrcodes.h" 2 | 7 | # 31 "_mkerrcodes.h" | GPG_ERR_E2BIG | # 37 "_mkerrcodes.h" 3 4 | 13 | # 37 "_mkerrcodes.h" | GPG_ERR_EACCES | ... As can be seen here, the cpp from gcc-5 can split lines and "grep GPG_ERR_" fails to account for that. Change-Id: I6f1476e4afc7163ebc3a05106ceaa3b83e3fab3e (From OE-Core rev: 3993378c9a8994688fda15a5cd05e04a435d2d54) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>