summaryrefslogtreecommitdiffstats
path: root/meta-selftest
AgeCommit message (Collapse)Author
2021-10-30overlayfs: meta-selftest recipe fixVyacheslav Yurkov
Avoid strict assignment in the recipe to allow overrides in .inc file (From OE-Core rev: 2006e157d7dae3fd6aefd8f0f84afa0371b69449) Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-10-30meta: Add explict branch to git SRC_URIsRichard Purdie
There is uncertainty about the default branch name in git going forward. To try and cover the different possible outcomes, add branch names to all git:// and gitsm:// SRC_URI entries. This update was made with the script added to contrib in this patch which aims to help others convert other layers. (From OE-Core rev: b51c405faf6f8c0365f7533bfaf470d79152a463) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-10-04wic/bootimg-efi: Add Unified Kernel Image optionKristian Klausen
"A unified kernel image is a single EFI PE executable combining an EFI stub loader, a kernel image, an initramfs image, and the kernel command line. [...] Images of this type have the advantage that all metadata and payload that makes up the boot entry is monopolized in a single PE file that can be signed cryptographically as one for the purpose of EFI SecureBoot."[1] This commit adds a create-unified-kernel-image=true option to the bootimg-efi plugin for creating a Unified Kernel Image[1] and installing it into $BOOT/EFI/Linux/ with a .efi extension per the the Boot Loader Specification[1][2]. This is useful for implementing Secure Boot. systemd-boot is the only mainstream bootloader implementing the specification, but GRUB should be able to boot the EFI binary, this commit however doesn't implement the necessary changes to the GRUB config generation logic to boot the Unified Kernel Image. [1] https://systemd.io/BOOT_LOADER_SPECIFICATION/#type-2-efi-unified-kernel-images [2] https://systemd.io/BOOT_LOADER_SPECIFICATION/ (From OE-Core rev: b0573f240525df561ddef6e47cb285b217d38487) Signed-off-by: Kristian Klausen <kristian@klausen.dk> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-09-23oeqa/selftest: Add tests for bitbake shell/python task outputRichard Purdie
We've seen issues where shell/python tasks lose their log file entries or output and also where output is duplicated. Add some tests to attempt to spot regressions in this area in future. (From OE-Core rev: 414020a9bd656ee61efe2f47db1b31d86b15c1c8) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-09-04selftest/python-async-test: set precise BSD licenseRoss Burton
"BSD" is ambiguous, use the precise license BSD-3-Clause. (From OE-Core rev: 78a8427eb11d2931afcbf2a24d2441bf08bac0cf) Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-08-12overlayfs: meta-selftest recipeVyacheslav Yurkov
The recipe demonstrates example usage of overlayfs bbclass (From OE-Core rev: 1ad7a6fdd6382a30f1d9e115840ce8243b7fce2f) Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-08-12systemd-machine-units: add bbappend for meta-selftestVyacheslav Yurkov
(From OE-Core rev: 797ab6d3237c3248778ea3c9304e92dcc94a67da) Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-08-02Convert to new override syntaxRichard Purdie
This is the result of automated script conversion: scripts/contrib/convert-overrides.py <oe-core directory> converting the metadata to use ":" as the override character instead of "_". (From OE-Core rev: 42344347be29f0997cc2f7636d9603b1fe1875ae) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-04-18layer.conf: Update to add post 3.3 release honister seriesRichard Purdie
(From OE-Core rev: c0f43f19fecfd16f973c2d2f8227106c46b451bb) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-03-16meta-selftest: Add HOMEPAGE / DESCRIPTIONDorinda Bassey
Added HOMEPAGE and DESCRIPTION for recipes with missing descriptions or homepage. (From OE-Core rev: f36f176dc0316a79ae288c3b4f6c2eab366810dd) Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-03-15layer.conf: Update for hardknott release seriesRichard Purdie
(From OE-Core rev: d430bf39f2f2ecdf989b33f7405751844d783fc5) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-03-10oeqa/selftest: add test to verify that poisoned sysroots are detectedRoss Burton
Add a recipe that explicitly searches /usr/include, and use that in oe-selftest to verify that host include paths are correctly causing build failures. (From OE-Core rev: b3e3eba796b843021b264f0e98dc30f983775d58) Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-03-02Add core-image-weston to reproducible build testsJan-Simon Moeller
This change adds core-image-weston to the reproducible build test. For this we also need to update the static-group and static-passwd. Besides the world package build which includes the wayland package, this adds a wayland/weston-based image to the reproducible build test. (From OE-Core rev: ffc4de47988ccf7568eecc8a27e8964beeaaacfb) Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-02-21selftest/incompatible_lic: Update the tests after the 'or-later' license ↵Richard Purdie
handling changes With the separate of the "-only" and "-or-later" licenses, we need to update the tests to match the messages now given in the output. Also use a mix of canonicalised and non-canonlised names in the reference recipes to help test those cases and ensure coverage. (From OE-Core rev: b7f38af7ac9449178c603c5349808b8c0dd84d35) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-01-16apt: add nativesdk supporthongxu
1. Add nativesdk support - Apply the same patches of native - Generate the same apt.conf.sample of native 2. Create user '_apt' to fix apt runtime warning [snip] $ apt update ... W: No sandbox user '_apt' on the system, can not drop privileges [snip] RP: Add comment about need to user RP: Add user to selftest static-passwd (From OE-Core rev: be36b825ada573b2a7df9884eaab78664928594a) Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-12-30meta-selftest/staticids: Add ids for other recipesRichard Purdie
Add dhcpc's uid/gid to the static configs used by meta-selftest for testing since dhcpc was added to OE-Core. Also realised many other ids were missing for other OE-Core recipes so also add those. (From OE-Core rev: 120551f30d86d3d5bd992c50b6751cb715a57e30) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-12-30selftest-chown: add test for fifosTrevor Woerner
Verify that fifos are properly handled by the build system. (From OE-Core rev: 53988b6389ce618d4cff52bd09ae91108beca354) Signed-off-by: Trevor Woerner <twoerner@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-12-20oe-selftest: fitimage: add test for signing FIT imagesPaul Eggleton
Add a new test to verify signing FIT images. Also includes testing for the newly introduced FIT_SIGN_INDIVIDUAL, UBOOT_MKIMAGE, UBOOT_MKIMAGE_SIGN, and UBOOT_MKIMAGE_SIGN_ARGS variables. (From OE-Core rev: 3c054762278fd8c5dd827dbac15f4fa066e6c19e) Signed-off-by: Paul Eggleton <paul.eggleton@microsoft.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-12-20bitbake.conf: Prevent pyc file generation in pseudo contextPaul Barker
This also effectively reverts commit b6d30c21b0: bitbake.conf: Extend PSEUDO_IGNORE_PATHS to ${COREBASE}/meta The contents of ${COREBASE}/meta were ignored as pyc files could be generated for the contents of the lib subdirectory if python modules were imported within a pseudo context. However this doesn't protect us from pyc files being generated in the lib directories for other layers. It's far better to tell python not to produce pyc files when running under pseudo (by setting the PYTHONDONTWRITEBYTECODE variable) as this will cover any location where pyc files could possibly be created. This variable is set in FAKEROOTBASEENV so that it applies to the bitbake-worker instance for fakeroot tasks, preventing pyc files from being generated for imports in python tasks themselves. Also add a test case to ensure that pyc files are not created in tasks which are executed under pseudo. (From OE-Core rev: 73d538f20743017a44cea4c20dbe09a0327cfc71) Signed-off-by: Paul Barker <pbarker@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-12-15wic-image-minimal: only depend on syslinux on x86 targetsRoss Burton
Following other examples, only depend on syslinux when targetting x86. (From OE-Core rev: c58fcc1379ca5755a5b670f79b75e94370d4943c) Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-12-15wic: Introduce empty plugin to create unformatted empty partitionsDiego Sueiro
The empty wic plugin is used to create unformatted empty partitions for wic images. To use it you must pass "empty" as argument for the "--source" parameter in the wks file. For example: part foo --source empty --ondisk sda --size="1024" --align 1024 Also adds a selftest for this plugin where the 'Fstype' column from 'wic ls' should be empty for the second partition as listed in test_empty_plugin.wks. (From OE-Core rev: 77d174fc80663403ef76c5b808aafc1117d3545c) Signed-off-by: Diego Sueiro <diego.sueiro@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-10-20selftest/virgl: drop the custom 30 sec timeoutAlexander Kanavin
This is occasionally reached on the AB; I am not sure if it is due to host overload, or guest malfunction, but let's use the default 300 sec and see if it helps. [YOCTO #14097] (From OE-Core rev: 93a0352e2e8539d109f6d3ddc0ed02b3b9256e86) Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-10-08selftest: add test for recipes with patches in overridesRoss Burton
devtool doesn't quite behave right when a recipe has patches applied in overrides, so add a test case to exercise that behaviour. (From OE-Core rev: ad89c3254cc6c06026f1bebe23ec3717c1546633) Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-08-26selftest/recipetool: Drop globbing SRC_URI test, no longer supportedRichard Purdie
Globbing is a bad idea in SRC_URI, it breaks the task checksums and can't really be fixed. Since we're removing it, drop the test for its interaction with recipetool. (From OE-Core rev: 8bf93fa89aa1ba73f6eec05b95d6e8ca5f7d4c4b) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-08-25meta-selftest: correct the virgl test for 5.8 kernelsAlexander Kanavin
(From OE-Core rev: 879bbe341b47ff576de76b2e8929df9f72f7f813) Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-06-09selftest-nopackages: New recipe in meta-selftestPaul Barker
This provides a test recipe which is known to inherit the nopackages bbclass. (From OE-Core rev: fe7096f1b921139b85fc22e3c948350521fe3406) Signed-off-by: Paul Barker <pbarker@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-06-09selftest-ed: Support native buildsPaul Barker
This allows tests to switch to selftest-ed-native which has far fewer dependencies than selftest-ed. (From OE-Core rev: cb40325e2fcdf2036b71af5fcf01984d11ef2934) Signed-off-by: Paul Barker <pbarker@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-06-09selftest: git-submodule-test: New recipe for testing a gitsm SRC_URIPaul Barker
(From OE-Core rev: ee6de1281ee16df0d43f635a12881b39fd9061d0) Signed-off-by: Paul Barker <pbarker@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-06-04meta-selftest: add test for .patch file with long filename and without subjectMartin Jansa
(From OE-Core rev: 7c3e17f34c74e838990006aaf570df501aa2c167) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-06-04meta-selftest: add test of .gitignore in tarballMartin Jansa
(From OE-Core rev: 8ee4f7c076b0fdbfc5b9d6b5bbbf8a02f5d062a7) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-05-21devtool: do not write md5sums into upgraded recipesAlexander Kanavin
This will drop them md5sums from recipes that still have them, and will not re-add them for recipes where they're already removed. [RP: Added fix for the test recipe] (From OE-Core rev: 1609e77a4db04a4c01cbbff17261cd57e8f816ee) Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-05-18layer.conf: Move to gatesgarth namingRichard Purdie
We're still compatible with dunfell from the core perspective so that is left for compatibility (probably for the next week or two). (From OE-Core rev: 1e79324f8290b820fee034b0d4a8c353027879da) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-04-26oeqa/selftest: Add test for conflicting sysroot providerRichard Purdie
sysroot-test depends on virtual/sysroot-test which we build for one machine, switch machine, switch provider of virtual/sysroot-test and check that the sysroot is correctly cleaned up. The files in the two providers overlap so can cause errors if the sysroot code doesn't function correctly. Yes, sysroot-test should be machine specific really to avoid this, however the sysroot cleanup should also work. This adds a test for bug: [YOCTO #13702] (From OE-Core rev: 24ca62b3c1fd404b67d549b29aeeacf913e6dc86) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-04-26selftest/package: Add test to ensure ownership is preservedDaisuke Yamane
Yocto Bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13806 Add test_preserve_ownership to selftest/package. This test creates a file, a directory and a symbolic link and changes ownership, then compares with them installed in rootfs to ensure ownership is preserved. [Test without a commit 'bitbake: lib/bb/utils.py: Preserve ownership of symlink'] | 2020-03-14 10:01:14,519 - oe-selftest - INFO - test_preserve_ownership (package.PackageTests) | 2020-03-14 10:56:44,612 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/file | 2020-03-14 10:56:44,770 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/dir | 2020-03-14 10:56:44,822 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/symlink | 2020-03-14 10:56:44,879 - oe-selftest - ERROR - Incrrect ownership /etc/selftest-chown/symlink [root:root] | 2020-03-14 10:56:45,884 - oe-selftest - INFO - ... FAIL [Test with a commit 'bitbake: lib/bb/utils.py: Preserve ownership of symlink'] | 2020-03-14 10:58:49,599 - oe-selftest - INFO - test_preserve_ownership (package.PackageTests) | 2020-03-14 11:51:39,947 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/file | 2020-03-14 11:51:40,013 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/dir | 2020-03-14 11:51:40,063 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/symlink | 2020-03-14 11:51:41,118 - oe-selftest - INFO - ... ok (From OE-Core rev: 88c1824468109d0f78d5fee7b71baa1f3944db7f) Signed-off-by: Daisuke Yamane <daisuke.yamane@cybertrust.co.jp> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2020-03-15layer.conf: Update to LAYERSERIES_CORENAME to dunfellRichard Purdie
Update the layer core name to the new release name. (From OE-Core rev: 090bb3b44ba0cc01c29942c00d43e910d1ff735e) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-12-16incompatible_lic.py: Add tests for incompatible licenses with wildcardsPeter Kjellerstedt
Suggested-by: Quentin Schulz <quentin.schulz@streamunlimited.com> (From OE-Core rev: ef7c44c9bdf30a02ccc71f26c27aab45d6adf1fb) Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-11-21selftest: check that 'devtool upgrade' correctly drops backported patchesAlexander Kanavin
There was a regression in this functionality that went unnoticed due to lack of tests. (From OE-Core rev: a75e4eceb703b2b13ddd4ba3dea3a86af0b0a9eb) Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-11-04recipeutils-test: use a small dependency in the dummy recipeRoss Burton
recipeutils-test has virtual/libx11 as a DEPENDS, but this will cause errors if the recipe is built in an environment without x11 in DISTRO_FEATURES. This dependency isn't actually used for anything so we could remove it, but to save updating the test cases too just swap virtual/libx11 for zlib. [ YOCTO #13611 ] (From OE-Core rev: 7dbd72a08a81436d9ddd168f44e5c13e28eaff99) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-11-04selftest: skip virgl test on centos 7 entirelyAlexander Kanavin
With the sdl frontend, qemu isn't able to even boot fully, so let's skip the test early. (From OE-Core rev: 7b0708da20e4f04070837e5696e4fa3ee5990e8f) Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-10-19aspell: upgrade from 0.60.7 to 0.60.8Trevor Gamblin
New version fixes CVE-2019-17544 as well as various other bugs. CVE: CVE-2019-17544 RP: Added tweak to fix meta-selftest (From OE-Core rev: 3b788da31af6296a0404ed6080aef17708d61303) Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-10-08layer.conf: Update for zeus seriesRichard Purdie
(From OE-Core rev: a5c9709b8da6e7ad62167b5036e7f454a62aa83e) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-09-27oeqa: Test multiconfig parsingJoshua Watt
Add a test to verify that when multiconfig conf files changed, recipes are correctly reparsed. [YOCTO #13541] (From OE-Core rev: a424ef0a0c49123f4518e8fef993fd10f6fc5f4e) Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-08-12aspell: update to 0.60.7Oleksandr Kravchuk
Removed patch was upstreamed. (From OE-Core rev: 78189e465f5b7afa756fe20de024c83b3d5ea9a5) Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-07-31fortran-helloworld: neaten recipeRoss Burton
Use ${FC} instead of constructing the fortran name/arguments explictly, and clean up installation. (From OE-Core rev: a0d85e117fb636ffa12253b19f0ab2b5055e6380) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-07-23meta/lib/oeqa: Test for bootimg-biosplusefi Source2.8_M2William Bourque
Add unittests for bootimg-biosplusefi SourcePlugin in wic module. First test check wic creation works correctly. Second test uses qemu to boot image and checks that it has both EFI and BIOS files in a single partition. (From OE-Core rev: e0c3436241afca93f107e325d1b9ffcdebf706cd) Signed-off-by: William Bourque <wbourque@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-27fortran-helloworld: add a very dumb Fortran Hello World for testingRoss Burton
For future runtime testing something more complex is preferred but this is sufficient to exercise the cross compiler. (From OE-Core rev: 7d5f39ca717fa1caea357a4366bbf106386432c0) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-12selftests: add tests for INCOMPATIBLE_LICENSEQuentin Schulz
One bug went unnoticed without these selftests: an INCOMPATIBLE_LICENSE with a non-SPDX license for a package with that non-SPDX license wasn't enforcing the denial of build for said package. See 4b6ce4604cc15e289a48f8586d58a101b7a70b52 ("meta: license: fix non-SPDX license being removed from INCOMPATIBLE_LICENSE") While adding a test for that particular case, let's add a few more so that we cover a handful more use cases of INCOMPATIBLE_LICENSE. (From OE-Core rev: 6c2ca52218c196e7ccf6b3275bffc3e3a04193c6) Signed-off-by: Quentin Schulz <quentin.schulz@streamunlimited.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-10multiconfig: Adapt to bitbake switch 'multiconfig' -> 'mc'Richard Purdie
(From OE-Core rev: 8a6f7c1e455156966f467008645fef14db679ccf) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-09meta/lib+scripts: Convert to SPDX license headersRichard Purdie
This adds SPDX license headers in place of the wide assortment of things currently in our script headers. We default to GPL-2.0-only except for the oeqa code where it was clearly submitted and marked as MIT on the most part or some scripts which had the "or later" GPL versioning. The patch also drops other obsolete bits of file headers where they were encoountered such as editor modelines, obsolete maintainer information or the phrase "All rights reserved" which is now obsolete and not required in copyright headers (in this case its actually confusing for licensing as all rights were not reserved). More work is needed for OE-Core but this takes care of the bulk of the scripts and meta/lib directories. The top level LICENSE files are tweaked to match the new structure and the SPDX naming. (From OE-Core rev: f8c9c511b5f1b7dbd45b77f345cb6c048ae6763e) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-04-02layer.conf: Update to warrior release name seriesRichard Purdie
(From OE-Core rev: 13e45fffb66c7cb7ba0d07bed063c0c5ce57004b) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>