aboutsummaryrefslogtreecommitdiffstats
path: root/bitbake/lib/bb/ui
AgeCommit message (Collapse)Author
2011-12-20ui/crumbs/hobprefs: trigger a reparse after changing IMAGE_FSTYPESJoshua Lock
As reported on the mailing list[1] when changing IMAGE_FSTYPES through the hob preferences a reparse is required before the changes will be picked up by the system. This patch sets the reload_required property of the class to true when the image types have been modified to ensure the reparse is triggered. 1. https://lists.yoctoproject.org/pipermail/yocto/2011-December/006002.html (Bitbake rev: 6c0babf08909307ab69a66ed06e77e8818b2a8c5) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-12-20ui/crumbs/runningbuild: handle InvalidTask eventsJoshua Lock
The knotty UI just ignores these and so should RunningBuild, if these events aren't handled the UI appears to hang. Fixes [YOCTO #1665] (Bitbake rev: 540ba78075bd525776aa23bf38bee66350c66534) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-27bitbake: Update users of getVar/setVar to use the data store functions directlyRichard Purdie
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-11-24knotty: Add support for logging the console to logfileRichard Purdie
The BB_CONSOLELOG variable is used to specify the console log file to use. This means people can look up things that happened during a build by may have scrolled off the screen. [YOCTO #1771] (Bitbake rev: a34ff490a46577a64345365fa1ac39c48d0861cd) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-10-24hob: fix backtrace when dismissing open dialogJoshua Lock
Clearly a logic/indentation error - we should only try and load the recipe should the file-chooser return OK. Fixes [YOCTO #1668] (Bitbake rev: db59297aa1861614ffaea4295b9b054baa8a12b9) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-25hob: store recipe path at load timeJoshua Lock
This fixes the internal dirtiness tracking such that if the Save menu item is selected after loading a recipe the existing file is updated rather than the user being prompted for the path to create a recipe at. (Bitbake rev: 00fc1d7249b5e217cc7c36ac71b63ddad1c5b769) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-25hob: fix building with current selections after reparseJoshua Lock
After the reparse we were setting the model to reflect the values before the reparse was triggered but clearing the internal variables used to test whether these values are set, leading to the UI erroneously reporting that selections had not been made. (Bitbake rev: 656eafe0f2c9ec7730d33e15705b8c720f787c49) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-25ui/crumbs/hobeventhandler: fix variable name typoJoshua Lock
(Bitbake rev: f7d0560307707fe10bf80820f1e6ae300864f915) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-25ui/crumbs/hobeventhandler: move remaining getVariable calls to initJoshua Lock
Instead of calling getVariable commands each time the BBPATH and BBFILES entries need testing cache the results as a member variable at object instantiation. Fixes [YOCTO #1521] (Bitbake rev: 109e1597671dfb7222672e268190aabc727960ca) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-21hob: fix opening of image output dir on image build completionJoshua Lock
Firstly, rather than polling the DEPLOY_DIR_IMAGE directory each time an image is built store the variable as a member of the hobeventhandler. Secondly emit the generic "build-complete" signal *after* the specialised "build-failed" or "build-succeeded" signals such that the appropriate state variables are set before we try and use them. (Bitbake rev: 043914a8b478fd4a7799acd1b44bdb3b0af2165a) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-21ui/crumbs/runningbuild: fix log messages right-click menuJoshua Lock
Pass the correct callback name to the connect method. (Bitbake rev: d2b9167a7b0eb3fcb31d64f915beef41aac659a5) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-20hob: enable package only builds even if an image has been builtJoshua Lock
Once an image build has been performed the selected_image variable would prevent the package only build choice being triggered - by setting the variable to None on reset we are able to perform package only builds after an image build. (Bitbake rev: 705156e2812afb288632f01416fcbbf9add26bee) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-20hob: fix build again when building packages onlyJoshua Lock
The different code paths for package vs image builds have lead to some bit rot in the package only build and an incompatability between package only builds and the build again mechanism. This patch unifies the code paths and fixes build again for package only builds. Fixes [YOCTO #1480] (Bitbake rev: ab6c63f35739c30df0e8a9d0f1ae982b96e538ed) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-20ui/crumbs/hobprefs: re-enable reloading of data after prefs changesJoshua Lock
When disabling the toolchain w/ headers checkbox in an early commit I accidentally disabled too much code. This re-enables adding the custom response handler to the Preferences dialog which triggeres a reparse of the metadata when appropriate preference changes are made. Fixes [YOCTO #1479] (Bitbake rev: bdbd724e806c9ca69cc1508bac7ec0a2dce95543) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-13hob: correctly set the selected image when loading a recipeJoshua Lock
When the user saves their recipe based on an existing image type, loads it in a newly run hob instance and clicks bake they should not be asked about building packages vs an empty image up. Partially addresses [YOCTO #1468] (Bitbake rev: f4be83aae77a713e2b5a2d094651639b6e641031) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-13hob: correctly handle an exceptionJoshua Lock
It doesn't matter if we can't remove the temprorary file, for some reason, so catch the exception and ignore it. Partially addresses [YOCTO #1468] (Bitbake rev: 4394e38b038e1bc9845adf01d73363157d98c96d) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-13ui/crumbs/hobeventhandler: don't check BBPATH and BBFILES each buildJoshua Lock
There's no need to check the BBPATH and BBFILES are set correctly each build when running multiple builds for one launch of the UI. Partially addresses [YOCTO #1468] (Bitbake rev: 39ed18e70e9f3a13b522b4ea02bf6f4bdb7de89c) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-13ui/crumbs/hobeventhandler: fix test for BBFILESJoshua Lock
It seems we have a race whereby the image_dir variable may not be set before it's tested for, since the variable is always the same set it in the initialiser. Partially addresses [YOCTO #1468] (Bitbake rev: 09f5aed2edb0b8f4a6570e1041b5db66cf2d17cc) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05hob: fix segfault on second buildPaul Eggleton
Some internal lists were not being cleared, resulting in incorrect program flow on the second build, causing a structure to be accessed incorrectly which resulted in a segfault. Fixes [YOCTO #1332] (Bitbake rev: 71ac7fda51ed80e9ef6d1a3bca653683893e4770) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05hob: clear out temporary file list after deletingPaul Eggleton
If you don't clear out files_to_clean after the files get deleted and then you run a second build, it will try to delete the files from the first build and you will get a "No such file or directory" error. (Bitbake rev: 069d85cde01d14f8da31ad5cbd843a4d99628d42) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05hob: disable removal of packagesJoshua Lock
It's felt that the stability of package deselection is not sufficient for the upcoming release and thus package removal should be disabled. I'd actually like to see this patch, or its effects, reverted as soon as the release bits have been frozen so that this issue can continue to be worked on. (Bitbake rev: 73b6ff4654d10baae59d83e8568d58d989e99dd7) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05ui/crumbs/runningbuild: mask run_buildstats failureJoshua Lock
The buildstats handler causes an exception with: "'NoneType' object has no attribute 'startswith'" early a build via hob, leaving a glaring red row which means nothing to the user. Mask this error until such a time as we have opportunity to correctly diagnose and fix the root problem. Workaround fix for [YOCTO #1433] (Bitbake rev: b0cce5b52a20c0dad5ec0c4053f437cae89b6137) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05ui/crumbs/hobprefs: disable 'build toolchain with headers'Joshua Lock
The generic meta-toolchain-sdk we are currently building when this option is enabled is likely unsuitable for the majority of images built with hob. Remove this option from the Preferences UI until such a time as we can correctly implement this feature to include the library headers for the selected packages. Addresses [YOCTO #1302] (Bitbake rev: 3157967d08266b8d1ac563ba609ac3027b60d040) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05hob: add a test to ensure hob is run with the required pre and post filesJoshua Lock
hob requires pre and post configuration files to store configuration values in, whilst this should (and will) be fixed long-term for so long as we require these files we should alert the user should they run without them. Fixes [YOCTO #1383] (Bitbake rev: bb3e9113074ea1254aa03a247a1a1070682df9c8) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05hob: reflect defaultsetup being default distroJoshua Lock
If no value is set for DISTRO the defaultsetup policy is used, reflect this in the UI by having defaultsetup selected in the Distribution combo when no other DISTRO is set. (Bitbake rev: 126267c545ede65042959d134ea75c0345577747) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05hob: use both pre and post files for hob configurationJoshua Lock
We need to set various variables *before* parse begins, the simplest way to ensure this is to use a pre configuration file for the relevant configuration entries. This series adapts hob to use both pre and post files to store its configuration. Any variables which affect initial parse are set in the pre file and all others in the post file. Unfortunately this requires hob related code to have even more hard-coded data as to what is relevant but this is the simplest way to solve issues with variables and parse order at this time. Addresses [YOCTO #1281] (Bitbake rev: 02ab0e11d8dd42f5ca440b3d8d2073e23f55113a) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-30ui/crumbs/tasklistmodel: don't add empty entries to COL_BINBJoshua Lock
(Bitbake rev: 85c5b8b3b9c805883537900a46eddb2301ee93f9) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-30ui/crumbs/tasklistmodel: loop optimisation in include_item()Joshua Lock
Rather than trying to iterate the model to find whether the item is already included and then iterate the model again to find the items path attempt to find the path first and if the path is found test whether the COL_INC of the row is set. (Bitbake rev: 82845569c37591f6b097b9db071484f8171a39ea) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-30ui/crumbs/tasklistmodel: remove unnecessary checkJoshua Lock
Cheaper to set COL_INC to True regardless of whether it's already set. (Bitbake rev: 12c6f98ba7a68baeeaee00594d910e1be8d55d87) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-30ui/crumbs/tasklistmodel: optimise find_path_for_item()Joshua Lock
Rather than calling get_path() for each iterated value use the get_value() method to lookup the COL_NAME value and only call get_path() for a match. This should save some time by potentially removing N-1 calls to get_path() from the loop. (Bitbake rev: d2450536269996147a22d6eafbdf72aa62afa4f6) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-30ui/crumbs/tasklistmodel: prevent packages depending on each otherJoshua Lock
Don't add y to x's COL_BINB if x is in y's COL_BINB - prevent circular dependencies. Further this patch improves the variable naming to make this code easier to follow. Fixes [YOCTO #1423] (Bitbake rev: 01ef2ab0d201f3cb3666462558c9cf485592e04f) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-30ui/crumbs/tasklistmodel: don't add same item to binb column more than onceJoshua Lock
In the same vein as a similar, earlier, patch where I missed the second loop which modifies the binb column. Fixes [YOCTO #1420] (Bitbake rev: 6ad1103b5fd592afa9ea03ef5a0d706604cc0e0f) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-29ui/crumbs/runningbuild: add a 'Copy' item to the messages right-click menuJoshua Lock
Add another item to the right-click menu enabled for log messages to copy the message to the clipboard. (Bitbake rev: 419b52e832f506504778d4d5957d1e77477bb513) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-29ui/crumbs/tasklistmodel: don't add same item to binb column more than onceJoshua Lock
(Bitbake rev: 5e95098be1c1f92c2d72fb371c94bab31c46cf83) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-24hob: disable some menu entries whilst build is in progressJoshua Lock
It doesn't make sense to be able to modify the preferences and add/remove layers whilst a build is in progress - disable the relevant menu items once the build has started and re-enable them once the user has returned to the creation view. (Bitbake rev: 0423587db09f6f28cf9d801f5657a84157f42dbe) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-24bb/ui/crumbs/tasklistmodel: fix find_reverse_depends methodJoshua Lock
This fixes an embarassing typo which meant the method actually returned a list of packages which didn't depend on the passed pn. (Bitbake rev: a17334e85869bf78d63df1b2336d68980a0b359f) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-24hob: don't set PARALLEL_MAKE and BB_NUMBER_THREADS based on cpu countJoshua Lock
This was actually broken with recent changes as the values were never persisted to a file (meaning they were unset on the server at reparse despite the UI indicating they were set). However, I've chosen to remove the 'feature' as pegging a users CPU without them asking to use high thread counts seems a little offensive. (Bitbake rev: 27dcf245abf3805be47894773406392fdf055e48) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/hob: warn and prevent image build if no IMAGE_FSTYPE is setJoshua Lock
If IMAGE_FSTYPE is empty and the user has opted to build an image warn them and prevent the build. Fixes [YOCTO #1267] (Bitbake rev: 023edbe6d04f25c7e0e7b615eb06cd3727c665cb) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/crumbs/hobprefs: fix setting IMAGE_FSYTPESJoshua Lock
We were setting the value as a list when a string is expected (Bitbake rev: fc3bb3a4f04f64c6d47c7bf040b7522e9204a458) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/crumbs/hobeventhandler: fix return values of *_image_output_typeJoshua Lock
These methods are expected to return lists. (Bitbake rev: 4e101de9034c20dfda0bb851e84f4315335620f6) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/hob: fix package only buildJoshua Lock
Use the models new get_selected_pn method to return a list of PN's for the selected items and pass that for a package only build, rather than passing a list of package names (which buildTargets can't handle). Fixes [YOCTO #1385] (Bitbake rev: c969857c7f5963098e6584803eafb4e2be0eea46) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/crumbs/tasklistmodel: track the PN for each entry in the modelJoshua Lock
Now that we've switched to packages in the model, rather than PN, it makes sense to add an extra field to store the PN of the package. This patch includes a convenience method to retrieve a list of selected PN's. (Bitbake rev: cf79424592a81378de5edad11cf6c4f427c94bcc) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23hob: don't try and build if user selects Bake with no selections madeJoshua Lock
If the user hasn't made any selections inform them that they need to do so before clicking Bake. Fixes [YOCTO #1384] (Bitbake rev: e176dcf637da2d0105a4361a46d5df5238e3b8ce) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/crumbs/tasklistmodel: store all binb, not just the firstJoshua Lock
This makes it easier for the user to determine what the effects of a removal may be, further it means we no longer need the find_alt_dependency method which could be a fairly time-consuming method depending on the size of the contents table. Partially addresses [YOCTO #1365] (Bitbake rev: 91d1f5f5a44c80e6702221509e2e9aadbe05bcc0) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/crumbs/tasklistmodel: remove useless items from dependency listJoshua Lock
Ensure the dependency list is uniquified, doesn't include self references and further doesn't include -dev references. (Bitbake rev: 70aebebc3867d52e460355667e711c7c6dcd50ce) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/crumbs/tasklistmodel: more robust checking for substringsJoshua Lock
Relying on the count() method of Str to determine whether the string contains a substring is error prone purely because the return value doesn't strictly convert to a Boolean value. To that end take the more pythonic approach of using the in operator (foo in bar) to check for the substring. Further, add a helper method for the common case of testing whether a pn is -native, -cross or virtual/ (Bitbake rev: d7768cefcddd59a5102d7e9b67e4416bf8603f55) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/crumbs/runningbuild: hide the progress bar on cache load completeJoshua Lock
When we receive the CacheLoadComplete command we need to ensure the progress bar is hidden as we can't expect the ParseComplete event, where this would usually be done. This patch makes the Goggle UI usable again. (Bitbake rev: 64dfc574c12d882761e4958c8b1881cd47a87e0d) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-23bb/ui/crumbs/runningbuild: reduce number of messages after recent msg changeJoshua Lock
The recent change to the message module to remove custom logging domains resulted in an increased number of messages being displayed in the running build view, ignore all messages lower than log level INFO. (Bitbake rev: a12da000a8e4138fbdfd77f9c49b11fc69a315e1) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-15Fixup remaining bb.msg.domain usersRichard Purdie
(Bitbake rev: d5abdacaf9ac604ef8d8c1bafb9b30617827cb4f) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-15bb/ui/crumbs/tasklistmodel: simplify conditional in include_itemJoshua Lock
No need to check if the name ends with -native or -cross as path will be None in this instance. (Bitbake rev: bca739cdf55ba2a1c5e372e512d4f088345f245f) Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>