aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2016-09-26toaster: layerdetails Update implementation of delete imported layered/submit/michaelw/toaster/delete_buttonsMichael Wood
Update the implementation of delete an imported layer so that it is consistent with the other delete messages and wording. Also use the new libtoaster way of setting a notification that the delete was successful. Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26toaster: customrecipe Add frontend feature to delete custom image recipeMichael Wood
[YOCTO #8132] Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26toaster: importlayer Convert success import to new notification systemMichael Wood
Use the simpler libtoaster method of showing a notification about successful import of a layer. Also a number of whitespace clean ups. Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26toaster: Add front end controls for deleting a buildMichael Wood
Add front end modal and controls for deleting a build from the build dashboard. Also convert the Actions list to links instead of buttons as per the design. [YOCTO #6238] Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26toaster: Add backend API for deleting a buildMichael Wood
Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26toaster: alerts and modals Avoid modals and alerts overlaying each otherMichael Wood
Make sure that when we spawn a modal we clear any notifications and also make sure that old notifications are cleared before showing a new one. Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26toaster: project page Implement front end feature to delete projectMichael Wood
Add confirm modal and api calls to delete a project from the project dashboard. [YOCTO #6238] Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26toaster: libtoaster Add a global notification set/show mechanismMichael Wood
We now have a number of places where we show change notifications based on an event in a previous page (imported a layer, deleted a build, deleted a project etc) and we show these notifications on various pages so we add a simple notification utility to libtoaster. Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26toaster: move MostRecentBuildsView to its own widgetMichael Wood
This view is specific to the builds dashboard rather than gernic api so like ToasterTable and ToasterTypeAhead we class it as a widget as it has a single purpose. Also clean up some flake8 identified issues. Original author of the code moved in this commit is Elliot Smith. Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26toaster: Clean up and convert to rest api project edit and get callsMichael Wood
Convert the project xhr calls into proper rest api and port the client side calls to use the new API. Fix all the pyflakes identified issues and clean up unused fields. Also remove the api and client side code for changing release on the fly as this is no longer supported. [YOCTO #9519] Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2016-09-26meta-environment: ensure corret TOOLCHAIN_CONFIGSITE_NOCACHE valueChen Qi
Expand TOOLCHAIN_CONFIGSITE_NOCACHE value immediately before inheriting cross-canadian to avoid HOST_ARCH being changed from TARGET_ARCH to SDK_ARCH, thus ensuring its correct value. [YOCTO #10255] (From OE-Core rev: 1e13d1fd22186af5544e7248dc12635cd2f2e08b) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24arch-mips: Add mips64-o32 tunesZubair Lutfullah Kakakhel
Add mips64 + o32 rootfs abi tune configurations (From OE-Core rev: ae5073c4abd8935c01d14d3e6395124f815bd10b) Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24tune-ppc[65]00.inc: Disable QEMU usermode usageOtavio Salvador
The QEMU usermode fails with invalid instruction error when used with those tunes. The issue is being tracked in [YOCTO: #10304]. (From OE-Core rev: f9fd1a7fdf03ade9735e137a526a54e723d03dc6) Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24qemu.bbclass: Allow use different QEMU binary depending of targetOtavio Salvador
There are architectures which support running in 32 and 64 bit flavours however the simulation is provided in a specific QEMU setting, requiring us to use a different binary. This patch allow this to be done using, for example: QEMU_TARGET_BINARY_ppce5500 = "qemu-ppc64abi32" (From OE-Core rev: 9b6d414fd27932ed1325de54e8e867c75b340e3d) Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24pseudo: Fix problem where pseudo could kill a container initMark Hatle
In a heavily loaded container, the child process might not started before the parent process had terminated. The child process attempts to signal the parent with SIGUSR1. If the parent had terminated, the parent becomes PID 1, which is generally init. When it signaled pid 1, it caused the docker mini-init to terminate. This doesn't happen in a traditional system, as systemd/sysvinit is protected to only root users can signal it. [YOCTO #10324] (From OE-Core rev: f6f13b049e8683d2a2af3e120ba979b58f9a7d9a) Signed-off-by: Mark Hatle <mark.hatle@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24scripts/runqemu: provide better error message on runqemu ifup failStephano Cetola
If runqemu-ifup fails hen running testimage, a rather cryptic error regarding "no tty present" is displayed. If this step fails, we should at least point the user at runqemu-gen-tapdevs. A quick search of this term in the manual will lead them to "Enabling Runtime Tests on QEMU" which should give them all the info they need. (From OE-Core rev: 3b6494fad2b8b65e0d52cda0cdf500e93c72823a) Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24scons.bbclass: rework parameters for install taskAndreas Müller
Fixes: * During install all files were recompiled -> redurced build time * For some recipes we found lot of links to build host image path (From OE-Core rev: 3d1d287785c388bebba2ba1f2d8f843a5c6a2417) Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24cracklib: Apply patch to fix CVE-2016-6318Dengke Du
Fix CVE-2016-6318 Backport from cracklib upstream: https://github.com/cracklib/cracklib/commit/47e5dec521ab6243c9b249dd65b93d232d90d6b1 (From OE-Core rev: bc7691c47f21a7d7549788fe0370c3080fc4dff5) Signed-off-by: Dengke Du <dengke.du@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24gnutls: Skip QA check for text relocation on x86Jussi Kukkonen
Current release has relocations in .text on x86. Silence the warning for now: Upcoming release should have a real fix. [YOCTO #10290] (From OE-Core rev: a55a20aea2128d777630a1c6d946f4434b18a227) Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24wic: remove partition imagesEd Bartosh
Preserving images for every partition doubles disk space consumed by an image build. As those images are not used, so it's better to remove them after assembling final image. (From OE-Core rev: 51171b4aa10f2218c5e27d785ca7bf4f3949a4b4) Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24openssl.inc: avoid random ptest failuresPatrick Ohly
"make alltests" is sensitive to the timestamps of the installed files. Depending on the order in which cp copies files, .o and/or executables may end up with time stamps older than the source files. Running tests then triggers recompilation attempts, which typically will fail because dev tools and files are not installed. "cp -a" is not enough because the files also have to be newer than the installed header files. Setting the file time stamps to the current time explicitly after copying solves the problem because do_install_ptest_base is guaranteed to run after do_install. (From OE-Core rev: 101e2a5e0b7822ca3de3d3a73369405c05ab3c5b) Signed-off-by: Patrick Ohly <patrick.ohly@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24openssl: update to 1.0.2i (CVE-2016-6304 and more)Patrick Ohly
This update fixes several CVEs: * OCSP Status Request extension unbounded memory growth (CVE-2016-6304) * SWEET32 Mitigation (CVE-2016-2183) * OOB write in MDC2_Update() (CVE-2016-6303) * Malformed SHA512 ticket DoS (CVE-2016-6302) * OOB write in BN_bn2dec() (CVE-2016-2182) * OOB read in TS_OBJ_print_bio() (CVE-2016-2180) * DTLS buffered message DoS (CVE-2016-2179) * DTLS replay protection DoS (CVE-2016-2181) * Certificate message OOB reads (CVE-2016-6306) Of these, only CVE-2016-6304 is considered of high severity. Everything else is low. CVE-2016-2177 and CVE-2016-2178 were already fixed via local patches, which can be removed now. See https://www.openssl.org/news/secadv/20160922.txt for details. Some patches had to be refreshed and one compile error fix from upstream's OpenSSL_1_0_2-stable was required. The server.pem file is needed for test_dtls. (From OE-Core rev: d6b69279b5d1370d9c4982d5b1842a471cfd2b0e) Signed-off-by: Patrick Ohly <patrick.ohly@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24arch-mips: Add mips64r2 tunesZubair Lutfullah Kakakhel
Add MIPS64r2 optimizations (From OE-Core rev: 4c10376bdfd54af75de840bd4a31386e6e89477e) Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24lttng-tools: adds DEPENDS to util-linuxMing Liu
lttng-utils rdepends on util-linux-libuuid, this fixes a do_package_qa QA warning. (From OE-Core rev: 8a25d4871f10021757041755be4e6bd7bc0292de) Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24lttng-tools: fixes a wrong header issueMing Liu
This fixes a following compiling issue: | agent.c:33:19: fatal error: error.h: No such file or directory | #include "error.h" it's back-ported from lttng-tools upstream, we need it in SRC_URI since 2.8 is still the latest release. (From OE-Core rev: 08c9a363cc600cb58ab98cf22de0f7963720dea3) Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24lib/oe/patch: improve accuracy of patch header extractionPaul Eggleton
When PATCHTOOL = "git", if we need to manually apply a patch and then commit it (i.e. when git am doesn't work) we try to extract the author / date / shortlog from the patch header. Make the following improvements to that extraction process: * If there's no explicit Subject: but the first line is followed by a blank line, isn't an Upstream-Status: or Index: marker and isn't too long, then assume it's good enough to be the shortlog. This avoids having too many patches with "Upgrade to version x.y" as the shortlog (since that is often when patches get added). * Add --follow to the command we use to find the commit that added the patch, so we mostly get the commit that added the patch rather than getting stuck on upgrade commits that last moved/renamed the patch * Populate the date from the commit that added the patch if we were able to get the author but not the date from the patch (otherwise you get today's date which is less useful). (From OE-Core rev: 896cfb10ec166a677cbb3b4f8643719cabeb7663) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24lib/oe/patch: exclude "From <hash>" from commit message when PATCHTOOL is "git"Paul Eggleton
If you leave "From <hash>" lines in the commit message it can actually break git rebase because it tries to interpret the line in the context of the current repository, and if the hash is invalid then a rebase will blow up with: fatal: git cat-file: could not get object info or in newer git versions: error: unable to find <hash> fatal: git cat-file <hash>: bad file (I hit this when I tried to do a devtool upgrade on openssl to 1.0.2i the first time I did "git rebase --skip") (From OE-Core rev: 19a6b18ac23cb2d7bb89203f774b2bee7f0cb03c) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24nativesdk-qemu-helper: drop old Zaurus flash toolsPaul Eggleton
These tools are relics of an earlier time when the Zaurus devices were reference platforms - these days they are no longer needed. It seems amazing that they survived earlier purges. (From OE-Core rev: 49919585e5cec2999201fce8cb1b70f1cf7f591e) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24bluez5: remove duplicated udev setting from FILES_${PN}Robert Yang
bitbake.conf already sets it. (From OE-Core rev: 73d138be52c7f7c55ec4ea1cda2d7c8ead85deec) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24pcmciautils: remove duplicated udev setting from FILES_${PN}Robert Yang
bitbake.conf already sets it. (From OE-Core rev: 2df7386f7199079353762c726c364e6c4377621d) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24eudev: don't move udev directoryRobert Yang
The code did "mv ${D}${base_libdir}/udev ${D}${nonarch_base_libdir}" which is not needed any more, eudev can work with ${base_libdir}/udev. (From OE-Core rev: 5e26b3df04716010b31b4c7ac0ac6b28982784f3) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24xf86-input-vmmouse: remove duplicated udev setting from FILES_${PN}Robert Yang
bitbake.conf already sets it. (From OE-Core rev: e196300e066aef347cee52a4fd2eae21725e41f7) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24mdadm: remove duplicated udev setting from FILES_${PN}Robert Yang
bitbake.conf already sets it. (From OE-Core rev: 79b38adb3cac86ac24aa8c13fa0403105f17d494) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24ofono: remove duplicated udev setting from FILES_${PN}Robert Yang
It doesn't have files in udev dir, and bitbake.conf already sets it. (From OE-Core rev: 10dbf13c86ce7f10ff84547fee8c4c5f15fe91fb) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24libinput: fix udevdirRobert Yang
* Use "pkg-config --variable=udevdir udev" to fix udevdir, otherwise it would use ${libdir}/udev which is incorrect for systemd's udev. (From OE-Core rev: bcd93a4ad1188bb15db00727d5d03548d687a7a3) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24systemd: install udev.pcRobert Yang
It provides udev, but doesn't install udev.pc, which causes other recipes failed to figure out udevdir. Fixed when systemd in DISTRO_FEATURES: $ bitbake pcmciautils (or btrfs-tools): Package udev was not found in the pkg-config search path. Perhaps you should add the directory containing `udev.pc' to the PKG_CONFIG_PATH environment variable No package 'udev' found Their udev rules file may not be installed according to each pkg's implementation. (From OE-Core rev: a32dac24808bf8621fdbbecb654eff784acee47e) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-24bitbake.conf: add eudev's udevdir to FILES_${PN}Robert Yang
* The eudev's udevdir can be ${base_libdir}/udev or ${libdir}/udev, it doesn't have to be hardcoded to /lib/udev, so add them FILES_${PN}. * Use /lib/udev rather than /lib/udev/rules.d for FILES_${PN} since there might be files in /lib/udev except subdir rules.d (From OE-Core rev: e1b81a80760fc79612254804e429cab5228b1ab6) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23buildtools/uninative-tarball: Fix deployment overlap issuesRichard Purdie
We still have problems where deploying SDKMACHINE=i686 can cause removal of SDKMACHINE=x86_64 artefacts. The reason is that x86_64 is a BUILD_ARCH as well as an SDK_ARCH and the manifest namespaces overlap. To fix this, set PACKAGE_ARCH and the stamp-extra-into to include SDK_OS. SDK_OS may not be entirely correct but it is what sstate.bbclass uses for nativesdk and fixing that is a separate issue. This is confirmed to resolve artefact problems on the AB which have been delaying a new uninative release. (From OE-Core rev: 1dbc6ec4ca061570d2482c9abebcf720298db9b7) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23toolchain-shar-relocate.sh: Fix typoRichard Purdie
(From OE-Core rev: 8d6ee36493800a30e9bd6eacb671fbafe5d61ad7) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23sdk-manual: Removed two Git tag developer notes.Scott Rifenbark
These notes can't be in the final version of the manual. Now is the time to get them out. (From yocto-docs rev: 600b4f2c7360b30d12fdc7ed0f5ba41bc09fc778) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23sdk-manual: Removed notes about the BitBake CommanderScott Rifenbark
Fixes [YOCTO #10032] The fix to remove the BitBake Commander from the tools to install when dealing with the Eclipse Yocto Plug-in has happened. Consequently, I removed the developer notes in the manual stating that the Commander was still showing up there. The manual set is now clean of this stuff. (From yocto-docs rev: fbe169b086faac571de8a2ebd9d32682162cfd31) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23sdk-manual: Updated Passing host options exampleScott Rifenbark
Fixes [YOCTO #10267] The example works better using OECORE_TARGET_SYSROOT for the aclocal line. I changed it to that. (From yocto-docs rev: 362b786e7bf2083c5809e961f61c0ad81b778d71) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23ref-manual: Updates to PKGDESTWORK and do_packagedataScott Rifenbark
Fixes [YOCTO #10248] Provided more accurate descriptions for this variable and task. (From yocto-docs rev: 422fa705165748230470fffc4fcc543ee38b1f2e) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23dev-manual: Updated add and modify flows and text.Scott Rifenbark
Updated the devtool add and devtool modify flow diagrams and supporting text to exactly match those from the SDK manual. Also, updated the help output generated from the devtool --help and devtool add --help commands. (From yocto-docs rev: 002297a8ed3979f012fe228b7edb77514e7528a2) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23sdk-manual: Updates to the devtool Finish command flow.Scott Rifenbark
(From yocto-docs rev: f980b7cfa021c3777acd8e26b00cf40ed58f10f4) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23ref-manual: Applied review edits to auto added runtime depsScott Rifenbark
Fixes [YOCTO #10248] Applied some review changes. Minor wording tweaks and typo fixes. (From yocto-docs rev: a9e99c8b44c48c74448487187cebfe8df331e9e1) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23sdk-manual: Updated SDK workflowScott Rifenbark
A new command devtool finish has superceded the final commands in the SDK workflow. I updated the two figures (add and modify) to reflect this new flow. I also updated the ordered number list to match reality. (From yocto-docs rev: 0ba31e730cd748d06eab8d46b38764cda5c4e3bd) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23sdk-manual, ref-manual: New variable for including toolchainScott Rifenbark
Added a new variable description for SDK_INCLUDE_TOOLCHAIN. Along with the new glossary entry, I updated a couple places where it would be relevant to cross-reference the new variable. (From yocto-docs rev: df99b097595e7488a93354082b8d9f33acd9c229) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23ref-manual: Added note to PREFERRED_VERSIONScott Rifenbark
fixes [YOCTO #10252] Added a note to help avoid confusion regarding the version specification used in PREFERRED_VERSION. (From yocto-docs rev: 38edc25b04c1a6d673ceb25f5548898d5b63b120) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-09-23ref-manual: New section and updates for runtime dep workScott Rifenbark
fixes [YOCTO #10248] The bulk of this change is a new section called "Automatically Added Runtime Dependencies". Additionally, changes were made to the RDEPENDS and DEPENDS variables. Some cross-referencing to the new material was also added in the do_package task entry, the do_packagedata task entry, the PKGDATA_DIR glossary entry, and the PRIVATE_LIBS glossary entry. (From yocto-docs rev: 16504cd0eb23e102322c6c6096c5b52500a04640) Signed-off-by: Scott Rifenbark <srifenbark@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>