summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtl8187se
AgeCommit message (Collapse)Author
2015-06-06staging: rtl8712, rtl8712: avoid lots of build warningsArnd Bergmann
commit 0c9f3a65c5eb7fe1fc611a22eb8a8b71ea865998 upstream. The rtl8712 driver has an 'extern inline' function that contains an 'if', which causes lots of warnings with CONFIG_PROFILE_ALL_BRANCHES overriding the definition of 'if': drivers/staging/rtl8712/ieee80211.h:759:229: warning: '______f' is static but declared in inline function 'ieee80211_get_hdrlen' which is not static [enabled by default] This changes the driver to use 'static inline' instead, which happens to be the correct annotation anyway. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Larry Finger <Larry.Finger@lwfinger.net> Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-11Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as staticAnmol Sarma
Fix sparse warnings for undeclared symbols not marked static like: 148:6: warning: symbol 'enqueue_mgmt' was not declared. Should it be static? 166:16: warning: symbol 'dequeue_mgmt' was not declared. Should it be static? Signed-off-by: Anmol Sarma <me@anmolsarma.in> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-11Staging: rtl8187se: r8180_wx.c: make 'rtl8180_rates' staticAnmol Sarma
Fixes the following sparse warning: 27:5: warning: symbol 'rtl8180_rates' was not declared. Should it be static? Signed-off-by: Anmol Sarma <me@anmolsarma.in> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-11Staging: rtl8187se: r8180_core.c: mark symbols as staticAnmol Sarma
Fix sparse warnings for undeclared symbols not marked static like: 390:6: warning: symbol 'buffer_free' was not declared. Should it be static? 1031:5: warning: symbol 'ComputeTxTime' was not declared. Should it be static? Signed-off-by: Anmol Sarma <me@anmolsarma.in> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-09Staging: rtl8187se: fix styling issues in r8180_wx.cDan LaManna
This is a patch to the r8180_wx.c which fixes various whitespace issues, brace issues, casting/declaration syntax issues, and increases clarity in multi-line return statement. Signed-off-by: Dan LaManna <dan.lamanna@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-09staging: rtl8187se: Fix trailing whitespace in r8180_hw.h and r8180_wx.cMasanari Iida
This patch fixed "ERROR: trailing whitespace found by checkpatch.pl in r8180_hw.h and r8180_wx.c Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-09staging: rtl8187se: Fix space prohibited before semicolon in r8180_core.c ↵Masanari Iida
and r8180.h This patch fixed "Warning: space prohibited before semicolon" found by checkpatch.pl in r8180_core.c and r8180.h Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-12-17staging: delete non-required instances of include <linux/init.h>Paul Gortmaker
None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-19staging: rtl8187se: fix coding style in function declarationsAna Rey
Removed innecessary spaces and indentation errors in function definition (including some curly braces wrongly placed and broke up at 80-chars per line). I still see some errors if I run the checkpatch.pl script, but those are not my fault. I'll address them in follow up patches. Signed-off-by: Ana Rey <anarey@gmail.com> Acked-by: Pablo Neira Ayuso <pablo@gnumonks.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-11Staging: rtl8187se: Fix Sparse WarningsEbru Akagunduz
This patch fixes the Sparse Warnings "symbol was not declared. Should it be static?" so it removes some extern expressions to r8180.h and it defines some extern expressions in ieee80211.h Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: fix printk() should include kern_ facility levelEbru Akagunduz
Fix checkpatch.pl issues with printk() should include kern_ facility level in r8185b_init.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Remove C99 style commentingHimangi Saraogi
This patch fixes the checkpatch.pl warning "do not use C99 // comments" in ieee80211/ieee80211_softmac.c. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Fix indentation errorsHimangi Saraogi
This patch fixes the checkpatch.pl warnings "code indent should use tabs where possible" in ieee80211/ieee80211_softmac.c. Also unnecessary blanks lines are removed. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging:rtl8187se: Remove unnecessary braces from if-else statementHimangi Saraogi
This patch fixes the checkpatch.pl warning braces {} are not necessary for any arm of this statement in ieee80211/ieee80211_softmac.c. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging:rtl8187se: Add space before open parenthesis of if conditionHimangi Saraogi
This patch fixes the checkpatch.pl warning : space required before the open parenthesis '(' in ieee80211/ieee80211_softmac.c. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: use macro IW_HANDLER to initialize r8180_wx_handlersAna Rey Botello
Use IW_HANDLER to initialize iw_handler structure like in others wireless driver. Acked-by: Pablo Neira Ayuso <pablo@gnumonks.org> Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging:rtl8187se: Insert spaces after commasHimangi Saraogi
This patch fixes the checkpatch.pl warnings space required after that ',' in ieee80211/ieee80211_softmac.c Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging:rtl8187se: Use preferred library linux/uaccess.h over asm/uaccess.hHimangi Saraogi
This patch fixes the checkpatch.pl warning "Use #include <linux/uaccess.h> instead of <asm/uaccess.h>" in ieee80211/ieee80211_softmac.c . Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging:rtl8187se: Shift open brace of function declarations to next lineHimangi Saraogi
This patch fixes the checkpatch.pl error "open brace '{' following function declarations go on the next line" in ieee80211_softmac.c. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Fix C99 style commenting in dot11d.hHimangi Saraogi
This patch fixes the checkpatch.pl error "do not use C99 // comments" in ieee80211/dot11d.n. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Remove useless comments in dot11d.cRashika Kheria
This patch removes unnecessary comments in ieee80211/dot11d.c. Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Remove unnecessary return statement in ↵Rashika Kheria
ieee80211_crypt_tkip.c This patch removes an unnecessary return statement in the function ieee80211_tkip_null() in ieee80211/ieee80211_crypt_tkip.c. Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Fix code indent should use tabs in ieee80211_crypt_tkip.cRashika Kheria
This patch fixes the following checkpatch.pl issues in ieee80211/ieee80211_crypt_tkip.c- ERROR: code indent should use tabs where possible Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Replace "foo * bar" with "foo *bar" in ↵Rashika Kheria
ieee80211_crypt_tkip.c This patch fixes the following checkpatch.pl issues in ieee80211/ieee80211_crypt_tkip.c- ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Remove useless comments in ieee80211_crypt_tkip.cRashika Kheria
This patch removes useless comments in ieee80211/ieee80211_crypt_tkip.c. And, hence also removes the following checkpatch.pl issue- ERROR: do not use C99 // comments Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Fix quoted strings split across lines in ↵Rashika Kheria
ieee80211_crypt_ccmp.c This patch fixes the following checkpatch.pl issues in ieee80211/ieee80211_crypt_ccmp.c- WARNING: quoted string split across lines Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Remove unnecessary comments in ieee80211_crypt_ccmp.cRashika Kheria
This patch removes unnecessary comments written in ieee80211/ieee80211_crypt_ccmp.c. And hence also, removes the following checkpatch.pl issue- ERROR: do not use C99 // comments Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Fix line over 80 characters in dot11d.cRashika Kheria
This patch fixes the following checkpatch.pl issues in ieee80211/dot11d.c- WARNING: line over 80 characters Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Remove unnecessary braces around single statement in ↵Rashika Kheria
dot11d.c This patch fixes the following checkpatch.pl issues in ieee80211/dot11d.c- WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Fix space prohibited before semicolon in dot11d.cRashika Kheria
This patch fixes the following checkpatch.pl issues in ieee80211/dot11d.c- WARNING: space prohibited before semicolon Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Fix printk() should include KERN_ facility levelRashika Kheria
This patch fixes the following checkpatch.pl issues in ieee80211/dot11d.c- WARNING: printk() should include KERN_ facility level Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10Staging: rtl8187se: Fix C99 style commenting in dot11d.cRashika Kheria
This patch fixes the following checkpatch.pl issues in ieee80211/dot11d.c- ERROR: do not use C99 // comments Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10drivers : staging :rtl8187se : r8180_core.c : remove space before semicolonHimangi Saraogi
This patch removes the checkpatch.pl warning space prohibited before semicolon. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-30Staging: rtl8187se: space prohibited before semicolon in r8185b_init.cEbru Akagunduz
Fix checkpatch.pl issues with space prohibited before semicolon in r8185b_init.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-30Staging: rtl8187se: fix space prohibited after that open parenthesis '(' in ↵Ebru Akagunduz
r8185b_init.c Fix checkpatch.pl issues with space prohibited after that open parenthesis '(' in r8185b_init.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-30Staging: rtl8187se: fix braces {} are not necessary for single statement ↵Ebru Akagunduz
blocks in r8185b_init.c Fix checkpatch.pl issues with braces {} are not necessary for single statement blocks in r8185b_init.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-30Staging: rtl8187se: fix trailing whitespace in r8185b_init.cEbru Akagunduz
Fix checkpatch.pl issues with trailing whitespace in r8185b_init.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-30Staging: rtl8187se: fix please, no space before tabs in r8185b_init.cEbru Akagunduz
Fix checkpatch.pl issues with please, no space before tabs in r8185b_init.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: delete duplicated argument to |Teodora Baluta
This patch fixes the following coccinelle issue for a mask calculation: drivers/staging/rtl8187se/r8180_core.c:2552:44-54: duplicated argument to & or | Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: fix code allignmentTeodora Baluta
Fix confusingly indented code after if. This patch fixes the following coccinelle issues: drivers/staging/rtl8187se/r8180_wx.c:1148:2-11: code aligned with following code on line 1150 drivers/staging/rtl8187se/r8180_dm.c:668:1-84: code aligned with following code on line 674 drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:623:2-38: code aligned with following code on line 625 drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:148:1-85: code aligned with following code on line 149 Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: bool tests don't need comparisonsTeodora Baluta
This patch fixes the following coccinelle warning: drivers/staging/rtl8187se/r8180_core.c:2217:5-40: WARNING: Comparison to bool Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: fix assignment of bool to 0/1Teodora Baluta
This patch fixes the following coccinelle warnings: drivers/staging/rtl8187se/r8180_core.c:2433:1-20: WARNING: Assignment of bool to 0/1 drivers/staging/rtl8187se/r8180_core.c:2275:3-34: WARNING: Assignment of bool to 0/1 Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: use memdup_user to simplify codeTeodora Baluta
This patch fixes the following coccinelle warning to use memdup_user rather than duplicating its implementation: drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:2947:9-16: WARNING opportunity for memdup_user Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28Staging: rtl8187se: fix line over 80 characters in r8185b_init.cEbru Akagunduz
Fix checkpatch.pl issues with line over 80 characters in r8185b_init.c, Italian to English translated added Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: use netdev_warn instead of printkTeodora Baluta
This patch fixes this type of checkpatch warnings: WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: use netdev_info instead of printkTeodora Baluta
WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: prefer netdev_dbg to printkTeodora Baluta
This patch fixes the following checkpatch warning: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: fix lines over 80 charactersTeodora Baluta
This patch fixes lines that are well over 80 characters long and silences the checkpatch warning. Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: fixup multi-line commentTeodora Baluta
This patch ensures that all multi-line comments are consistent with the Linux kernel coding style for long (multi-line) comments. Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rtl8187se: remove an unnecessary line continuationTeodora Baluta
This patch fixed the following checkpatch warning: WARNING: Avoid unnecessary line continuations Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit 1.2.3-korg (git 2.39.0) at 2024-07-01 22:50:21 +0000