summaryrefslogtreecommitdiffstats
path: root/drivers/atm
AgeCommit message (Collapse)Author
2009-07-27drivers/atm: Correct redundant testJulia Lawall
str has already been tested. It seems that this test should be on the recently returned value snr. A simplified version of the semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; expression E; @@ if (x == NULL || ...) { ... when forall return ...; } ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) ( *x == NULL | *x != NULL ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-05-07solos: Show Interleaving details for ADSL2 and 2+Simon Farnsworth
InterleaveRDn and InterleaveRUp only apply to G.dmt. The equivalents for ADSL2 and 2+ are BisRDn and BisRUp. In addition, the INPdown and INPup statuses are useful when trying to track down instability on a line. Signed-off-by: Simon Farnsworth <simon@farnz.org.uk> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-04-30solos: Add some margin-related parametersDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-04-13Replace all DMA_nBIT_MASK macro with DMA_BIT_MASK(n)Yang Hongyang
This is the second go through of the old DMA_nBIT_MASK macro,and there're not so many of them left,so I put them into one patch.I hope this is the last round. After this the definition of the old DMA_nBIT_MASK macro could be removed. Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> Cc: Russell King <rmk@arm.linux.org.uk> Cc: Tony Lindgren <tony@atomide.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: Greg KH <greg@kroah.com> Cc: Takashi Iwai <tiwai@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-04-07dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)Yang Hongyang
Replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32) Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-03-25solos: Check for rogue received packetsNathan Williams
Sometimes there can be received packets with the size field set to 0xFFFF. This seems to only occur after an FPGA or firmware upgrade. This patch discards packets with an invalid size. Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-03-25solos: support new FPGA RAM layoutNathan Williams
Buffer sizes have been changed to 2048 bytes. Flash upgrades use a dedicated RAM block. Add support for daughterboard. Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-03-21atm: fix non-const printk argumentStephen Hemminger
Change printk() argument to fix compiler warning. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-03-21Merge branch 'master' of git://git.infradead.org/~dwmw2/solos-2.6David S. Miller
2009-03-17solos: Disable DMA until we have an FPGA update with it actually implemented.David Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-03-17solos: Automatically determine number of portsNathan Williams
Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-03-17solos: Reset device on unload, free pending skbsDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-02-24Merge branch 'master' of /home/davem/src/GIT/linux-2.6/David S. Miller
2009-02-18atm: Add missing parenthesesRoel Kluin
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-02-18ATM: misplaced parentheses?Roel Kluin
Add missing parentheses Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-02-10fore200: fix oops on failed firmware loadMeelis Roos
Fore 200 ATM driver fails to handle request_firmware failures and oopses when no firmware file was found. Fix it by checking for the right return values and propaganting the return value up. Signed-off-by: Meelis Roos <mroos@linux.ee> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-02-08drivers/atm: introduce missing kfreeJulia Lawall
Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,l; position p1,p2; expression *ptr != NULL; @@ ( if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S | x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S ) <... when != x when != if (...) { <+...x...+> } x->f = E ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-01-30solos: Swap upstream/downstream rates in status packet, clean up some moreDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-30solos: Set RX empty flag at startup only for !dma modeDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-30solos: Don't clear config registers at startupDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-30solos: Tidy up status interrupt handling, cope with 'ERROR' statusDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-30solos: Add 'reset' module parameter to reset the DSL chips on loadDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Remove debugging, commented-out test codeDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Clean up handling of card->tx_mask a littleDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Fix various bugs in status packet handlingDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Remove superfluous wait_queue_head_t from struct solos_paramDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Remove IRQF_DISABLED, don't frob IRQ enable on the FPGA in solos_irq()David Woodhouse
Neither of these are necessary. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Remove unused loopback debug stuffDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Tidy up tx_mask handling for ports which need TXDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Tidy up DMA handling a little. Still untestedDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-28solos: First attempt at DMA supportDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-28solos: Remove parameter group from sysfs on ATM dev deregisterDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-28solos: Fix under-allocation of skb size for get/set parametersDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-28solos: Add SNR and Attn to status packet, fix oops on loadDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Reject non-AAL5 connections.... for nowDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Kill existing connections on link down eventDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Handle new line status change packets, hook up to ATM layer infoDavid Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Add initial list of parametersDavid Woodhouse
I don't much like the trick with multiple inclusions of solos-attrlist.c but don't really see a saner way to do it without repeating the list. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Handle attribute show/store in kernel more sanelyDavid Woodhouse
There are still a _lot_ of attributes, but for at least the basic ones we want to be able to get/set them from the kernel. Especially the ones we want to inform the ATM core about (link state, speed). Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Kill global 'opens' count.David Woodhouse
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Clean up firmware loading codeDavid Woodhouse
We no longer try to load firmware while the ATM is up and running. However, this means that we _do_ make init_module() wait for it, and it takes a long time for now (since we're using ultra-conservative code in the FPGA for that too). The inner loop which uses swahb32p() was by Simon Farnsworth. Simon has patches which migrate us to request_firmware_nowait(), for which we'll actually need to take down the ATM devices, do the upgrade, then reregister them. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: FPGA and firmware update support.Simon Farnsworth
This is just a straight pull in of changes, syncing us up to 0.07 from openadsl.sf.net Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: Simon Farnsworth <simon@farnz.org.uk> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Slight debugging improvementsSimon Farnsworth
Print a message if pskb_expand_head fails. Make atmdebug writable by root, so that you can turn printing of data sent to and received from the card on and off at runtime - useful for tracking corruption. Signed-off-by: Simon Farnsworth <simon@farnz.org.uk> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Fix length header in FPGA transfersDavid Woodhouse
The length field shouldn't ever include the size of the header itself. This fixes the problem that some people were seeing with 1500-byte packets. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-08generic swap(): iphase: rename swap() to swap_byte_order()Wu Fengguang
In preparation for the introduction of a generic swap() macro. Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> Acked-by: David S. Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-12-26atm: Driver for Solos PCI ADSL2+ card.David Woodhouse
This adds basic support for the 'Solos' PCI ADSL2+ cards being developed by Traverse Technologies and Xrio Ltd: http://www.traverse.com.au/productview.php?product_id=116 Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2008-11-29ATM: horizon, fix hrz_probe fail pathJiri Slaby
One fail path in hrz_probe omitted device disable. Fix it. Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2008-10-11Merge branch 'master' of ↵David S. Miller
master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6 Conflicts: sound/core/memalloc.c
2008-09-22drivers/atm: Use DIV_ROUND_UPJulia Lawall
The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) / (d)) but is perhaps more readable. In the case of the file drivers/atm/eni.c, I am a little bit suspicious of the -1 at the end of the affected expression. Please check that that is what is wanted. An extract of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @haskernel@ @@ #include <linux/kernel.h> @depends on haskernel@ expression n,d; @@ ( - (n + d - 1) / d + DIV_ROUND_UP(n,d) | - (n + (d - 1)) / d + DIV_ROUND_UP(n,d) ) @depends on haskernel@ expression n,d; @@ - DIV_ROUND_UP((n),d) + DIV_ROUND_UP(n,d) @depends on haskernel@ expression n,d; @@ - DIV_ROUND_UP(n,(d)) + DIV_ROUND_UP(n,d) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
2008-09-21atm: idt77252: Use generic SKB queue management instead of home-grown scheme.David S. Miller
Signed-off-by: David S. Miller <davem@davemloft.net>