diff options
Diffstat (limited to 'meta-amd-bsp/recipes-kernel/linux-4.19/linux-yocto-4.19.8/1185-drm-amd-display-Use-memset-to-initialize-variable-in.patch')
-rw-r--r-- | meta-amd-bsp/recipes-kernel/linux-4.19/linux-yocto-4.19.8/1185-drm-amd-display-Use-memset-to-initialize-variable-in.patch | 49 |
1 files changed, 49 insertions, 0 deletions
diff --git a/meta-amd-bsp/recipes-kernel/linux-4.19/linux-yocto-4.19.8/1185-drm-amd-display-Use-memset-to-initialize-variable-in.patch b/meta-amd-bsp/recipes-kernel/linux-4.19/linux-yocto-4.19.8/1185-drm-amd-display-Use-memset-to-initialize-variable-in.patch new file mode 100644 index 00000000..380b7844 --- /dev/null +++ b/meta-amd-bsp/recipes-kernel/linux-4.19/linux-yocto-4.19.8/1185-drm-amd-display-Use-memset-to-initialize-variable-in.patch @@ -0,0 +1,49 @@ +From 9a2a8f1c132f58998aab206a92b4fdfdfdfabc87 Mon Sep 17 00:00:00 2001 +From: Nathan Chancellor <natechancellor@gmail.com> +Date: Fri, 1 Feb 2019 13:15:41 -0700 +Subject: [PATCH 1185/2940] drm/amd/display: Use memset to initialize variable + in wait_for_training_aux_rd_interval + +Clang warns: + +drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:50:57: +warning: suggest braces around initialization of subobject +[-Wmissing-braces] + union training_aux_rd_interval training_rd_interval = {0}; + ^ + {} +1 warning generated. + +Previous efforts to fix this type of warning by adding or removing +braces have been met with some pushback in favor of using memset [1][2]. +Do that here, mirroring commit 05794eff1aa6 ("drm/amdgpu/gmc: fix +compiler errors [-Werror,-Wmissing-braces] (V2)") in this tree. + +[1]: https://lore.kernel.org/lkml/022e41c0-8465-dc7a-a45c-64187ecd9684@amd.com/ +[2]: https://lore.kernel.org/lkml/20181128.215241.702406654469517539.davem@davemloft.net/ + +Fixes: 3cec41769d21 ("drm/amd/display: Fix use of uninitialized union") +Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> +Signed-off-by: Alex Deucher <alexander.deucher@amd.com> +--- + drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +index 92f565ca1260..5ee36d6e0512 100644 +--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c ++++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +@@ -47,7 +47,9 @@ static void wait_for_training_aux_rd_interval( + struct dc_link *link, + uint32_t default_wait_in_micro_secs) + { +- union training_aux_rd_interval training_rd_interval = {0}; ++ union training_aux_rd_interval training_rd_interval; ++ ++ memset(&training_rd_interval, 0, sizeof(training_rd_interval)); + + /* overwrite the delay if rev > 1.1*/ + if (link->dpcd_caps.dpcd_rev.raw >= DPCD_REV_12) { +-- +2.17.1 + |