1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
|
# This file is part of Buildbot. Buildbot is free software: you can
# redistribute it and/or modify it under the terms of the GNU General Public
# License as published by the Free Software Foundation, version 2.
#
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
# details.
#
# You should have received a copy of the GNU General Public License along with
# this program; if not, write to the Free Software Foundation, Inc., 51
# Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
# Copyright Buildbot Team Members
from twisted.trial import unittest
from buildbot.test.fake import fakedb, fakemaster
from buildbot.process import buildrequest
class FakeSource:
def __init__(self, mergeable = True):
self.codebase = ''
self.mergeable = mergeable
self.changes = []
def canBeMergedWith(self, other):
return self.mergeable
class TestBuildRequest(unittest.TestCase):
def test_fromBrdict(self):
master = fakemaster.make_master()
master.db = fakedb.FakeDBConnector(self)
master.db.insertTestData([
fakedb.Change(changeid=13, branch='trunk', revision='9283',
repository='svn://...', project='world-domination'),
fakedb.SourceStampSet(id=234),
fakedb.SourceStamp(id=234, sourcestampsetid=234, branch='trunk',
revision='9284', repository='svn://...',
project='world-domination'),
fakedb.SourceStampChange(sourcestampid=234, changeid=13),
fakedb.Buildset(id=539, reason='triggered', sourcestampsetid=234),
fakedb.BuildsetProperty(buildsetid=539, property_name='x',
property_value='[1, "X"]'),
fakedb.BuildsetProperty(buildsetid=539, property_name='y',
property_value='[2, "Y"]'),
fakedb.BuildRequest(id=288, buildsetid=539, buildername='bldr',
priority=13, submitted_at=1200000000),
])
# use getBuildRequest to minimize the risk from changes to the format
# of the brdict
d = master.db.buildrequests.getBuildRequest(288)
d.addCallback(lambda brdict :
buildrequest.BuildRequest.fromBrdict(master, brdict))
def check(br):
# check enough of the source stamp to verify it found the changes
self.assertEqual(br.source.ssid, 234)
self.assertEqual([ ch.number for ch in br.source.changes], [13])
self.assertEqual(br.reason, 'triggered')
self.assertEqual(br.properties.getProperty('x'), 1)
self.assertEqual(br.properties.getProperty('y'), 2)
self.assertEqual(br.submittedAt, 1200000000)
self.assertEqual(br.buildername, 'bldr')
self.assertEqual(br.priority, 13)
self.assertEqual(br.id, 288)
self.assertEqual(br.bsid, 539)
d.addCallback(check)
return d
def test_fromBrdict_submittedAt_NULL(self):
master = fakemaster.make_master()
master.db = fakedb.FakeDBConnector(self)
master.db.insertTestData([
fakedb.SourceStampSet(id=234),
fakedb.SourceStamp(id=234, sourcestampsetid=234, branch='trunk',
revision='9284', repository='svn://...',
project='world-domination'),
fakedb.Buildset(id=539, reason='triggered', sourcestampsetid=234),
fakedb.BuildRequest(id=288, buildsetid=539, buildername='bldr',
priority=13, submitted_at=None),
])
# use getBuildRequest to minimize the risk from changes to the format
# of the brdict
d = master.db.buildrequests.getBuildRequest(288)
d.addCallback(lambda brdict :
buildrequest.BuildRequest.fromBrdict(master, brdict))
def check(br):
# remaining fields assumed to be checked in test_fromBrdict
self.assertEqual(br.submittedAt, None)
d.addCallback(check)
return d
def test_fromBrdict_no_sourcestamps(self):
master = fakemaster.make_master()
master.db = fakedb.FakeDBConnector(self)
master.db.insertTestData([
fakedb.SourceStampSet(id=234),
# Sourcestampset has no sourcestamps
fakedb.Buildset(id=539, reason='triggered', sourcestampsetid=234),
fakedb.BuildRequest(id=288, buildsetid=539, buildername='not important',
priority=0, submitted_at=None),
])
# use getBuildRequest to minimize the risk from changes to the format
# of the brdict
d = master.db.buildrequests.getBuildRequest(288)
d.addCallback(lambda brdict:
buildrequest.BuildRequest.fromBrdict(master, brdict))
return self.assertFailure(d, AssertionError)
def test_fromBrdict_multiple_sourcestamps(self):
master = fakemaster.make_master()
master.db = fakedb.FakeDBConnector(self)
master.db.insertTestData([
fakedb.SourceStampSet(id=234),
fakedb.Change(changeid=13, branch='trunk', revision='9283',
repository='svn://a..', codebase='A',
project='world-domination'),
fakedb.SourceStamp(id=234, sourcestampsetid=234, branch='trunk',
revision='9283', repository='svn://a..',
codebase='A', project='world-domination'),
fakedb.SourceStampChange(sourcestampid=234, changeid=13),
fakedb.Change(changeid=14, branch='trunk', revision='9284',
repository='svn://b..', codebase='B',
project='world-domination'),
fakedb.SourceStamp(id=235, sourcestampsetid=234, branch='trunk',
revision='9284', repository='svn://b..',
codebase='B', project='world-domination'),
fakedb.SourceStampChange(sourcestampid=235, changeid=14),
fakedb.Buildset(id=539, reason='triggered', sourcestampsetid=234),
fakedb.BuildsetProperty(buildsetid=539, property_name='x',
property_value='[1, "X"]'),
fakedb.BuildsetProperty(buildsetid=539, property_name='y',
property_value='[2, "Y"]'),
fakedb.BuildRequest(id=288, buildsetid=539, buildername='bldr',
priority=13, submitted_at=1200000000),
])
# use getBuildRequest to minimize the risk from changes to the format
# of the brdict
d = master.db.buildrequests.getBuildRequest(288)
d.addCallback(lambda brdict :
buildrequest.BuildRequest.fromBrdict(master, brdict))
def check(br):
# check enough of the source stamp to verify it found the changes
# Test the single-sourcestamp interface
self.assertEqual(br.source.ssid, 234)
# Test the multiple sourcestamp interface
self.assertEqual(br.sources['A'].ssid, 234)
self.assertEqual(br.sources['B'].ssid, 235)
self.assertEqual([ ch.number for ch in br.sources['A'].changes], [13])
self.assertEqual([ ch.number for ch in br.sources['B'].changes], [14])
self.assertEqual(br.reason, 'triggered')
self.assertEqual(br.properties.getProperty('x'), 1)
self.assertEqual(br.properties.getProperty('y'), 2)
self.assertEqual(br.submittedAt, 1200000000)
self.assertEqual(br.buildername, 'bldr')
self.assertEqual(br.priority, 13)
self.assertEqual(br.id, 288)
self.assertEqual(br.bsid, 539)
d.addCallback(check)
return d
def test_mergeSourceStampsWith_common_codebases(self):
""" This testcase has two buildrequests
Request Change Codebase Revision Comment
----------------------------------------------------------------------
288 13 A 9283
289 15 A 9284
288 14 B 9200
289 16 B 9201
--------------------------------
After merged in Build:
Source1 has rev 9284 and contains changes 13 and 15 from repository svn://a
Source2 has rev 9201 and contains changes 14 and 16 from repository svn://b
"""
brs=[] # list of buildrequests
master = fakemaster.make_master()
master.db = fakedb.FakeDBConnector(self)
master.db.insertTestData([
fakedb.SourceStampSet(id=2340),
fakedb.Change(changeid=13, branch='trunk', revision='9283',
repository='svn://a..', codebase='A',
project='world-domination'),
fakedb.SourceStamp(id=234, sourcestampsetid=2340, branch='trunk',
revision='9283', repository='svn://a..', codebase='A',
project='world-domination'),
fakedb.SourceStampChange(sourcestampid=234, changeid=13),
fakedb.Change(changeid=14, branch='trunk', revision='9200',
repository='svn://b..', codebase='A',
project='world-domination'),
fakedb.SourceStamp(id=235, sourcestampsetid=2340, branch='trunk',
revision='9200', repository='svn://b..', codebase='B',
project='world-domination'),
fakedb.SourceStampChange(sourcestampid=235, changeid=14),
fakedb.SourceStampSet(id=2360),
fakedb.Change(changeid=15, branch='trunk', revision='9284',
repository='svn://a..', codebase='A',
project='world-domination'),
fakedb.SourceStamp(id=236, sourcestampsetid=2360, branch='trunk',
revision='9284', repository='svn://a..', codebase='A',
project='world-domination'),
fakedb.SourceStampChange(sourcestampid=236, changeid=15),
fakedb.Change(changeid=16, branch='trunk', revision='9201',
repository='svn://b..', codebase='B',
project='world-domination'),
fakedb.SourceStamp(id=237, sourcestampsetid=2360, branch='trunk',
revision='9201', repository='svn://b..', codebase='B',
project='world-domination'),
fakedb.SourceStampChange(sourcestampid=237, changeid=16),
fakedb.Buildset(id=539, reason='triggered', sourcestampsetid=2340),
fakedb.BuildRequest(id=288, buildsetid=539, buildername='bldr'),
fakedb.Buildset(id=540, reason='triggered', sourcestampsetid=2360),
fakedb.BuildRequest(id=289, buildsetid=540, buildername='bldr'),
])
# use getBuildRequest to minimize the risk from changes to the format
# of the brdict
d = master.db.buildrequests.getBuildRequest(288)
d.addCallback(lambda brdict :
buildrequest.BuildRequest.fromBrdict(master, brdict))
d.addCallback(lambda br : brs.append(br))
d.addCallback(lambda _ :
master.db.buildrequests.getBuildRequest(289))
d.addCallback(lambda brdict :
buildrequest.BuildRequest.fromBrdict(master, brdict))
d.addCallback(lambda br : brs.append(br))
def check(_):
sources = brs[0].mergeSourceStampsWith(brs[1:])
source1 = source2 = None
for source in sources:
if source.codebase == 'A':
source1 = source
if source.codebase == 'B':
source2 = source
self.assertFalse(source1 == None)
self.assertEqual(source1.revision,'9284')
self.assertFalse(source2 == None)
self.assertEqual(source2.revision,'9201')
self.assertEqual([c.number for c in source1.changes], [13,15])
self.assertEqual([c.number for c in source2.changes], [14,16])
d.addCallback(check)
return d
def test_canBeMergedWith_different_codebases_raises_error(self):
""" This testcase has two buildrequests
Request Change Codebase Revision Comment
----------------------------------------------------------------------
288 17 C 1800 request 1 has repo not in request 2
289 18 D 2100 request 2 has repo not in request 1
--------------------------------
Merge cannot be performd and raises error:
Merging requests requires both requests to have the same codebases
"""
brs=[] # list of buildrequests
master = fakemaster.make_master()
master.db = fakedb.FakeDBConnector(self)
master.db.insertTestData([
fakedb.SourceStampSet(id=2340),
fakedb.Change(changeid=17, branch='trunk', revision='1800',
repository='svn://c..', codebase='C',
project='world-domination'),
fakedb.SourceStamp(id=238, sourcestampsetid=2340, branch='trunk',
revision='1800', repository='svn://c..',
codebase='C', project='world-domination'),
fakedb.SourceStampChange(sourcestampid=238, changeid=17),
fakedb.SourceStampSet(id=2360),
fakedb.Change(changeid=18, branch='trunk', revision='2100',
repository='svn://d..', codebase='D',
project='world-domination'),
fakedb.SourceStamp(id=239, sourcestampsetid=2360, branch='trunk',
revision='2100', repository='svn://d..',
codebase='D', project='world-domination'),
fakedb.SourceStampChange(sourcestampid=239, changeid=18),
fakedb.Buildset(id=539, reason='triggered', sourcestampsetid=2340),
fakedb.BuildRequest(id=288, buildsetid=539, buildername='bldr'),
fakedb.Buildset(id=540, reason='triggered', sourcestampsetid=2360),
fakedb.BuildRequest(id=289, buildsetid=540, buildername='bldr'),
])
# use getBuildRequest to minimize the risk from changes to the format
# of the brdict
d = master.db.buildrequests.getBuildRequest(288)
d.addCallback(lambda brdict :
buildrequest.BuildRequest.fromBrdict(master, brdict))
d.addCallback(lambda br : brs.append(br))
d.addCallback(lambda _ :
master.db.buildrequests.getBuildRequest(289))
d.addCallback(lambda brdict :
buildrequest.BuildRequest.fromBrdict(master, brdict))
d.addCallback(lambda br : brs.append(br))
def check(_):
self.assertEqual(brs[0].canBeMergedWith(brs[1]), False)
d.addCallback(check)
return d
def test_build_can_be_merged_with_mergables_same_codebases(self):
r1 = buildrequest.BuildRequest()
r1.sources = {"A": FakeSource()}
r2 = buildrequest.BuildRequest()
r2.sources = {"A": FakeSource()}
mergeable = r1.canBeMergedWith(r2)
self.assertTrue(mergeable, "Both request should be able to merge")
def test_build_can_be_merged_with_non_mergable_same_codebases(self):
r1 = buildrequest.BuildRequest()
r1.sources = {"A": FakeSource(mergeable = False)}
r2 = buildrequest.BuildRequest()
r2.sources = {"A": FakeSource(mergeable = False)}
mergeable = r1.canBeMergedWith(r2)
self.assertFalse(mergeable, "Both request should not be able to merge")
def test_build_can_be_merged_with_non_mergables_different_codebases(self):
r1 = buildrequest.BuildRequest()
r1.sources = {"A": FakeSource(mergeable = False)}
r2 = buildrequest.BuildRequest()
r2.sources = {"B": FakeSource(mergeable = False)}
mergeable = r1.canBeMergedWith(r2)
self.assertFalse(mergeable, "Request containing different codebases " +
"should never be able to merge")
|
