1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
|
# This file is part of Buildbot. Buildbot is free software: you can
# redistribute it and/or modify it under the terms of the GNU General Public
# License as published by the Free Software Foundation, version 2.
#
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
# details.
#
# You should have received a copy of the GNU General Public License along with
# this program; if not, write to the Free Software Foundation, Inc., 51
# Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
# Copyright Buildbot Team Members
import mock
import random
from twisted.trial import unittest
from twisted.internet import defer
from buildbot import config
from buildbot.test.fake import fakedb, fakemaster
from buildbot.process import builder, factory
from buildbot.util import epoch2datetime
class BuilderMixin(object):
def makeBuilder(self, name="bldr", patch_random=False, **config_kwargs):
"""Set up C{self.bldr}"""
self.factory = factory.BuildFactory()
self.master = fakemaster.make_master()
# only include the necessary required config, plus user-requested
config_args = dict(name=name, slavename="slv", builddir="bdir",
slavebuilddir="sbdir", factory=self.factory)
config_args.update(config_kwargs)
self.builder_config = config.BuilderConfig(**config_args)
self.bldr = builder.Builder(self.builder_config.name, _addServices=False)
self.master.db = self.db = fakedb.FakeDBConnector(self)
self.bldr.master = self.master
self.bldr.botmaster = self.master.botmaster
# patch into the _startBuildsFor method
self.builds_started = []
def _startBuildFor(slavebuilder, buildrequests):
self.builds_started.append((slavebuilder, buildrequests))
return defer.succeed(True)
self.bldr._startBuildFor = _startBuildFor
if patch_random:
# patch 'random.choice' to always take the slave that sorts
# last, based on its name
self.patch(random, "choice",
lambda lst : sorted(lst, key=lambda m : m.name)[-1])
self.bldr.startService()
mastercfg = config.MasterConfig()
mastercfg.builders = [ self.builder_config ]
return self.bldr.reconfigService(mastercfg)
class TestBuilderBuildCreation(BuilderMixin, unittest.TestCase):
def setUp(self):
# a collection of rows that would otherwise clutter up every test
self.base_rows = [
fakedb.SourceStampSet(id=21),
fakedb.SourceStamp(id=21, sourcestampsetid=21),
fakedb.Buildset(id=11, reason='because', sourcestampsetid=21),
]
def makeBuilder(self, patch_random=False, startBuildsForSucceeds=True, **config_kwargs):
d = BuilderMixin.makeBuilder(self, patch_random=patch_random, **config_kwargs)
@d.addCallback
def patch_startBuildsFor(_):
# patch into the _startBuildsFor method
self.builds_started = []
def _startBuildFor(slavebuilder, buildrequests):
self.builds_started.append((slavebuilder, buildrequests))
return defer.succeed(startBuildsForSucceeds)
self.bldr._startBuildFor = _startBuildFor
return d
def assertBuildsStarted(self, exp):
# munge builds_started into a list of (slave, [brids])
builds_started = [
(sl.name, [ br.id for br in buildreqs ])
for (sl, buildreqs) in self.builds_started ]
self.assertEqual(sorted(builds_started), sorted(exp))
def setSlaveBuilders(self, slavebuilders):
"""C{slaves} maps name : available"""
self.bldr.slaves = []
for name, avail in slavebuilders.iteritems():
sb = mock.Mock(spec=['isAvailable'], name=name)
sb.name = name
sb.isAvailable.return_value = avail
self.bldr.slaves.append(sb)
# services
@defer.inlineCallbacks
def test_maybeStartBuild_builder_stopped(self):
yield self.makeBuilder()
# this will cause an exception if maybeStartBuild tries to start
self.bldr.slaves = None
# so we just hope this does not fail
yield self.bldr.stopService()
started = yield self.bldr.maybeStartBuild(None, [])
self.assertEquals(started, False)
# maybeStartBuild
def _makeMocks(self):
slave = mock.Mock()
slave.name = 'slave'
buildrequest = mock.Mock()
buildrequest.id = 10
buildrequests = [buildrequest]
return slave, buildrequests
@defer.inlineCallbacks
def test_maybeStartBuild(self):
yield self.makeBuilder()
slave, buildrequests = self._makeMocks()
started = yield self.bldr.maybeStartBuild(slave, buildrequests)
self.assertEqual(started, True)
self.assertBuildsStarted([('slave', [10])])
@defer.inlineCallbacks
def test_maybeStartBuild_failsToStart(self):
yield self.makeBuilder(startBuildsForSucceeds=False)
slave, buildrequests = self._makeMocks()
started = yield self.bldr.maybeStartBuild(slave, buildrequests)
self.assertEqual(started, False)
self.assertBuildsStarted([('slave', [10])])
@defer.inlineCallbacks
def do_test_getMergeRequestsFn(self, builder_param=None,
global_param=None, expected=0):
cble = lambda : None
builder_param = builder_param == 'callable' and cble or builder_param
global_param = global_param == 'callable' and cble or global_param
# omit the constructor parameter if None was given
if builder_param is None:
yield self.makeBuilder()
else:
yield self.makeBuilder(mergeRequests=builder_param)
self.master.config.mergeRequests = global_param
fn = self.bldr.getMergeRequestsFn()
if fn == builder.Builder._defaultMergeRequestFn:
fn = "default"
elif fn is cble:
fn = 'callable'
self.assertEqual(fn, expected)
def test_getMergeRequestsFn_defaults(self):
self.do_test_getMergeRequestsFn(None, None, "default")
def test_getMergeRequestsFn_global_True(self):
self.do_test_getMergeRequestsFn(None, True, "default")
def test_getMergeRequestsFn_global_False(self):
self.do_test_getMergeRequestsFn(None, False, None)
def test_getMergeRequestsFn_global_function(self):
self.do_test_getMergeRequestsFn(None, 'callable', 'callable')
def test_getMergeRequestsFn_builder_True(self):
self.do_test_getMergeRequestsFn(True, False, "default")
def test_getMergeRequestsFn_builder_False(self):
self.do_test_getMergeRequestsFn(False, True, None)
def test_getMergeRequestsFn_builder_function(self):
self.do_test_getMergeRequestsFn('callable', None, 'callable')
# other methods
@defer.inlineCallbacks
def test_reclaimAllBuilds_empty(self):
yield self.makeBuilder()
# just to be sure this doesn't crash
yield self.bldr.reclaimAllBuilds()
@defer.inlineCallbacks
def test_reclaimAllBuilds(self):
yield self.makeBuilder()
claims = []
def fakeClaimBRs(*args):
claims.append(args)
return defer.succeed(None)
self.bldr.master.db.buildrequests.claimBuildRequests = fakeClaimBRs
self.bldr.master.db.buildrequests.reclaimBuildRequests = fakeClaimBRs
def mkbld(brids):
bld = mock.Mock(name='Build')
bld.requests = []
for brid in brids:
br = mock.Mock(name='BuildRequest %d' % brid)
br.id = brid
bld.requests.append(br)
return bld
old = mkbld([15]) # keep a reference to the "old" build
self.bldr.old_building[old] = None
self.bldr.building.append(mkbld([10,11,12]))
yield self.bldr.reclaimAllBuilds()
self.assertEqual(claims, [ (set([10,11,12,15]),) ])
@defer.inlineCallbacks
def test_canStartBuild(self):
yield self.makeBuilder()
# by default, it returns True
startable = yield self.bldr.canStartBuild('slave', 100)
self.assertEqual(startable, True)
startable = yield self.bldr.canStartBuild('slave', 101)
self.assertEqual(startable, True)
# set a configurable one
record = []
def canStartBuild(bldr, slave, breq):
record.append((bldr, slave, breq))
return (slave,breq)==('slave',100)
self.bldr.config.canStartBuild = canStartBuild
startable = yield self.bldr.canStartBuild('slave', 100)
self.assertEqual(startable, True)
self.assertEqual(record, [(self.bldr, 'slave', 100)])
startable = yield self.bldr.canStartBuild('slave', 101)
self.assertEqual(startable, False)
self.assertEqual(record, [(self.bldr, 'slave', 100), (self.bldr, 'slave', 101)])
# set a configurable one to return Deferred
record = []
def canStartBuild_deferred(bldr, slave, breq):
record.append((bldr, slave, breq))
return (slave,breq)==('slave',100)
return defer.succeed((slave,breq)==('slave',100))
self.bldr.config.canStartBuild = canStartBuild_deferred
startable = yield self.bldr.canStartBuild('slave', 100)
self.assertEqual(startable, True)
self.assertEqual(record, [(self.bldr, 'slave', 100)])
startable = yield self.bldr.canStartBuild('slave', 101)
self.assertEqual(startable, False)
self.assertEqual(record, [(self.bldr, 'slave', 100), (self.bldr, 'slave', 101)])
@defer.inlineCallbacks
def test_enforceChosenSlave(self):
"""enforceChosenSlave rejects and accepts builds"""
yield self.makeBuilder()
self.bldr.config.canStartBuild = builder.enforceChosenSlave
slave = mock.Mock()
slave.slave.slavename = 'slave5'
breq = mock.Mock()
# no buildslave requested
breq.properties = {}
result = yield self.bldr.canStartBuild(slave, breq)
self.assertIdentical(True, result)
# buildslave requested as the right one
breq.properties = { 'slavename': 'slave5' }
result = yield self.bldr.canStartBuild(slave, breq)
self.assertIdentical(True, result)
# buildslave requested as the wrong one
breq.properties = { 'slavename': 'slave4' }
result = yield self.bldr.canStartBuild(slave, breq)
self.assertIdentical(False, result)
# buildslave set to non string value gets skipped
breq.properties = { 'slavename': 0 }
result = yield self.bldr.canStartBuild(slave, breq)
self.assertIdentical(True, result)
class TestGetOldestRequestTime(BuilderMixin, unittest.TestCase):
def setUp(self):
# a collection of rows that would otherwise clutter up every test
master_id = fakedb.FakeBuildRequestsComponent.MASTER_ID
self.base_rows = [
fakedb.SourceStampSet(id=21),
fakedb.SourceStamp(id=21, sourcestampsetid=21),
fakedb.Buildset(id=11, reason='because', sourcestampsetid=21),
fakedb.BuildRequest(id=111, submitted_at=1000,
buildername='bldr1', buildsetid=11),
fakedb.BuildRequest(id=222, submitted_at=2000,
buildername='bldr1', buildsetid=11),
fakedb.BuildRequestClaim(brid=222, objectid=master_id,
claimed_at=2001),
fakedb.BuildRequest(id=333, submitted_at=3000,
buildername='bldr1', buildsetid=11),
fakedb.BuildRequest(id=444, submitted_at=2500,
buildername='bldr2', buildsetid=11),
fakedb.BuildRequestClaim(brid=444, objectid=master_id,
claimed_at=2501),
]
def test_gort_unclaimed(self):
d = self.makeBuilder(name='bldr1')
d.addCallback(lambda _ : self.db.insertTestData(self.base_rows))
d.addCallback(lambda _ : self.bldr.getOldestRequestTime())
def check(rqtime):
self.assertEqual(rqtime, epoch2datetime(1000))
d.addCallback(check)
return d
def test_gort_all_claimed(self):
d = self.makeBuilder(name='bldr2')
d.addCallback(lambda _ : self.db.insertTestData(self.base_rows))
d.addCallback(lambda _ : self.bldr.getOldestRequestTime())
def check(rqtime):
self.assertEqual(rqtime, None)
d.addCallback(check)
return d
class TestRebuild(BuilderMixin, unittest.TestCase):
def makeBuilder(self, name, sourcestamps):
d = BuilderMixin.makeBuilder(self, name=name)
@d.addCallback
def setupBstatus(_):
self.bstatus = mock.Mock()
bstatus_properties = mock.Mock()
bstatus_properties.properties = {}
self.bstatus.getProperties.return_value = bstatus_properties
self.bstatus.getSourceStamps.return_value = sourcestamps
self.master.addBuildset = addBuildset = mock.Mock()
addBuildset.return_value = (1, [100])
return d
@defer.inlineCallbacks
def do_test_rebuild(self,
sourcestampsetid,
nr_of_sourcestamps):
# Store combinations of sourcestampId and sourcestampSetId
self.sslist = {}
self.ssseq = 1
def addSourceStampToDatabase(master, sourcestampsetid):
self.sslist[self.ssseq] = sourcestampsetid
self.ssseq += 1
return defer.succeed(sourcestampsetid)
def getSourceStampSetId(master):
return addSourceStampToDatabase(master, sourcestampsetid = sourcestampsetid)
sslist = []
for x in range(nr_of_sourcestamps):
ssx = mock.Mock()
ssx.addSourceStampToDatabase = addSourceStampToDatabase
ssx.getSourceStampSetId = getSourceStampSetId
sslist.append(ssx)
yield self.makeBuilder(name='bldr1', sourcestamps = sslist)
control = mock.Mock(spec=['master'])
control.master = self.master
self.bldrctrl = builder.BuilderControl(self.bldr, control)
yield self.bldrctrl.rebuildBuild(self.bstatus, reason = 'unit test', extraProperties = {})
@defer.inlineCallbacks
def test_rebuild_with_no_sourcestamps(self):
yield self.do_test_rebuild(101, 0)
self.assertEqual(self.sslist, {})
@defer.inlineCallbacks
def test_rebuild_with_single_sourcestamp(self):
yield self.do_test_rebuild(101, 1)
self.assertEqual(self.sslist, {1:101})
self.master.addBuildset.assert_called_with(builderNames=['bldr1'],
sourcestampsetid=101,
reason = 'unit test',
properties = {})
@defer.inlineCallbacks
def test_rebuild_with_multiple_sourcestamp(self):
yield self.do_test_rebuild(101, 3)
self.assertEqual(self.sslist, {1:101, 2:101, 3:101})
self.master.addBuildset.assert_called_with(builderNames=['bldr1'],
sourcestampsetid=101,
reason = 'unit test',
properties = {})
class TestReconfig(BuilderMixin, unittest.TestCase):
"""Tests that a reconfig properly updates all attributes"""
@defer.inlineCallbacks
def test_reconfig(self):
yield self.makeBuilder(description="Old", category="OldCat")
self.builder_config.description = "New"
self.builder_config.category = "NewCat"
mastercfg = config.MasterConfig()
mastercfg.builders = [ self.builder_config ]
yield self.bldr.reconfigService(mastercfg)
self.assertEqual(
dict(description=self.bldr.builder_status.getDescription(),
category=self.bldr.builder_status.getCategory()),
dict(description="New",
category="NewCat"))
|