Age | Commit message (Collapse) | Author |
|
django-debug-toolbar version 1.5 requires django 1.8+, thus
producting an error with current dev-environment configuration.
This fix requires version 1.4 to be used instead.
[ISSUE #198]
Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
|
|
Just like in the series case, we'll use the filtering from the web page
and git-pw.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
To be consistent with what has been done for series, even it's not
entirely pure.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Unfortunately we cannot apply patches from the getpatchwork branch, so I
needed to redo that one.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
|
|
People would like to be able to re-trigger testing through the web
interface. Create a new series-new-revision event should be enough to
trick the testing systems to re-trigger a test run.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
|
|
It can be handy to tag commit messages to get back to the discussion
from the git log. A new 'link' GET parameter make this possible on all
the mbox entry points, for both patches and series.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Suggested-by: Cezar Burlacu <cezar.burlacu@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
The 'django-debug-toolbar' application provides an automatic method of
configuring the plugin. However, as noted in the documentation [1],
this can cause issues like circular imports. In this case, a
"Table 'patchwork.patchwork_state' doesn't exist" exception was being
raised when attempting to do an initial migration.
Resolve this by using the manual configuration provided in the docs.
[1] https://django-debug-toolbar.readthedocs.org/en/1.4/installation.html
v2: Add django-debug-toolbar in the requirements (Damien)
v3: Remove unused import (Damien)
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Closes-bug: #29
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
There's not really any reason to pin the requirements for dependencies
only used in tests, so don't do it. Replace these specific versions
with broader, major-version checks.
v2: Port to fdo's patchwork (Damien)
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
The client is now able to query events by type (ie name).
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Jose Lamego <jose.a.lamego@linux.intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
We're going fancy.
Because sending emails can take some time, especially if we set the
reviewer of 100 series from the web page, the mailing is done in celery
tasks.
I chose redis as the message broker as it can be used for other things
as well, like a memcache-like cache if we ever want to go that route. It
can also be used for communication with a daemon that would support long
lived connections (think web socket or server sent events)
Also, to try and be a bit generic, emails are rendered from templates.
Unit tests cover everything I could think about, including not notifying
users that have set the reviewer to themselves.
Fixes: https://github.com/dlespiau/patchwork/issues/28
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Allows querying series by test states. Sample query:
GET /api/1.0/projects/oe-core/series/?test_state=success
Other test states are explained on the documentation page [1]
[1] http://patchwork-freedesktop.readthedocs.org/en/latest/rest.html
v2: A few tweaks here and there (Damien)
https://github.com/dlespiau/patchwork/pull/154
Signed-off-by: Leo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Remove the likes of 'failUnlessEqual' and 'assertEquals', which have
been deprecated and cause warnings in Django 1.6 with Python 3.4.
https://docs.python.org/2/library/unittest.html#deprecated-aliases
This allows us to remove an item from the TODO list.
v2: Port to fdo's patchwork (Damien)
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
The version of dateutil currently used does not support Python3, so
instead use the latest version.
v2: Tweak for fdo's patchwork requirements.txt files (Damien)
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
It's time to explain the new capabilities of patchwork, namely exposing
the list of new series sent to the mailing-list and the ability to store
test results or link to them.
Fixes: https://github.com/dlespiau/patchwork/issues/64
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
We'd like to filter by reviewer, including series with no reviewer.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
0.12.0 seems to break compatibility with django 1.6/1.7.
Link: https://github.com/alex/django-filter/issues/354
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Quite easy, just need to list the field. Turns out the fields argument
isn't needed for custom filters. Removed updated_since and
submitted_since from the fields array then.
Well, on second thoughts, I need to have special "self" value that
matches all people linked to the current user (there can be many).
For that to work, I also need a specialization of the
DjangoFilterBackend that passes the request along.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Two 'since' query parameters added to the API focused on project's series:
'submitted_since' and 'updated_since'. As in the /events entry implemented
in [1], these parameters allow us to query series since a specific date.
Dates should be given in ISO 8601 format.
v2: Wrap the change to docs/rest.rst to 80 columns (Damien)
mention the API addition in the API change log (Damien)
[1] 36ca1c2e4446709c2c664656bd6c3b63f9937062
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Minor change, adding the revision's part of the entry point.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Fixes: https://github.com/dlespiau/patchwork/issues/116
|
|
It just happened, this branch will stay around for a bit.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Fixes: https://github.com/dlespiau/patchwork/issues/108
|
|
Provide a light introduction to django settings and why this is needed
in the first place.
Reword a few things (like "you may also need to configure you database
configuration").
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
These are found in multiple places across the code. It would be helpful to
document them for the user.
v2: Port to restructured text (Damien)
Don't talk about environmental variables, but environment variables
(Damien)
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Adding the Signed-off-by tag is quite useful in the circles using
patchwork. Might as well put the most useful example possible in the
documentation.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
|
|
When trying to follow the installation steps, directly downloading
git-pw from github, I was missing a chmod +x.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
We'll exclusively use Django 1.7+ migrations, so remove 1.6 from the
documentation.
I didn't actually remove Django 1.6 code nor testing. No reason to break
things too much without good reason. That means code can still be shared
with a version of patchwork caring about 1.6.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Signed-off-by: Gabriel Ciubotaru <gabriel.ciubotaru@intel.com>
|
|
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
Two things were improved:
- We weren't installing any Django version because the requirements
file are used by tox and django must be left unspecified so tox can
cycle through the supported versions.
That's not really developer friendly though, we're creating yet
another to get started with patchwork, with a choice to make. We can
make a good default choice, leaving the developer wanting to
override the Django version if needed. This way, the common case
doesn't have an extra step and the not-so-common case is still the
same number of steps.
- Support both mysql and postgres DB backends
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
v2: Add documentation
Fix case where no parameter is provided
v3: Add a 'params' argument to get() and get_json() (Damien)
v4: Tweak the documentation a bit (Damien)
Signed-off-by: Gabriel Ciubotaru <gabriel.ciubotaru@intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
|
It'd be handy to be able to reinject the content of the DateTimeFields
from the JSON response into the API queries. We'll need that in a
'since' GET parameter for the list of events.
However, datetime objects in python have more precision that the
millisecond currently exposed in the JSON API, becaure rest frameworks
defaults to supporting dates as described in ECMA 262. This mistmach
causes django queries to be wong, because we are dealing with a
truncated time, so operators like gt and gte don't properly
exclude/include the query timesmap.
This also means we'll have to be careful when parsing the date in
javascript later on, not all browser support full ISO 8601 dates (IE,
I'm looking at you). I was already planning to use momentjs, that's
another good reason to do so.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|