path: root/scripts
diff options
authorMartin Jansa <>2020-05-30 00:03:23 +0200
committerRichard Purdie <>2020-06-04 13:27:29 +0100
commiteb4e519f4c2c6d8ee5f635bc477de3c4b5d5c2d6 (patch)
tree0db3e2ca7584812c61379809e9e5910bd6db0510 /scripts
parent2b9e3c2111ae073b93a4092227fd06f2183812fb (diff)
devtool: use -f and don't use --exclude-standard when adding files to workspace
* I see a case where a tarball contains .gitignore and bunch of files which are normally ignored in git, but still included in the tarball (e.g. configure script next to * when devtool is creating a git repo in workspace it won't include these files from tarball in the initial devtool-base commit, because git ls-files won't list them * but then the first .patch file (without git headers) when applied with GitApplyTree._applypatch() will add all these still ignored files to a commit which used to only modify some files, because it's using -f: # Add all files shellcmd = ["git", "add", "-f", "-A", "."] output += runcmd(["sh", "-c", " ".join(shellcmd)], self.dir) at least in this case it would be better to add all ignored files in the initial devtool-base commit and then --force-patch-refresh will just include the small modification as before instead of adding unrelated files, just because they were initially ignored - this behavior will also match with the do_patch task in the actual build where the .gitignore is ignored when unpacking some tarball * my use-case is fixed in setup_git_repo, but similar function is in devtool upgrade, I've changed it there as well (From OE-Core rev: 06a24a615549af3550302a56ea08147000a608f3) Signed-off-by: Martin Jansa <> Signed-off-by: Richard Purdie <>
Diffstat (limited to 'scripts')
2 files changed, 3 insertions, 3 deletions
diff --git a/scripts/lib/devtool/ b/scripts/lib/devtool/
index d39c474fbd..6ebe368a9e 100644
--- a/scripts/lib/devtool/
+++ b/scripts/lib/devtool/
@@ -196,7 +196,7 @@ def setup_git_repo(repodir, version, devbranch, basetag='devtool-base', d=None):
if not os.path.exists(os.path.join(repodir, '.git')):'git init', cwd=repodir)'git config --local gc.autodetach 0', cwd=repodir)
-'git add .', cwd=repodir)
+'git add -f -A .', cwd=repodir)
commit_cmd = ['git']
oe.patch.GitApplyTree.gitCommandUserOptions(commit_cmd, d=d)
commit_cmd += ['commit', '-q']
diff --git a/scripts/lib/devtool/ b/scripts/lib/devtool/
index f962a71e41..ebe72282bb 100644
--- a/scripts/lib/devtool/
+++ b/scripts/lib/devtool/
@@ -235,14 +235,14 @@ def _extract_new_source(newpv, srctree, no_patch, srcrev, srcbranch, branch, kee
# Copy in new ones
_copy_source_code(tmpsrctree, srctree)
- (stdout,_) = __run('git ls-files --modified --others --exclude-standard')
+ (stdout,_) = __run('git ls-files --modified --others')
filelist = stdout.splitlines()
pbar = bb.ui.knotty.BBProgress('Adding changed files', len(filelist))
batchsize = 100
for i in range(0, len(filelist), batchsize):
batch = filelist[i:i+batchsize]
- __run('git add -A %s' % ' '.join(['"%s"' % item for item in batch]))
+ __run('git add -f -A %s' % ' '.join(['"%s"' % item for item in batch]))