summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGavin Li <gavin@matician.com>2021-04-12 22:29:23 -0700
committerRichard Purdie <richard.purdie@linuxfoundation.org>2021-04-30 14:37:32 +0100
commit3e8da09b5f2fa7a9471eff5e6fde4786b6842b40 (patch)
treea40a1fd9ac050151888b3bc0b62474d1473875b8
parent7fbb685c633dd3082c465712c5711398fe9df1b0 (diff)
downloadpoky-3e8da09b5f2fa7a9471eff5e6fde4786b6842b40.tar.gz
poky-3e8da09b5f2fa7a9471eff5e6fde4786b6842b40.tar.bz2
poky-3e8da09b5f2fa7a9471eff5e6fde4786b6842b40.zip
kmod: do not symlink config.guess/config.sub during autoreconf
I was encountering the following race condition on poky: - automake-native does do_install. - automake-native does do_populate_sysroot. This hardlinks config.guess and config.sub into ${D}. - kmod-native does do_configure. This runs `autoreconf`, which runs `automake --add-missing` (symlinks config.guess/config.sub from recipe-sysroot-native to build dir), then runs `gnu-configize` (copies _its own_ config.guess/config.sub _on top_ of the already existing ones). Since the destinations already had symlinks, the copy would overwrite config.guess/config.sub in recipe-sysroot-native, which would in turn overwrite the same in ${D} due to being hardlinked. - automake-native does do_package. The outhash is thus calculated on the clobbered config.guess/config.sub files. With hash equivalency enabled, the different outhash produced a different unihash, which kept me from reusing sstate between my laptop and my build server. This race condition would happen only on the build server (BB_NUMBER_THREADS = 32) but never on my laptop (BB_NUMBER_THREADS = 6). I didn't see the --install and --symlink flags being used by any other recipe, so I removed them, and that fixed the issue. (From OE-Core rev: b423a574496a7bf6023883584a6d1ad1cdb8f017) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 89d675efd633b495daa4a3a57420b9c309497035) Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/recipes-kernel/kmod/kmod.inc1
1 files changed, 0 insertions, 1 deletions
diff --git a/meta/recipes-kernel/kmod/kmod.inc b/meta/recipes-kernel/kmod/kmod.inc
index 646dff9a97..10a319ac9f 100644
--- a/meta/recipes-kernel/kmod/kmod.inc
+++ b/meta/recipes-kernel/kmod/kmod.inc
@@ -26,7 +26,6 @@ SRC_URI = "git://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git \
S = "${WORKDIR}/git"
-EXTRA_AUTORECONF += "--install --symlink"
EXTRA_OECONF +=" --enable-tools --with-zlib"
PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"