From 75e3e7d600eb72e7374b1ecf5ece7b831bc98ed8 Mon Sep 17 00:00:00 2001 From: Cristian Stoica Date: Tue, 17 Feb 2015 13:12:53 +0200 Subject: [PATCH 22/26] cryptodev: do not zero the buffer before use - The buffer is just about to be overwritten. Zeroing it before that has no purpose Change-Id: I478c31bd2e254561474a7edf5e37980ca04217ce Signed-off-by: Cristian Stoica Reviewed-on: http://git.am.freescale.net:8181/34217 --- crypto/engine/eng_cryptodev.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/crypto/engine/eng_cryptodev.c b/crypto/engine/eng_cryptodev.c index 1ab5551..dbc5989 100644 --- a/crypto/engine/eng_cryptodev.c +++ b/crypto/engine/eng_cryptodev.c @@ -1681,21 +1681,16 @@ static int bn2crparam(const BIGNUM *a, struct crparam *crp) { ssize_t bytes, bits; - u_char *b; - - crp->crp_p = NULL; - crp->crp_nbits = 0; bits = BN_num_bits(a); bytes = (bits + 7) / 8; - b = malloc(bytes); - if (b == NULL) + crp->crp_nbits = bits; + crp->crp_p = malloc(bytes); + + if (crp->crp_p == NULL) return (1); - memset(b, 0, bytes); - crp->crp_p = (caddr_t) b; - crp->crp_nbits = bits; BN_bn2bin(a, crp->crp_p); return (0); } -- 2.3.5