aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHimadri Pandya <himadrispandya@gmail.com>2020-08-27 12:23:55 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-09-09 19:14:34 +0200
commit830b08e696f777bfc5cb7739b7f9b0fe4cb3374c (patch)
tree1846398b8627ce512089707cda4faa416296b3b7
parent548c1175051d986132046080e94b058c41e469f0 (diff)
downloadlinux-yocto-830b08e696f777bfc5cb7739b7f9b0fe4cb3374c.tar.gz
linux-yocto-830b08e696f777bfc5cb7739b7f9b0fe4cb3374c.tar.bz2
linux-yocto-830b08e696f777bfc5cb7739b7f9b0fe4cb3374c.zip
net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()
commit a092b7233f0e000cc6f2c71a49e2ecc6f917a5fc upstream. The buffer size is 2 Bytes and we expect to receive the same amount of data. But sometimes we receive less data and run into uninit-was-stored issue upon read. Hence modify the error check on the return value to match with the buffer size as a prevention. Reported-and-tested by: syzbot+a7e220df5a81d1ab400e@syzkaller.appspotmail.com Signed-off-by: Himadri Pandya <himadrispandya@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/net/usb/asix_common.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
index e39f41efda3e..7bc6e8f856fe 100644
--- a/drivers/net/usb/asix_common.c
+++ b/drivers/net/usb/asix_common.c
@@ -296,7 +296,7 @@ int asix_read_phy_addr(struct usbnet *dev, int internal)
netdev_dbg(dev->net, "asix_get_phy_addr()\n");
- if (ret < 0) {
+ if (ret < 2) {
netdev_err(dev->net, "Error reading PHYID register: %02x\n", ret);
goto out;
}