aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMohamad Heib <mohamadh@mellanox.com>2019-10-02 15:21:27 +0300
committerPaul Gortmaker <paul.gortmaker@windriver.com>2019-11-09 19:33:46 -0500
commit9fc11ae5dee964e68134182095a97344e683fb3e (patch)
tree877ac0b8caa5d917a79402c74a02f0a1d5fb853f
parentfee3c62537ff88431746520186ceb08c03a4293c (diff)
downloadlinux-yocto-9fc11ae5dee964e68134182095a97344e683fb3e.tar.gz
linux-yocto-9fc11ae5dee964e68134182095a97344e683fb3e.tar.bz2
linux-yocto-9fc11ae5dee964e68134182095a97344e683fb3e.zip
IB/core: Fix wrong iterating on ports
commit 1cbe866cbcb53338de33cf67262e73f9315a9725 upstream. rdma_for_each_port is already incrementing the iterator's value it receives therefore, after the first iteration the iterator is increased by 2 which eventually causing wrong queries and possible traces. Fix the above by removing the old redundant incrementation that was used before rdma_for_each_port() macro. Cc: <stable@vger.kernel.org> Fixes: ea1075edcbab ("RDMA: Add and use rdma_for_each_port") Link: https://lore.kernel.org/r/20191002122127.17571-1-leon@kernel.org Signed-off-by: Mohamad Heib <mohamadh@mellanox.com> Reviewed-by: Erez Alfasi <ereza@mellanox.com> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Reviewed-by: Jason Gunthorpe <jgg@mellanox.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
-rw-r--r--drivers/infiniband/core/security.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/core/security.c b/drivers/infiniband/core/security.c
index 1ab423b19f77..6eb6d2717ca5 100644
--- a/drivers/infiniband/core/security.c
+++ b/drivers/infiniband/core/security.c
@@ -426,7 +426,7 @@ int ib_create_qp_security(struct ib_qp *qp, struct ib_device *dev)
int ret;
rdma_for_each_port (dev, i) {
- is_ib = rdma_protocol_ib(dev, i++);
+ is_ib = rdma_protocol_ib(dev, i);
if (is_ib)
break;
}