From 52e447159bc875aade409bd5db15808e6bde7b3d Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Thu, 28 Sep 2017 12:42:01 +1000 Subject: [PATCH 2412/4131] amdgpu/dc: don't check for 0 on register read/writes always. This adds ~50k to the driver text segment, and 10k to data segment. text data bss dec hex filename 2385556 39681 1045 2426282 2505aa drivers/gpu/drm/amd/amdgpu/amdgpu.o text data bss dec hex filename 2336593 28857 1045 2366495 241c1f drivers/gpu/drm/amd/amdgpu/amdgpu.o Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dm_services.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dm_services.h b/drivers/gpu/drm/amd/display/dc/dm_services.h index e43f9b2..53fd300 100644 --- a/drivers/gpu/drm/amd/display/dc/dm_services.h +++ b/drivers/gpu/drm/amd/display/dc/dm_services.h @@ -92,6 +92,9 @@ irq_handler_idx dm_register_interrupt( * */ +/* enable for debugging new code, this adds 50k to the driver size. */ +/* #define DM_CHECK_ADDR_0 */ + #define dm_read_reg(ctx, address) \ dm_read_reg_func(ctx, address, __func__) @@ -101,12 +104,12 @@ static inline uint32_t dm_read_reg_func( const char *func_name) { uint32_t value; - +#ifdef DM_CHECK_ADDR_0 if (address == 0) { DC_ERR("invalid register read; address = 0\n"); return 0; } - +#endif value = cgs_read_register(ctx->cgs_device, address); return value; @@ -121,10 +124,12 @@ static inline void dm_write_reg_func( uint32_t value, const char *func_name) { +#ifdef DM_CHECK_ADDR_0 if (address == 0) { DC_ERR("invalid register write. address = 0"); return; } +#endif cgs_write_register(ctx->cgs_device, address, value); } -- 2.7.4