summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rts5139
AgeCommit message (Collapse)Author
2014-01-13Staging: rts5139: rts51x_card: fixed style issuesMorgan Creekmore
fixed coding style issues, long lines and extra parentheses on return statement Signed-off-by: Morgan Creekmore <morgan.creekmore@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-09staging: rts5139: Drop print of build timeJosh Triplett
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __TIME__, which makes the build non-deterministic. (And, without __DATE__, __TIME__ provided little useful information to begin with.) Signed-off-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-12-17staging: delete non-required instances of include <linux/init.h>Paul Gortmaker
None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-12-17Staging: rts5139: fix parantheses coding style issue in ms.cPreetam D'Souza
This patch fixes an unnecessary return statement parantheses error found in ms.c by the checkpatch.pl tool. Signed-off-by: Preetam D'Souza <preetamjdsouza@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-27staging: rts5139: Replaced min() with min_t() inArchana kumari
This patch replaces min() with min_t() in rts51x_scsi.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-03staging: rts5139: Use correct USB transfer interval to fix syslog spammingMarcus Overhagen
Using correct transfer interval as specified by the USB endpoint when doing the interrupt transfer fixes the warning printed by xhci USB core on every transfer that resulted in spamming "xhci_queue_intr_tx: 74 callbacks suppressed" to syslog every 5 seconds. Signed-off-by: Marcus Overhagen <marcus.overhagen@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-03staging: rts5139: Fix SD card detection on Samsung NP730U3E UltrabookMarcus Overhagen
The timeout detection implemented in this driver isn't very robust. Although the USB interrupt transfer was successful, the polling thread often reported timeouts because the 50ms had expired before it got scheduled, and the SD card wasn't detected. Increasing it to 100ms, as used in other places of this driver, makes it work. Signed-off-by: Marcus Overhagen <marcus.overhagen@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-01Merge branch 'for-linus' of ↵Linus Torvalds
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs Pull VFS updates from Al Viro, Misc cleanups all over the place, mainly wrt /proc interfaces (switch create_proc_entry to proc_create(), get rid of the deprecated create_proc_read_entry() in favor of using proc_create_data() and seq_file etc). 7kloc removed. * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (204 commits) don't bother with deferred freeing of fdtables proc: Move non-public stuff from linux/proc_fs.h to fs/proc/internal.h proc: Make the PROC_I() and PDE() macros internal to procfs proc: Supply a function to remove a proc entry by PDE take cgroup_open() and cpuset_open() to fs/proc/base.c ppc: Clean up scanlog ppc: Clean up rtas_flash driver somewhat hostap: proc: Use remove_proc_subtree() drm: proc: Use remove_proc_subtree() drm: proc: Use minor->index to label things, not PDE->name drm: Constify drm_proc_list[] zoran: Don't print proc_dir_entry data in debug reiserfs: Don't access the proc_dir_entry in r_open(), r_start() r_show() proc: Supply an accessor for getting the data from a PDE's parent airo: Use remove_proc_subtree() rtl8192u: Don't need to save device proc dir PDE rtl8187se: Use a dir under /proc/net/r8180/ proc: Add proc_mkdir_data() proc: Move some bits from linux/proc_fs.h to linux/{of.h,signal.h,tty.h} proc: Move PDE_NET() to fs/proc/proc_net.c ...
2013-04-19staging: rts5129: re-use kbasename()Andy Shevchenko
The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. The __FILE__ macro always defined if we compile an existing file. Thus, NULL check is not needed there as well. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-04-09rts5139: switch to ->show_info()Al Viro
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-01staging: rts5139: device_reset() can be staticShawn Guo
Function device_reset() is only used in rts51x_scsi.c, so make it be static. Otherwise, it will have a name collision with the new added reset API. Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22staging: rts5139: fixed issues when config to built-in objectRoger Tseng
Fixed two issues when CONFIG_RTS5139=y : - Makefile doesn't take $(CONFIG_RTS5139). It always uses obj-m and built as a loadable module. - Rename some symbols with prefix 'rts51x_' to prevent symbol name collisions with drivers/staging/rts_pstor when both are configured to be built-in objects. drivers/staging/rts5139/built-in.o: In function `xd_cleanup_work': (.text+0x1435d): multiple definition of `xd_cleanup_work' drivers/staging/rts_pstor/built-in.o:(.text+0x2b96a): first defined here drivers/staging/rts5139/built-in.o: In function `release_xd_card': (.text+0x14393): multiple definition of `release_xd_card' drivers/staging/rts_pstor/built-in.o:(.text+0x2c491): first defined here drivers/staging/rts5139/built-in.o: In function `set_sense_data': (.text+0x1e02): multiple definition of `set_sense_data' drivers/staging/rts_pstor/built-in.o:(.text+0xa79f): first defined here drivers/staging/rts5139/built-in.o: In function `ms_delay_write': ... Signed-off-by: Roger Tseng <rogerable@realtek.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-09-26staging: rts5139: use kzalloc() to close an info leakDan Carpenter
If we don't fill the whole buffer then there is information leaked to the user. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-08-13staging: rts5139: substitute rts51x_dump by print_hex_dumpAndy Shevchenko
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-07-17staging: rts5139: rts51x_card: fixed brace coding style issueErik Jones
Fixed a coding style issue. An else statement was not on the same line as the preceding if statement's closing brace. Signed-off-by: Erik Jones <erik@ejnode.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-07-17staging: rts5139: rts51x_card: fixed brace coding style issueErik Jones
Fixed a coding style issue. Signed-off-by: Erik Jones <erik@ejnode.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-22staging: rts5139: Remove duplicate include of rts51x.hJesper Juhl
The header "rts51x.h" is included unconditionally at the start of the file and then again once more under "#ifdef SUPPORT_FILE_OP". Once is enough, so remove the conditional include and just keep the unconditional one. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-22staging: rts5139: rts51x_chip: fixed brace coding style issueErik Jones
Fixed a coding style issue. Signed-off-by: Erik Jones <erik@ejnode.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12staging: rts5139: Fix typo in rts5139Masanari Iida
Correct spelling typo in rts5139/rts51x_chip.h, rts51x_scsi.h Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12Staging: rts5139: sd_cprm: fix coding style and deprecation issuesAdnan Ali
This commit fixes coding style and deprecation issues which includes long lines, braces with single statments in if condition and deprecated min() function. Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-14staging: "rts5139" Fix typos.Justin P. Mattock
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused variable option.ww_enableOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused variable in rts51x_chip.hOleksij Rempel
the SENSE_TYPE_FORMAT_IN_PROGRESS was checked by rts51x_scsi.c but never set. Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused variable in rts51x.hOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused TUNE_SD18_*Oleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused polling_time variableOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused rcc_bug_fix_enOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused rcc_fail_flag variableOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused option->needs_remote_wakeupOleksij Rempel
module parametr needs_remote_wakeup sets option->needs_remote_wakeup and rts51x->pusb_intf->needs_remote_wakeup the second may be used, the first one is never used Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused led_blink_speed variableOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove disabled code in rts51x_card.cOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: make some functions static in ms.c and ms_mg.cOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused xd_check_err_code in xd.cOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: make some functions static in xd.cOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: make some functions static in sd_cprm.cOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: make some functions static in sd.*Oleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove soft_reset_sd_card in sd_cprm.cOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused rts51x_reset_pipe in rts51x_transport.*Oleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: make some functions static in rts51x_transport.*Oleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unsued *host_info in rts51x_scsi.cOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: make some functions static in rts51x_scsi.cOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-09staging: rts5139: Fix typo in rts5139Masanari Iida
Correct spelling typo in rts5139 Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-09staging: rts5139: remove unused card_power_offOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-09staging: rts5139: remove unused disable_card_clockOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-09staging: rts5139: make some functions static in rts51x_card.c and rts51x.cOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-09staging: rts5139: remove useless rts51x_sys.hOleksij Rempel
and move USING_POLLING_CYCLE_DELINK to rts51x_chip.h Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-09staging: rts5139: remove unused clear_first_install_markOleksij Rempel
it also removes rts51x_reset_detected_cards. Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-09staging: rts5139: remove disabled SCSI_SCAN_DELAY codeOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-09staging: rts5139: remove disabled XD_SPEEDUP codeOleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-09staging: rts5139: remove disabled SUPPORT_SD_LOCK code.Oleksij Rempel
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>