summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoss Burton <ross.burton@intel.com>2019-11-26 23:35:09 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2019-11-29 17:43:40 +0000
commit8a3a1e4a350657050eb04564ce2c49db82af86e5 (patch)
treeaaaa46d6d1c45510bdaa605dfcf746b8cec510f4
parentc534b4640a026a6036e17e7543f3b1d8fe2ffc5e (diff)
downloadpoky-8a3a1e4a350657050eb04564ce2c49db82af86e5.tar.gz
poky-8a3a1e4a350657050eb04564ce2c49db82af86e5.tar.bz2
poky-8a3a1e4a350657050eb04564ce2c49db82af86e5.zip
insane: fix GitHub /archive/ test
This test was failing to split the URL list to individual URLs, so if SRC_URI is something like this then the test incorrectly triggers: SRC_URI = "git://github.com/foo http://example.com/archive/foo" Fix this by splitting the SRC_URI list and iterating through the URIs one at time. [ YOCTO #13660 ] (From OE-Core rev: ddd2c5624404848ee668dabec0f61599ab5003e4) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/insane.bbclass6
1 files changed, 3 insertions, 3 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index f856cf6a2b..0564f9c2a4 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -893,9 +893,9 @@ def package_qa_check_src_uri(pn, d, messages):
if "${PN}" in d.getVar("SRC_URI", False):
package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d)
- pn = d.getVar("SRC_URI")
- if re.search(r"github\.com/.+/.+/archive/.+", pn):
- package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d)
+ for url in d.getVar("SRC_URI").split():
+ if re.search(r"github\.com/.+/.+/archive/.+", url):
+ package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d)
# The PACKAGE FUNC to scan each package