summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Eggleton <paul.eggleton@linux.intel.com>2012-09-21 15:47:23 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2012-09-24 12:13:50 +0100
commit991557216e4d7bf6d47e5f8054c0c3b0879a8bf5 (patch)
tree756d65fe4d9b65ae9343dece6f4e921afbd44a6d
parentd875d62f8ef606e188bf1e6561208e6b80b68d24 (diff)
downloadpoky-991557216e4d7bf6d47e5f8054c0c3b0879a8bf5.tar.gz
poky-991557216e4d7bf6d47e5f8054c0c3b0879a8bf5.tar.bz2
poky-991557216e4d7bf6d47e5f8054c0c3b0879a8bf5.zip
bitbake: hob: don't show error dialog for errors during building
During building we already report errors in a special tab and indicate when the build has failed; bringing up a dialog was a regression introduced in bitbake revision 5bab81b124087d63d6eb62a861e1241714fcd483. Fixes [YOCTO #3151]. (Bitbake rev: cf0a67d62f631aa48d1afc3fbdd0f73995b1c401) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--bitbake/lib/bb/ui/crumbs/hobeventhandler.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
index 8fc1732a8e..49db2deb27 100644
--- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
+++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
@@ -183,10 +183,11 @@ class HobHandler(gobject.GObject):
self.emit("sanity-failed", event._msg)
elif isinstance(event, logging.LogRecord):
- if event.levelno >= logging.ERROR:
- formatter = bb.msg.BBLogFormatter()
- msg = formatter.format(event)
- self.error_msg += msg + '\n'
+ if not self.building:
+ if event.levelno >= logging.ERROR:
+ formatter = bb.msg.BBLogFormatter()
+ msg = formatter.format(event)
+ self.error_msg += msg + '\n'
elif isinstance(event, bb.event.TargetsTreeGenerated):
self.current_phase = "data generation"