|author||Chris Larson <email@example.com>||2011-03-08 09:33:40 -0700|
|committer||Richard Purdie <firstname.lastname@example.org>||2011-03-31 12:21:52 +0100|
lockfile: ask for forgiveness, not permission
Create the lockfile directory if it doesn't exist, rather than erroring out if it doesn't exist (was also racy). Also improve the wording of the error message shown when the lockfile's directory is not writable. Note for the future, this function should be improved, particularly with regard to its exception handling. It should be catching the *exact* exception(s) it will encounter when the file is locked, and continuing in that case only. If it did that, there'd be no need for the proactive directory writability check, as bb.utils.lockfile() would raise an appropriate IOError for that case. (Bitbake rev: 238151441c74db53d6e4d4753f4f96c32f6f13b6) Signed-off-by: Chris Larson <email@example.com> Signed-off-by: Richard Purdie <firstname.lastname@example.org>
1 files changed, 6 insertions, 7 deletions
diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py
index a6f1337114..f49ee5544a 100644
@@ -407,13 +407,12 @@ def lockfile(name, shared=False):
Use the file fn as a lock file, return when the lock has been acquired.
Returns a variable to pass to unlockfile().
- path = os.path.dirname(name)
- if not os.path.isdir(path):
- logger.error("Lockfile destination directory '%s' does not exist", path)
+ dirname = os.path.dirname(name)
- if not os.access(path, os.W_OK):
- logger.error("Error, lockfile path is not writable!: %s" % path)
+ if not os.access(dirname, os.W_OK):
+ logger.error("Unable to acquire lock '%s', directory is not writable",
op = fcntl.LOCK_EX
@@ -449,7 +448,7 @@ def unlockfile(lf):
Unlock a file locked using lockfile()
- # If we had a shared lock, we need to promote to exclusive before
+ # If we had a shared lock, we need to promote to exclusive before
# removing the lockfile. Attempt this, ignore failures.