summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-01-27layer.conf: remove mention of isg layerpyroJoe Konno1-1/+1
This was removed in meta-intel, so do not reference it. Signed-off-by: Joe Konno <joe.konno@intel.com>
2016-12-19systemdev-image-xfce: remove epiphanyJoe Konno1-1/+0
Remove the epiphany web browser from -xfce and -xfce-sdk images. As epiphany depends on webkit, this will reduce image size by about 150 MB, and eliminate the need to build webkit and its roughly 2.3 GB worth of debug symbols. Signed-off-by: Joe Konno <joe.konno@intel.com>
2016-10-10php: bbappend: rename to php_5.6.26mortyJoe Konno1-0/+0
meta-openembedded master has updated the php 5.6 recipe to version 5.6.26. Rename in order for bbappend to function. Signed-off-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07ndctl: do not build documentationReinette Chatre1-1/+1
Building the ndctl documentation introduce host dependency on asciidoc and xmlto that we would prefer not to enforce. The documentation is not a required component for this system development based image so we disable it. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07phoronix-test-suite: disable systemd services by defaultReinette Chatre1-0/+1
We are seeing spontaneous reboots of system without any error or warning when these services are enabled. They are not required for system operation and we leave it to users to decide if required. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07iotools: support build/install on different architectureReinette Chatre2-5/+34
When building for a different architecture bitbake ensures that CC is set to correct compiler. Modify the Makefile to accept the value of CC from environment. The binary self is used during installation to create symlinks to appropriate names - it is thus not possible to complete installation on build system when it is of different architecture. Modify the installation rule to only install the binary and create a post install function that will be run on target. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07php: remove all build workaroundsReinette Chatre1-65/+0
We have accumulated several php build workarounds. These are now all disabled as it appears that php builds and runs smoothly at this time. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07systemdev-image: explicitly include util-linuxReinette Chatre1-0/+1
In previous Yocto releases we benefitted by util-linux included by default based on broader dependency settings in components and less specialized packaging by util-linux. Now there are more specialized packages created by util-linux for specific features and the packages depending on these are more explicit on which sub packages of util-linux it depends on. It has now reached a point where util-linux is not installed by default anymore and we would like to benefit from its useful commands and now install it explicitly. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07systemdev.conf: fixup incompatibility when using X11 from meta-oeReinette Chatre1-0/+1
With the usage of meta-oe the build will use xserver-common as a replacement for x11-common as we see during rootfs generation: "Multiple replacers for x11-common, using first one (xserver-common)" With the installation of xserver-common instead of x11-common we then get see an image creation failure because the dependency of packagegroup-core-x11-utils-dev on x11-common cannot be satisfied: * satisfy_dependencies_for: Cannot satisfy the following dependencies for packagegroup-core-x11-utils-dev: * x11-common (= 0.1-r47) * By setting VIRTUAL-RUNTIME_xserver_common we ensure that packagegroup-core-x11-utils-dev depends on what will be installed. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07releaseinfo.bbclass: ignore dependency on DATETIMEReinette Chatre1-0/+3
As part of rootfs generation the date is written to filesystem. Having DATETIME in the function causes the do_rootfs task hash to change frequently as reported with errors like: ERROR: systemdev-image-1.0-r0 do_rootfs: Taskhash mismatch a1c74ee774635585c54d2a99b174b52b verses 92fa56f8bc76ff7d1c927202fe918b29 for <snip>/meta-systemdev/recipes-systemdev/images/systemdev-image.bb.do_rootfs ERROR: Taskhash mismatch a1c74ee774635585c54d2a99b174b52b verses 92fa56f8bc76ff7d1c927202fe918b29 for <snip>/meta-systemdev/recipes-systemdev/images/systemdev-image.bb.do_rootfs Exclude the DATETIME value from the checksum computation. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07iotools: disable build of static librariesReinette Chatre1-1/+5
Static library generation is now disabled by default for Poky and we follow same guidance here to save build time as well as the size used for build output artifacts. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07ndctl: update to latest release v54Reinette Chatre1-4/+4
New release is available and update to it. ndctl new version now install bash-completion files so ensure these are packaged correctly with appropriate dependencies installed. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07suspendresume: update development tracking recipe to point to latestReinette Chatre1-1/+1
This is a git recipe, tracking development, update it to point to most recent source revision. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07iotools: update download location of releaseReinette Chatre1-1/+1
The location where latest release is obtained has changed. Update the recipe to reflect new location. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07cpuid: update to release 20160814Reinette Chatre1-3/+3
Moving to krogoth release is great opportunity to ensure we are tracking most recent of packages. Update cpuid to latest release available. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07thermald: update development recipe to track latestReinette Chatre1-1/+1
This recipe tracks the git repo, not official releases, and we update it to track the latest at this time. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07watts-up: update to latest SRCREV availableReinette Chatre1-1/+1
The watts-up project do not generate releases so we just update our recipe to point to latest available from development. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07avahi bbappend: Remove obsolete bug workaroundScott Lawson1-22/+0
This bbappend file for the AVAHI recipe is a workaround for a bug that has been fixed. E-mail thread for reference: http://thread.gmane.org/gmane.comp.handhelds.openembedded.core/60414 Signed-off-by: Scott Lawson <scott.lawson@intel.com> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07busybox bbappend: Updated to new version numberScott Lawson1-0/+0
Poky layer has updated to Busybox 1.24.1. Rename recipes-core/busybox/busybox_1.23.2.bbappend -> recipes-core/busybox/ busybox_1.24.1.bbappend Signed-off-by: Scott Lawson <scott.lawson@intel.com> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-09-07php bbappend: Updated to new version numberScott Lawson1-0/+0
meta-openembedded layer has updated to PHP 5.6.23. Rename recipes-devtools/php/php_5.6.12.bbappend -> recipes-devtools/php/ php_5.6.23.bbappend Signed-off-by: Scott Lawson <scott.lawson@intel.com> [reinette.chatre@intel.com: change update to 5.6.23 from original 5.6.18] Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Joe Konno <joe.konno@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2016-06-03systemdev-image: add wmctrl to systemdev imagesReinette Chatre1-0/+1
With systemdev images used during system enabling it also supports test automation. wmctrl provides command line access to almost all the features defined in the EWMH specification. It can be used, for example, to get information about the window manager, to get a detailed list of desktops and managed windows, to switch and resize desktops, to make windows full-screen, always-above or sticky, and to activate, close, move, resize, maximize and minimize them. All dependencies of this utility are already included in the xfce-sdk image so we see very little size impact. The libxt and libxmu dependencies need to be added to xfce image so we are seeing bigger impact there. systemdev-image-xfce-sdk: +48KB systemdev-image-xfce: +552KB Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
2016-06-03wmctrl: new recipeReinette Chatre1-0/+12
wmctrl is a UNIX/Linux command line tool to interact with an EWMH/NetWM compatible X Window Manager. The tool provides command line access to almost all the features defined in the EWMH specification. It can be used, for example, to get information about the window manager, to get a detailed list of desktops and managed windows, to switch and resize desktops, to make windows full-screen, always-above or sticky, and to activate, close, move, resize, maximize and minimize them. The command line access to these window management functions makes it easy to automate and execute them from any application that is able to run a command in response to an event. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
2016-03-01systemdev-image: add ndctl to all systemdev imagesReinette Chatre1-0/+1
We would like to enable manage "libnvdimm" subsystem devices (Non-volatile Memory) from all images. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
2016-03-01ndctl: new recipeReinette Chatre1-0/+23
We introduce a new recipe for ndctl, the base library for supporting management of platform NVDIMM (Non-volatile Memory) resources. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
2016-03-01systemdev: add psmisc to all imagesReinette Chatre3-0/+7
The killall utility is very useful during some automated tests. Adding psmisc provides us with this utility as well as useful fuser and pstree. With fuser now provided by psmisc we can disable it in busybox. Image size increases: systemdev-image: 124K systemdev-image-sdk: 136K systemdev-image-xfce: 144K systemdev-image-xfce-sdk: 176K Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
2016-03-01busybox: use correct Kconfig language in config filesReinette Chatre2-14/+14
Using "=n" is not ideal way to disable configuration options. Move current disabled settings to use the recommended "# CONFIG* is not set" instead. Confirmed with buildhistory that this change has no impact on image Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
2016-02-18systemdev: add support for software RAIDReinette Chatre1-0/+1
To help with system development in this area we add mdadm tool for managing software RAID under Linux. The image size increase has been measured as: systemdev-image: 980K systemdev-image-sdk: 1012K systemdev-image-xfce: 992K systemdev-image-xfce-sdk: 1036K Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
2016-01-29systemdev: include dpdk in systemdev imageReinette Chatre2-1/+5
DPDK is a set of libraries and drivers for fast packet processing. It was designed to run on any processors. The first supported CPU was Intel x86 and it is now extended to IBM Power 8, EZchip TILE-Gx and ARM. DPDK can be found in meta-isg layer from meta-intel so we update layer dependencies. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
2016-01-29layer: fix layer dependency on intel (meta-intel) layerReinette Chatre1-1/+1
meta-systemdev depends on meta-intel but the layer dependecy has not been configured in layer.conf, fix this. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02systemdev.conf: remove now default xvmc configReinette Chatre1-1/+0
The upstream recipe of xf86-video-intel now includes xvmc as one of the default configurations so we need not select it anymore. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02iotools: fixup permissions related to host-user-contaminated warningReinette Chatre1-0/+4
During build we see following QA warning: WARNING: QA Issue: iotools: /iotools/usr/sbin/iotools is owned by uid 1000, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated] This is because the Makefile installs files with "cp -a" which preserves ownership of user running bitbake. We fixup the permissions after installation from Makefile. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02systemdev.conf: remove SVK mirrorReinette Chatre1-1/+0
We are seeing following WARNING during image build: WARNING: Invalid protocol (svk) in PREMIRRORS: svk://.*/.* http://downloads.yoctoproject.org/mirror/sources/ As with upstream commit below we remove SVK mirror since svk fetcher was removed in bitbake 1.22 commit b2b59b14ecfe13ba794d92f97d1403d6503c7407 Author: Ross Burton <ross.burton@intel.com> Date: Tue May 5 13:17:00 2015 +0100 poky.conf: remove SVK mirror The svk fetcher was removed in bitbake 1.22 and oe-core master doesn't consider svk: a valid URL for mirrors. (From meta-yocto rev: fff0423522b9574698575b1a28cf77a7831371c1) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Acked-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02drm: remove libdrm_git bbappendDarren Hart1-6/+0
libdrm_git.bb was removed from poky as of: commit 4913e35bfe136fec2b291a35d36aad69f900ba92 Author: Ross Burton <ross.burton@intel.com> Date: 2015-07-03 libdrm: remove git recipe, merge inc The versioned recipe includes the installtests.patch, so we have no need for the bbappend. If we require a newer version from git, we'll need to add the git recipe to systemdev. Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02midori: remove midori in favor of epiphanyDarren Hart1-1/+1
Poky removed midori and replaced it with epiphany as of: commit 8fcb01cd856a02d8e457054c47be66a527459b45 Author: Alexander Kanavin <alexander.kanavin@linux.intel.com> Date: 2015-06-04 midori: remove the recipe and replace references to midori with epiphany Remove the bbappend and replace midori with epiphany in the xfce image. Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02busybox: bbappend rename for master version 1.23.2Darren Hart1-0/+0
Update the recipe to apply to the recipe version in master. Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02php: bbappend rename for master version 5.6.12Darren Hart1-0/+0
Update the recipe to apply to the recipe version in master. Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02avahi: fix dependency issueReinette Chatre1-0/+22
We are seeing image creation failures as below: Collected errors: * satisfy_dependencies_for: Cannot satisfy the following dependencies for gvfs-gdu-volume-monitor-dev: * avahi-daemon (= 0.6.31-r11.0) * libavahi-core7 (= 0.6.31-r11.0) * libavahi-client3 (= 0.6.31-r11.0) * * opkg_install_cmd: Cannot install package gvfs-gdu-volume-monitor-dev. This failure is a result of the libavahi-ui-dev package having dependencies as following in its package information: Package: libavahi-ui-dev Version: 0.6.31-r11.0 Depends: avahi-daemon (= 0.6.31-r11.0), libavahi-core7 (= 0.6.31-r11.0), libavahi-ui0, libavahi-client3 (= 0.6.31-r11.0) This issue is known and a patch was proposed upstream at: http://thread.gmane.org/gmane.comp.handhelds.openembedded.core/60414 This patch was rejected but there is no alternative solution. Until the real fix becomes available upstream we carry a similar fix locally. The fix was adjusted to only touch the avahi-ui recipe and be used in a bbappend instead of patching the Poky layer directly. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> [ dvhart@linux.intel.com: minor whitespace cleanup ] Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02hdperf: add sha256 checksumReinette Chatre1-0/+1
We are seeing build warning due to this missing checksum. Fix it. WARNING: Missing sha256 SRC_URI checksum for /SNIP/poky/build/downloads/hdperf-1.5.tar.gz, consider adding to the recipe: SRC_URI[sha256sum] = "367135fbab6a83545cd1a9e08c8543cd503b165d83e4aca94095fd4e30e99555" Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02mesa: remove recipe - more recent version available upstreamReinette Chatre1-13/+0
The mesa_git.bb recipe found in Poky layer builds from upstream mesa branch 10.4, more recent than the 10.3 we have in the local recipe. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02fb-test: remove install fixup that is now upstreamReinette Chatre1-9/+0
meta-openembedded commit 8f63850c4d1f348a7 "fb-tests: Prepend fb- to the binaries" introduced this fix upstream and we do not need to carry it in meta-systemdev anymore. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02suspendresume: update SRCREV to latest HEADReinette Chatre1-1/+1
We update the SRCREV to pick up the latest development of the suspendresume project. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02phoronix-test-suite: remove duplicate recipeReinette Chatre1-34/+0
The recipe for phoronix-test-suite is available in the fido release of meta-openembedded that we are building with. We do not need to duplicate it in meta-systemdev. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02systemdev.conf: use logic to edit WARN_QA and ERROR_QAReinette Chatre1-7/+5
This is a clone of upstream commit that made similar change to the poky.conf distro configuration. Commit message duplicated below: commit 013f7e286d72c51b52a72fdbff6cbc875b3a15ac Author: Ross Burton <ross.burton@intel.com> Date: Mon Feb 2 23:32:31 2015 +0000 poky.conf: use logic to edit WARN_QA and ERROR_QA Instead of overriding WARN_QA and ERROR_QA, edit the defaults to remove specific tests from WARN_QA and add them to ERROR_QA. This should avoid tests being added to poky.conf but not insane.bbclass (unknown-configure-option wasn't enabled in oe-core), or vice versa (infodir wasn't enabled in Poky). (From meta-yocto rev: 32f5014c871f5fd86262fb6a87b60360b1b21d07) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02distro conf: add Fedora-21 to tested distrosReinette Chatre1-0/+1
we have successfully built the image with Fedora-21. This distro has also been added to the upstream poky distro configuration. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02turbostat: support new kernel build processReinette Chatre1-9/+4
Poky commit 86893e4ea5896199a "kernel: Rearrange for 1.8" made significant changes in the kernel build process that includes moving the kernel source and build artifacts out of sstate control and into a shared location. We build turbostat from the kernel source and need to accommodate these upstream changes adding the new dependency of "do_shared_workdir". In addition we inherit the new "kernelsrc" class instead of depending on kernel (virtual/kernel) self. This feature was added in 86893e4ea5896199a. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02systemdev-image-xfce: remove gst-va-intelReinette Chatre1-1/+0
This dependency was removed in fido with all needed items captured in gstreamer-vaapi-1.0 Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02systemdev.conf: update OELAYOUT_ABIReinette Chatre1-1/+1
The layout of TMPDIR changed in fido. We will rebuild now with moving to fido. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-12-02systemdev.conf: remove EXTRAOPKGCONFIGReinette Chatre1-3/+0
The "poky-feed-config-opkg" dependency does not exist anymore and our reference distro config (poky.conf) is not setting this anymore either. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-10-16systemdev-image: Include tools for Flash-Friendly File System (F2FS)Reinette Chatre1-0/+1
System development involving f2fs will benefit from these f2fs tools. They include mkfs to create the filesystem, also fsck, dump, f2fstat, and libf2fs. Impack in image size was measured as: systemdev-image 120K systemdev-image-sdk 132K systemdev-image-xfce 148K systemdev-image-xfce-sdk 136K Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
2015-10-16systemdev-image: add XFS utilities to systemdev-imageReinette Chatre1-0/+1
We include the xfsdump package that contains a few XFS utililties. These include: xfsinvutil: xfsdump inventory database checking and pruning utility xfsrestore: XFS filesystem incremental restore utility xfsdump: XFS filesystem incremental dump utility Impact on image size was measured as: systemdev-image 580K systemdev-image-sdk 576K systemdev-image-xfce 564K systemdev-image-xfce-sdk 576K Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>