aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-03-15swupd-image.bbclass: add another missing expand arg in getVarsHEADmasterAaron Zinghini1-1/+1
Add "True" to d.getVar() to avoid forking a little while longer. This got broken in commit c63e8c0d95604ee5 "swupd-image.bbclass: dont fail parsing if SWUPD_BUNDLES is undefined" Signed-off-by: Aaron Zinghini <aaron.zinghini@seeingmachines.com>
2017-02-18swupd-http-server: simple Python-based serverPatrick Ohly1-0/+64
Can be invoked in a build directory to serve the deploy/swupd directory of an image to a real device or another build (for incremental builds which need to download files). Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2017-02-17README: update maintainerPatrick Ohly1-1/+1
Bugzilla default assignee was changed already. Also update here. However, this is tentative and might have to change again. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2017-02-17bsdiff: fix bzip2 dependency issuePatrick Ohly1-1/+3
When DEPENDS=bzip2 becomes bzip2-native in bsdiff-native, the dependency ends up getting ignored because bzip2-native is in ASSUME_PROVIDED. But we need the library and thus have to depend on bzip2-replacement-native. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2017-02-17bundles.py: fix copying of full image to full bundle when no SWUPD_BUNDLESAndré Draszik1-2/+3
When SWUPD_BUNDLES is not set, exceptions are thrown, stopping the build - there are two issues in here: - the debug statement references a non-existent variable, 'bundle' was renamed to fulltar - copyxattrfiles() needs a list of files as 2nd argument, not a filename of a file which contains this list This got broken in commit 6c097131ad39 ("meta-swupd: support rm_work.bbclass") while support for rm_work was being added. Signed-off-by: André Draszik <git@andred.net>
2017-02-17path.py: always clean up temporary file in copyxattrfiles()André Draszik1-4/+6
Use try: finally: to make sure the file is removed even on exceptions. Signed-off-by: André Draszik <git@andred.net>
2017-02-17swupd-image.bbclass: don't fail parsing if SWUPD_BUNDLES is undefinedAndré Draszik1-1/+1
ERROR: Error for ...image.bb, dependency ${@' does not contain exactly one ':' character. Task 'depends' should be specified in the form 'packagename:task' ERROR: Command execution failed: Exited with 1 Signed-off-by: André Draszik <git@andred.net>
2017-02-17swupd-image.bbclass: split out swupd-client and config specific bitsAndré Draszik3-144/+167
It is useful to be able to integrate swupd-client into an image that is not itself subject to swupd based processing. An example would be an initramfs that contains the client, but that initramfs itself is a regular file in a different (outer) file system (image). The outer image would be subject to swupd processing, and the inner initramfs is simply responsible to update the outer file system during system (re)start. Having split all swupd-client specific functionality into its own class, the initramfs image recipe can now inherit the client specific class, and benefit from correct contents for files in /usr/share/defaults/swupd, correct public keys, and correct URLs. Signed-off-by: André Draszik <git@andred.net>
2017-02-17swupd-image.bbclass: add missing expand arg in getVarsAaron Zinghini1-1/+1
Add "True" to d.getVar() to avoid forking a little while longer. The expand arg has been set to true by default in master branch and breaks compatibility with branches. Signed-off-by: Aaron Zinghini <aaron.zinghini@seeingmachines.com>
2017-01-23swupd-image.bbclass: avoid depending on time commandPatrick Ohly1-1/+7
The time command's output is merely informational and less relevant now that performance is better than it used to be. Calling it unconditional is problematic because some build hosts might not have it. By default the command is no longer used, but can still be enabled locally by setting SWUPD_TIMING_CMD = "time" in local.conf or site.conf. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2017-01-13meta-swupd: support rm_work.bbclassPatrick Ohly4-50/+76
Sharing data between virtual images only worked when rm_work.bbclass was not active. To support rm_work.bbclass, the new do_swupd_list_bundle generates the necessary information about the rootfs before do_rm_work removes the rootfs. The output files and the mega image rootfs.tar get excluded from the cleanup via the new RM_WORK_EXCLUDE_ITEMS. While at it, some inaccurate comments get removed. As a side effect of the more granular work split, it is now possible to make swupd images depend on exactly those bundle images that they contain. Now it is possible to build a swupd image without first having to build all swupd images, which might speed up a build (less work on the critical path). Fixes: [YOCTO #10799] Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2017-01-05bundles.py: fix "no bundles" special casePatrick Ohly1-2/+4
The recent enhancements broke the case where meta-swupd is only used as update mechanism, without any additional bundles installed. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-server: allow directory -> symlink transitionPatrick Ohly4-0/+90
A local patch is needed for updating Ostro OS 1.0 until upstream officially supports this. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupdbundle.bbclass: speed up mega image creationPatrick Ohly1-1/+1
Creating the mega image archive is on the critical path (depends on all target components having been compiled and blocks creating images). Compressing, even with pbzip, is slower than directly writing the uncompressed archive (tested with a striped RAID array of two traditional hard drives and a fast multicore CPU) and decompression again takes additional time, so avoid the slowdown by not compressing. The downside is higher disk space usage. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08do_swupd_update: support format changesPatrick Ohly33-839/+2609
There are reasons for format changes, the upcoming tools update being one of them. When the format changes, swupd-image.bbclass must build two OS versions from the same rootfs: once with the old format, once with the new format. OS_VERSION is used as number for the new format, OS_VERSION - 1 for the old one. OS_VERSION must be high enough such that OS_VERSION - 1 is still available. Usually it is, but there's also a sanity check for that. When changing the format because of a change in the tools, then both old and new swupd-server are needed, so now recipe and installed files include the tool format version. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-image.bbclass: enhance OS_VERSION sanity checkPatrick Ohly1-1/+3
Besides being an integer, it also must be in the signed int32 range supported by swupd. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-server/client: remove 2.x versionsPatrick Ohly25-2503/+0
They are neither used nor supported. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-server: fix build issue with libmagicPatrick Ohly1-1/+3
libmagic is provided by file-native and required by swupd-server-native, but because file-native is usually assumed to be provided, it won't get compiled unless we depend on the special file-replacement-native. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08do_swupd_update: run swupd_make_pack in parallelPatrick Ohly1-8/+18
Internally, swupd_make_pack mostly just spends its time on a single CPU while compressing a large .tar archive. We can shorten the overall execution time by running swupd_make_pack invocations in parallel. The current approach just runs all of them at once. This might overload small machines or larger ones when the number of bundles increases, so some more intelligence might be needed. Depends on a fix for background processes in the bitbake shell parser (YOCTO #10668). Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-client: speed up download of large files when using IMAPatrick Ohly3-0/+372
When IMA is active, the kernel ended up updating the file hash each time swupd wrote a chunk, because files were getting opened and closed for each chunk. Now they get opened before downloading and closed when done. Fixes: clearlinux/swupd-client/#41 Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd_create_pack: enable delta computationPatrick Ohly7-23/+607
The previous approaches all relied on somehow carrying additional data across from one build to the next (sstate or additional archives in the deploy directory). The new approach replaces that with downloading required content on a file-by-file basis from the normal update repo when (and not sooner) it is needed by swupd_create_pack. That works for meta-swupd because the format of the files (compressed archive created with bsdtar) is expected to be stable. If a change ever becomes necessary, some backward compatibilty mode would have to be added or deltas simply would be skipped again. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08do_swupd_update: pseudo database under deploy directoryPatrick Ohly1-2/+6
Putting the database under the deploy directory automatically makes it specific to the OS_VERSION and removing the deploy directory also removes the corresponding pseudo database, thus ensuring a clean rebuild with a single command. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-server: avoid pseudo xattr removal bugPatrick Ohly3-0/+44
Not removing the directories is okay: typically we don't build incrementally, and we can remove any remaining ones before invoking swupd. Not removing a tempory directory tree may also have performance benefits, but the even better solution will be to not write the tree in the first place by calling libarchive directly. Related-to: https://bugzilla.yoctoproject.org/show_bug.cgi?id=10623 Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-server: fix delta computation with xattrsPatrick Ohly2-0/+37
In the case that a diff against a previous build is computed and both old and new files have the same xattr, the server failed because an internal sanity check was implemented incorrectly. Not relevant at the moment for Ostro OS because changing file content implies changing the ima.security xattr, in which case current swupd-server skips diffing entirely (changing xattrs via patching not supported). It's more relevant for Ostro OS XT, which has Smack, but not IMA. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-server: avoid segfault when nothing changedPatrick Ohly2-0/+33
swupd_create_fullfiles segfaulted when no new files were needed for the current build because nothing changed. Very unlikely, but can happen during testing. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-image.bbclass: per-OS_VERSION swupd databasePatrick Ohly1-2/+5
It is better to start each OS_VERSION build with a clean pseudo database because then performance is expected to be better. Only relevant for repeated local builds; CI builds already start from scratch. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-client: fix Manifest hash mismatch errorPatrick Ohly2-0/+182
The IMA and Smack xattrs of the downloaded Manifest files are set on the downloaded and unpacked Manifest files, while the server doesn't have them at all. They need to be ignored. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08meta-swupd: archive mega rootfs with bsdtarPatrick Ohly5-52/+64
Instead of granting all virtual images access to the mega rootfs under a shared pseudo instance, archive the mega rootfs in an archive and extract from that the subset of entries that are needed. Sharing pseudo instances is slow: using more than one avoids a potential bottleneck (the pseudo daemon is often 100% busy on a CPU during heavy use). Extracting files with full attributes also is faster when merely sweeping through a tar archive, at least when most of the content is needed. This change therefore increases performance. bsdtar with support for --no-recursive in combination with -x is needed for that. Current bsdtar master does not support that yet, but adding it was easy. GNU tar already supports that, but had bugs in that mode ("Not found in archive" errors for entries that were in the archive). bsdtar is also nicer for other reasons and therefore was extended instead of trying to fix GNU tar: - no need to explicitly add xattrs - guaranteed to auto-detect compression, even when reading from stdin (GNU tar can only do that when working with files); not that relevant here, though - uses less system calls when creating files, which should help a bit with performance under pseudo Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08meta-swupd: create update based on previous buildPatrick Ohly2-7/+173
Creating updates based on the Manifest.full of the previous build allows reusing unchanged files, i.e. work on compressing these file and the storing the result again under "files" gets avoided. This works by referencing the previous version in the new Manifest files. The implication of that is that versions no longer can be published separately. The content produced by all previous builds must also be available to the client. This is independent of computing deltas. Nothing besides the previous "www" content needs to be available. It gets downloaded automatically when starting a build without a previous swupd deploy directory, so no extra work is needed to enable this mode besides publishing the previous build results. Fixes [YOCTO #9189] Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08meta-swupd: per-image swupd client configurationPatrick Ohly2-20/+82
The settings affecting the swupd client belong to the image, not the swupd client recipe. That way, different images can use different settings while sharing the same swupd client. Creating the bundles directory was broken in the swupd-client recipe and also not needed because swupd-image.bbclass does it, too. This will also allow implementing better update repo generation (incremental, supporting format changes, etc.) because now swupd-image.bbclass has access to the settings. The installed swupd client must match the format of the update repo for that OS_VERSION. To ensure that, swupd-image.bbclass now adds a dependency on a virtual "swupd-client-format<format number>" and suitable swupd client recipe(s) provide that. Distros then have two ways of choosing a swupd client version, should that ever be necessary: - first they need to override the per-image format default value - then set the preferred swupd client version, if there is more than one for that format TODO: installing the SSL pubkey into the image after a file change does not work. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08meta-swupd: revise delta computationPatrick Ohly2-166/+34
This removes the storing of previous build information in sstate. It was conceptually questionable (sstate is a cache which does not need to be backed up, while the information about previous builds is crucial and must not get lost) and not working: - the -map.inc file wasn't actually included anywhere and thus the old build information wasn't getting restored - restoring all previous builds would have made building slower and slower as the number of previous builds grows - the old build information lacked the www/Manifest files that incremental updates need The replacement puts previous build information into the image deploy directory. That's tentative and also not fully working. The automatic selection of old versions to build deltas against also gets replaced with an explicit choice that has to be made by the user of meta-swupd. That's because in practice, incremental updates are more useful when prepared for the releases that actually run on the target device, like major milestones. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-image.bbclass: automatically recreate swupd inputs after removing ↵Patrick Ohly1-0/+37
deploy/swupd During development it is useful to wipe out deploy/swupd. This simulates the "start from scratch" situation in the Ostro OS CI. Previously it was necessary to force-run do_stage_swupd_inputs and do_swupd_update after removing the directory, now this is fully automatic. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-image.bbclass: remove special cases with SWUPD_IMAGE_PNPatrick Ohly1-9/+9
That PN is different in the base image and virtual images led to various places which had to distinguish between the two. We can simplify that by introducing a variable SWUPD_IMAGE_PN which always has the PN value of the base image. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08path.py: better error handling in copyxattrfiles()Patrick Ohly1-0/+3
When the first tar in a pipe fails, its error code is getting lost. Detect that by checking for output: normally, all operations should be silent, so if there is output, something unusual happened. This also catches warnings. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08utils.py: list files with leading slash in manifestsPatrick Ohly1-7/+12
When reading the manifest .content.txt files in swupd-server, it matters whether they list entries with or without leading slash. Without it, matching files against the full content fails because that is read from a directory and happens to use a leading slash inside swupd_create_update, and then swupd created bundle manifests without hashsums, leading to 404 errors during updates. Fixing this in meta-swupd is easier than in swupd-server. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-image.bbclass: separate pseudo DB for do_swupd_updatePatrick Ohly1-15/+28
do_swupd_update itself unpacks the tar archives that swupd-server needs and therefore does no longer depend on sharing the pseudo database with the other tasks and virtual images. Using a separate pseudo DB speeds up "ostro-image-swupd:do_stage_swupd_inputs ostro-image-swupd:do_swupd_update ostro-image-swupd-dev" (two tasks which run in parallel because both depend on the same full rootfs and which used to share the same pseudo instance) from 25 to 16 minutes. The pseudo data directory is intentionally inside the deploy/swupd directory. There it can be deleted and re-created for testing swupd update generation with: rm -rf tmp*/deploy/swupd bitbake -f <image>:do_stage_swupd_inputs <image>:do_swupd_update Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08fix meta-swupd: avoid splitting up mega rootfsPatrick Ohly4-51/+72
When creating bundle images, we need to know and copy also the entries that we exclude from processing by swupd-server. This could be done with a more complex syntax for the .content.txt files, but that would also make the swupd-server patches more complicated. Instead, an .extra-content.txt gets written alongside the .content.text and meta-swupd uses that when copying files into images. Due to the way how this is implemented, the .extra-content.txt of bundles also lists the files that were excluded from the bundle because they were already in the os-core. This may or may not be desirable. This change also includes some other improvements (consistent use of the helper method, sorting the content of the file lists). Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-image.bbclass: make sstate-support optional and disabled by defaultPatrick Ohly1-2/+9
Storing the build rootfs in the sstate-cache has drawbacks: - it's questionable whether storing data that cannot be re-created really belongs into a cache which (by definition) should only contain data which may get lost - while it looks attractive to re-use an existing mechanism for sharing data across builds, it's not a complete solution because the map still needs to be carried across builds - using the sstate-cache mechanism adds additional, large copy operations on the critical path towards completing a build - the code isn't quite mature yet, sometimes do_stage_swupd_inputs_setscene fails: sstate_setscene(d) fails: No such file or directory: '.../tmp-glibc/work/qemux86-ostro-linux/ostro-image-swupd/1.0-r0/sstate-install-stage_swupd_inputs/92909520' -> '.../tmp-glibc/work/qemux86-ostro-linux/ostro-image-swupd/1.0-r0/swupd-image/92909520' It might be better to define an explicit "shared build directory" where the current image directory of a build can be stored for future use. In the meantime, disable the mechanism by default to speed up builds inside a CI system (like the one from Ostro) which is not prepared to use the mechanism anyway. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd input: compress with gzPatrick Ohly2-2/+2
Compression with xz is slowing down do_stage_swupd_inputs (on the critical path) by keeping one CPU 100% with xz. gzip compresses faster and (at least for now) on-disk usage matters less than speed. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08meta-swupd: put compressed rootfs into sstatePatrick Ohly3-7/+26
do_stage_swupd_updates works with the entire full tree multiple times: copying into the staging area, packing it as sstate archive, copying to the swupd deploy directory. Copying directory trees is slow, in particular when running under pseudo, and do_stage_swupd_updates is on the critical path for completing a build. Therefore it should be as fast as possible. Storing the directory as compressed archive is faster: it cuts down the time for do_stage_swupd_updates from 11min in the Ostro CI to 6min. This is with xz as compression method, which is suitable for long-term archival (good compression) but a lot slower than gzip (https://www.rootusers.com/gzip-vs-bzip2-vs-xz-performance-comparison/). When favoring speed, using gzip may be better. The long-term goal (dream?) is to have swupd work directly with tar archives, in which case expanding the archive and pseudo could be avoided altogether. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-image.bbclass: show swupd log outputPatrick Ohly1-8/+8
Include the log output of the swupd tools in the normal stdout/stderr logfile. That way errors are immediately visible when invoked from bitbake and in the Ostro OS CI (which only shows the bitbake output). Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-server: support logging to stdoutPatrick Ohly2-0/+199
When a swupd command fails, bitbake doesn't show what the error was because the tools only write it into an internal log file. Logging it to stderr will capture the error also in the logs shown by bitbake and thus the Jenkins CI. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08rootfs.py: adapt to IMGDEPLOYDIR changePatrick Ohly1-2/+2
OE-core recently introduced an intermediate IMGDEPLOYDIR into which images and image manifests are meant to be written. IMAGE_MANIFEST already uses it, but the manifest creation code was not using that variable and also ignoring IMGDEPLOYDIR. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08meta-swupd: fix virtual image dependenciesPatrick Ohly2-27/+31
Sharing of pseudo databases was broken, leading to files with wrong attributes: ${IMAGE_BASENAME} is different among all virtual recipes and thus updating PSEUDO_LOCALSTATEDIR did not have the desired effect. Bundle recipes do not need to copy from anything (and thus they do not depend on the mega image do_image) and also do not need to share the pseudo database, because all that matters is the list of entries in their rootfs. Being very specific about the task dependencies allows more long-running image creation tasks to run in parallel. Distinguishing between the various virtual image recipes and the base image is a bit tricky. Therefore the "(virtual) swupd image recipes" (called so because they get created by swupdimage.bbclass) now unsets BUNDLE_NAME (thus removing the default "os-core" which is set in the base recipe) and the usage of PN, PN_BASE, and BUNDLE_NAME is explained in a comment. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08meta-swupd: avoid splitting up mega rootfsPatrick Ohly4-215/+67
Creating individual bundle directories as input for swupd is a waste of resources and time, because swupd is just going to recreate the "full" tree anyway. With an improved swupd-server, we can just copy the full tree once and then define the content of each bundle with a text file. This replaces the "files-in-image" files. Those were used only by meta-swupd before. They were renamed because they not only list files, but also directories. "content" is a bit more neutral. Creating them is now done in pure Python and integrated with the SWUPD_FILE_BLACKLIST mechanism. That way, the content files are correct right away, which allows removing the post-processing code (for example, sanitise_file_list()). The special mode of obtaining bundle content from the package manager instead of a full rootfs gets dropped for now. If that mode can be shown to be noticably faster then full rootfs creation, then it can be re-added such that it also only produces a content file for the bundle. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-server: enable support for single input rootfsPatrick Ohly2-0/+348
Splitting up the "mega" image just so that the original swupd-create-update can be used unmodified creates lots of redundant file operations, which are noticably slow under pseudo. This path is meant to go upstream. For now it is included here as POC. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-server: update to 3.2.5 and use libarchive directlyPatrick Ohly8-72/+919
Using libarchive directly avoids one fork/exec per file in swupd-make-fullfiles, which improves performance. Several regressions in the new upstream version had to be fixed as part of the version update. The version got updated to make it easier to upstream the libarchive patch. The latest upstream version actually is 3.2.7, but that version introduces a format change. Updating to that will require further work and preparations. Luckily, the source code patches apply cleanly to 3.2.5 and 3.2.7. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08swupd-client: don't unconditionally depend on bashAndré Draszik3-3/+3
The swupd client itself does not depend on bash anymore since version 3.3.0. Any posix shell is fine. So let's move the runtime dependency to the appropriate place. If some layer's oe-swupd-helpers.bbappend does introduce a bash dependency, it should just state that dependency itself. As the shell now be provided by bash or busybox, also add an appropriate entry to SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS. Signed-off-by: André Draszik <adraszik@tycoint.com> Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08oe-swupd-helpers: convert scripts to posix shellAndré Draszik3-3/+3
These scripts don't do much and there's no reason for them to require bash as interpreter. Signed-off-by: André Draszik <adraszik@tycoint.com> Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2016-12-08bsdiff: update to latest versionAndré Draszik1-3/+4
This allows us to completely remove the build time depenency on libcheck when not needed, reducing overall build time, and in addition tests can be converted into a PACKAGECONFIG to enable them if needed. Signed-off-by: André Draszik <adraszik@tycoint.com> Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>