aboutsummaryrefslogtreecommitdiffstats
path: root/recipes-bsp/imx-uuc/imx-uuc/0001-Fix-missing-build-flags-leading-to-yocto-QA-issues.patch
blob: 36ce2f06b40103f5a0cef9bbd28384763c87f0db (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
From bfdf01bfb462b21cf0a8f3e35d160b8ee4cea4ab Mon Sep 17 00:00:00 2001
From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
Date: Tue, 3 Oct 2017 08:58:08 +0200
Subject: [PATCH] Fix missing build flags, leading to yocto QA issues

ERROR: imx-uuc-0.5.1+gitAUTOINC+1de598e7b3-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'imx-uuc/0.5.1+gitAUTOINC+1de598e7b3-r0/packages-split/imx-uuc/usr/bin/uuc'
No GNU_HASH in the elf binary: 'imx-uuc/0.5.1+gitAUTOINC+1de598e7b3-r0/packages-split/imx-uuc/usr/bin/sdimage' [ldflags]

similar issues have been reported on meta-freescale mail list too and then I'm attaching the Found-by/Signed-off-by flags correspondingly:
(the patches were against meta-freescale, I'm upstreaming them with some little changes)
https://lists.yoctoproject.org/pipermail/meta-freescale/2017-April/020355.html

Found-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
Found-by: Joel Esponde <Joel.Esponde@Honeywell.com>
Signed-off-by: Bas Mevissen <bas.mevissen@emcodev.nl>
---
 Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 5e2816c..1a8f51f 100644
--- a/Makefile
+++ b/Makefile
@@ -1,14 +1,15 @@
 CC ?= $(CROSS_COMPILE)gcc
 BINDIR ?= /usr/bin
 PROGRAMS = uuc sdimage
+LIBS ?= -lpthread
 
 all: $(PROGRAMS)
 
 uuc: uu.c
-	$(CC) $(CFLAGS) uu.c -o uuc -lpthread
+	$(CC) $(CFLAGS) $(CPPFLAGS) uu.c -o uuc $(LDFLAGS) $(LIBS) 
 
 sdimage: sdimage.c
-	$(CC) $(CFLAGS) sdimage.c -o sdimage
+	$(CC) $(CFLAGS) $(CPPFLAGS) sdimage.c -o sdimage $(LDFLAGS)
 
 install:
 	install -d $(DESTDIR)$(BINDIR)
-- 
2.11.0