diff options
Diffstat (limited to 'meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/4372-drm-amdgpu-remove-always-false-comparison-in-amdgpu_.patch')
| -rw-r--r-- | meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/4372-drm-amdgpu-remove-always-false-comparison-in-amdgpu_.patch | 45 |
1 files changed, 45 insertions, 0 deletions
diff --git a/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/4372-drm-amdgpu-remove-always-false-comparison-in-amdgpu_.patch b/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/4372-drm-amdgpu-remove-always-false-comparison-in-amdgpu_.patch new file mode 100644 index 00000000..b072100d --- /dev/null +++ b/meta-amd-bsp/recipes-kernel/linux/linux-yocto-4.19.8/4372-drm-amdgpu-remove-always-false-comparison-in-amdgpu_.patch @@ -0,0 +1,45 @@ +From 937e4c99390453264af0907239da7c6adf76a477 Mon Sep 17 00:00:00 2001 +From: yu kuai <yukuai3@huawei.com> +Date: Mon, 4 Nov 2019 21:27:25 +0800 +Subject: [PATCH 4372/4736] drm/amdgpu: remove always false comparison in + 'amdgpu_atombios_i2c_process_i2c_ch' +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Fixes gcc '-Wtype-limits' warning: + +drivers/gpu/drm/amd/amdgpu/atombios_i2c.c: In function +‘amdgpu_atombios_i2c_process_i2c_ch’: +drivers/gpu/drm/amd/amdgpu/atombios_i2c.c:79:11: warning: comparison is +always false due to limited range of data type [-Wtype-limits] + +'num' is 'u8', so it will never be greater than 'TOM_MAX_HW_I2C_READ', +which is defined as 255. Therefore, the comparison can be removed. + +Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)") +Signed-off-by: yu kuai <yukuai3@huawei.com> +Signed-off-by: Alex Deucher <alexander.deucher@amd.com> +--- + drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 5 ----- + 1 file changed, 5 deletions(-) + +diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c +index f9b2ce9a98f3..9c7d0bf6712a 100644 +--- a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c ++++ b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c +@@ -76,11 +76,6 @@ static int amdgpu_atombios_i2c_process_i2c_ch(struct amdgpu_i2c_chan *chan, + } + args.lpI2CDataOut = cpu_to_le16(out); + } else { +- if (num > ATOM_MAX_HW_I2C_READ) { +- DRM_ERROR("hw i2c: tried to read too many bytes (%d vs 255)\n", num); +- r = -EINVAL; +- goto done; +- } + args.ucRegIndex = 0; + args.lpI2CDataOut = 0; + } +-- +2.17.1 + |