diff options
Diffstat (limited to 'common/recipes-kernel/linux/linux-yocto-4.19.8/1186-drm-amd-display-Use-memset-to-initialize-variables-i.patch')
| -rw-r--r-- | common/recipes-kernel/linux/linux-yocto-4.19.8/1186-drm-amd-display-Use-memset-to-initialize-variables-i.patch | 53 |
1 files changed, 53 insertions, 0 deletions
diff --git a/common/recipes-kernel/linux/linux-yocto-4.19.8/1186-drm-amd-display-Use-memset-to-initialize-variables-i.patch b/common/recipes-kernel/linux/linux-yocto-4.19.8/1186-drm-amd-display-Use-memset-to-initialize-variables-i.patch new file mode 100644 index 00000000..095caa05 --- /dev/null +++ b/common/recipes-kernel/linux/linux-yocto-4.19.8/1186-drm-amd-display-Use-memset-to-initialize-variables-i.patch @@ -0,0 +1,53 @@ +From 373cd1beaf523c10144d8741e513bf153f566e4d Mon Sep 17 00:00:00 2001 +From: Nathan Chancellor <natechancellor@gmail.com> +Date: Fri, 1 Feb 2019 13:14:28 -0700 +Subject: [PATCH 1186/2940] drm/amd/display: Use memset to initialize variables + in amdgpu_dm_atomic_commit_tail + +Clang warns: + +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5089:60: +warning: suggest braces around initialization of subobject +[-Wmissing-braces] + struct dc_surface_update dummy_updates[MAX_SURFACES] = { 0 }; + ^ + {} + +Previous efforts to fix this type of warning by adding or removing +braces have been met with some pushback in favor of using memset [1][2]. +Do that here, mirroring commit 05794eff1aa6 ("drm/amdgpu/gmc: fix +compiler errors [-Werror,-Wmissing-braces] (V2)") in this tree. + +[1]: https://lore.kernel.org/lkml/022e41c0-8465-dc7a-a45c-64187ecd9684@amd.com/ +[2]: https://lore.kernel.org/lkml/20181128.215241.702406654469517539.davem@davemloft.net/ + +Fixes: 02d6a6fcdf68 ("drm/amd/display: Simplify underscan and ABM commit") +Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> +Signed-off-by: Alex Deucher <alexander.deucher@amd.com> +--- + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++++-- + 1 file changed, 5 insertions(+), 2 deletions(-) + +diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +index 3585fccca8d6..8930a827b736 100644 +--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c ++++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +@@ -5220,10 +5220,13 @@ static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state) + struct dm_connector_state *dm_new_con_state = to_dm_connector_state(new_con_state); + struct dm_connector_state *dm_old_con_state = to_dm_connector_state(old_con_state); + struct amdgpu_crtc *acrtc = to_amdgpu_crtc(dm_new_con_state->base.crtc); +- struct dc_surface_update dummy_updates[MAX_SURFACES] = { 0 }; +- struct dc_stream_update stream_update = { 0 }; ++ struct dc_surface_update dummy_updates[MAX_SURFACES]; ++ struct dc_stream_update stream_update; + struct dc_stream_status *status = NULL; + ++ memset(&dummy_updates, 0, sizeof(dummy_updates)); ++ memset(&stream_update, 0, sizeof(stream_update)); ++ + if (acrtc) { + new_crtc_state = drm_atomic_get_new_crtc_state(state, &acrtc->base); + old_crtc_state = drm_atomic_get_old_crtc_state(state, &acrtc->base); +-- +2.17.1 + |