diff options
Diffstat (limited to 'common/recipes-kernel/linux/linux-yocto-4.14.71/5358-drm-amd-display-num-of-sw-i2c-aux-engines-less-than-.patch')
-rw-r--r-- | common/recipes-kernel/linux/linux-yocto-4.14.71/5358-drm-amd-display-num-of-sw-i2c-aux-engines-less-than-.patch | 269 |
1 files changed, 269 insertions, 0 deletions
diff --git a/common/recipes-kernel/linux/linux-yocto-4.14.71/5358-drm-amd-display-num-of-sw-i2c-aux-engines-less-than-.patch b/common/recipes-kernel/linux/linux-yocto-4.14.71/5358-drm-amd-display-num-of-sw-i2c-aux-engines-less-than-.patch new file mode 100644 index 00000000..51075ed3 --- /dev/null +++ b/common/recipes-kernel/linux/linux-yocto-4.14.71/5358-drm-amd-display-num-of-sw-i2c-aux-engines-less-than-.patch @@ -0,0 +1,269 @@ +From 9c122507f7a1d46aec6b5f662a10941fd122deb7 Mon Sep 17 00:00:00 2001 +From: Hersen Wu <hersenxs.wu@amd.com> +Date: Tue, 21 Aug 2018 09:35:47 -0400 +Subject: [PATCH 5358/5725] drm/amd/display: num of sw i2c/aux engines less + than num of connectors + +[why] +AMD Stoney reference board, there are only 2 pipes (not include +underlay), and 3 connectors. resource creation, only +2 I2C/AUX engines are created. Within dc_link_aux_transfer, when +pin_data_en =2, refer to enengines[ddc_pin->pin_data->en] = NULL. +NULL point is referred later causing system crash. + +[how] +each asic design has fixed number of ddc engines at hw side. +for each ddc engine, create its i2x/aux engine at sw side. + +Change-Id: I5bf6e45756b1e95f246a502219011755c9d465cf +Signed-off-by: Hersen Wu <hersenxs.wu@amd.com> +Reviewed-by: Tony Cheng <Tony.Cheng@amd.com> +Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> +--- + .../drm/amd/display/dc/dce100/dce100_resource.c | 6 +++++- + .../drm/amd/display/dc/dce110/dce110_resource.c | 4 ++++ + .../drm/amd/display/dc/dce112/dce112_resource.c | 5 +++++ + .../drm/amd/display/dc/dce120/dce120_resource.c | 9 ++++++-- + .../gpu/drm/amd/display/dc/dce80/dce80_resource.c | 25 ++++++++++++++++++++++ + .../gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 7 ++++-- + drivers/gpu/drm/amd/display/dc/inc/resource.h | 1 + + 7 files changed, 52 insertions(+), 5 deletions(-) + +diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +index ae613b0..b1cc388 100644 +--- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c ++++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +@@ -372,7 +372,8 @@ static const struct resource_caps res_cap = { + .num_timing_generator = 6, + .num_audio = 6, + .num_stream_encoder = 6, +- .num_pll = 3 ++ .num_pll = 3, ++ .num_ddc = 6, + }; + + #define CTX ctx +@@ -1004,6 +1005,9 @@ static bool construct( + "DC: failed to create output pixel processor!\n"); + goto res_create_fail; + } ++ } ++ ++ for (i = 0; i < pool->base.res_cap->num_ddc; i++) { + pool->base.engines[i] = dce100_aux_engine_create(ctx, i); + if (pool->base.engines[i] == NULL) { + BREAK_TO_DEBUGGER(); +diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +index cfca786..b44cc70 100644 +--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c ++++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +@@ -378,6 +378,7 @@ static const struct resource_caps carrizo_resource_cap = { + .num_audio = 3, + .num_stream_encoder = 3, + .num_pll = 2, ++ .num_ddc = 3, + }; + + static const struct resource_caps stoney_resource_cap = { +@@ -386,6 +387,7 @@ static const struct resource_caps stoney_resource_cap = { + .num_audio = 3, + .num_stream_encoder = 3, + .num_pll = 2, ++ .num_ddc = 3, + }; + + #define CTX ctx +@@ -1339,7 +1341,9 @@ static bool construct( + "DC: failed to create output pixel processor!\n"); + goto res_create_fail; + } ++ } + ++ for (i = 0; i < pool->base.res_cap->num_ddc; i++) { + pool->base.engines[i] = dce110_aux_engine_create(ctx, i); + if (pool->base.engines[i] == NULL) { + BREAK_TO_DEBUGGER(); +diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +index f3d55a6..0f8332e 100644 +--- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c ++++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +@@ -384,6 +384,7 @@ static const struct resource_caps polaris_10_resource_cap = { + .num_audio = 6, + .num_stream_encoder = 6, + .num_pll = 8, /* why 8? 6 combo PHY PLL + 2 regular PLLs? */ ++ .num_ddc = 6, + }; + + static const struct resource_caps polaris_11_resource_cap = { +@@ -391,6 +392,7 @@ static const struct resource_caps polaris_11_resource_cap = { + .num_audio = 5, + .num_stream_encoder = 5, + .num_pll = 8, /* why 8? 6 combo PHY PLL + 2 regular PLLs? */ ++ .num_ddc = 5, + }; + + #define CTX ctx +@@ -1286,6 +1288,9 @@ static bool construct( + "DC:failed to create output pixel processor!\n"); + goto res_create_fail; + } ++ } ++ ++ for (i = 0; i < pool->base.res_cap->num_ddc; i++) { + pool->base.engines[i] = dce112_aux_engine_create(ctx, i); + if (pool->base.engines[i] == NULL) { + BREAK_TO_DEBUGGER(); +diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +index 8afa43a..5905580 100644 +--- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c ++++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +@@ -436,6 +436,7 @@ static const struct resource_caps res_cap = { + .num_audio = 7, + .num_stream_encoder = 6, + .num_pll = 6, ++ .num_ddc = 6, + }; + + static const struct dc_debug_options debug_defaults = { +@@ -1062,6 +1063,12 @@ static bool construct( + dm_error( + "DC: failed to create output pixel processor!\n"); + } ++ ++ /* check next valid pipe */ ++ j++; ++ } ++ ++ for (i = 0; i < pool->base.res_cap->num_ddc; i++) { + pool->base.engines[i] = dce120_aux_engine_create(ctx, i); + if (pool->base.engines[i] == NULL) { + BREAK_TO_DEBUGGER(); +@@ -1077,8 +1084,6 @@ static bool construct( + goto res_create_fail; + } + pool->base.sw_i2cs[i] = NULL; +- /* check next valid pipe */ +- j++; + } + + /* valid pipe num */ +diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +index 4eae859..1dc590c 100644 +--- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c ++++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +@@ -367,6 +367,7 @@ static const struct resource_caps res_cap = { + .num_audio = 6, + .num_stream_encoder = 6, + .num_pll = 3, ++ .num_ddc = 6, + }; + + static const struct resource_caps res_cap_81 = { +@@ -374,6 +375,7 @@ static const struct resource_caps res_cap_81 = { + .num_audio = 7, + .num_stream_encoder = 7, + .num_pll = 3, ++ .num_ddc = 6, + }; + + static const struct resource_caps res_cap_83 = { +@@ -381,6 +383,7 @@ static const struct resource_caps res_cap_83 = { + .num_audio = 6, + .num_stream_encoder = 6, + .num_pll = 2, ++ .num_ddc = 2, + }; + + static const struct dce_dmcu_registers dmcu_regs = { +@@ -992,7 +995,9 @@ static bool dce80_construct( + dm_error("DC: failed to create output pixel processor!\n"); + goto res_create_fail; + } ++ } + ++ for (i = 0; i < pool->base.res_cap->num_ddc; i++) { + pool->base.engines[i] = dce80_aux_engine_create(ctx, i); + if (pool->base.engines[i] == NULL) { + BREAK_TO_DEBUGGER(); +@@ -1200,6 +1205,16 @@ static bool dce81_construct( + dm_error("DC: failed to create output pixel processor!\n"); + goto res_create_fail; + } ++ } ++ ++ for (i = 0; i < pool->base.res_cap->num_ddc; i++) { ++ pool->base.engines[i] = dce80_aux_engine_create(ctx, i); ++ if (pool->base.engines[i] == NULL) { ++ BREAK_TO_DEBUGGER(); ++ dm_error( ++ "DC:failed to create aux engine!!\n"); ++ goto res_create_fail; ++ } + pool->base.hw_i2cs[i] = dce80_i2c_hw_create(ctx, i); + if (pool->base.hw_i2cs[i] == NULL) { + BREAK_TO_DEBUGGER(); +@@ -1396,6 +1411,16 @@ static bool dce83_construct( + dm_error("DC: failed to create output pixel processor!\n"); + goto res_create_fail; + } ++ } ++ ++ for (i = 0; i < pool->base.res_cap->num_ddc; i++) { ++ pool->base.engines[i] = dce80_aux_engine_create(ctx, i); ++ if (pool->base.engines[i] == NULL) { ++ BREAK_TO_DEBUGGER(); ++ dm_error( ++ "DC:failed to create aux engine!!\n"); ++ goto res_create_fail; ++ } + pool->base.hw_i2cs[i] = dce80_i2c_hw_create(ctx, i); + if (pool->base.hw_i2cs[i] == NULL) { + BREAK_TO_DEBUGGER(); +diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +index e8a22d5..cb1b134 100644 +--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c ++++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +@@ -504,6 +504,7 @@ static const struct resource_caps res_cap = { + .num_audio = 4, + .num_stream_encoder = 4, + .num_pll = 4, ++ .num_ddc = 4, + }; + + static const struct dc_debug_options debug_defaults_drv = { +@@ -1370,7 +1371,11 @@ static bool construct( + dm_error("DC: failed to create tg!\n"); + goto fail; + } ++ /* check next valid pipe */ ++ j++; ++ } + ++ for (i = 0; i < pool->base.res_cap->num_ddc; i++) { + pool->base.engines[i] = dcn10_aux_engine_create(ctx, i); + if (pool->base.engines[i] == NULL) { + BREAK_TO_DEBUGGER(); +@@ -1386,8 +1391,6 @@ static bool construct( + goto fail; + } + pool->base.sw_i2cs[i] = NULL; +- /* check next valid pipe */ +- j++; + } + + /* valid pipe num */ +diff --git a/drivers/gpu/drm/amd/display/dc/inc/resource.h b/drivers/gpu/drm/amd/display/dc/inc/resource.h +index 5b32100..76d00c6 100644 +--- a/drivers/gpu/drm/amd/display/dc/inc/resource.h ++++ b/drivers/gpu/drm/amd/display/dc/inc/resource.h +@@ -44,6 +44,7 @@ struct resource_caps { + int num_stream_encoder; + int num_pll; + int num_dwb; ++ int num_ddc; + }; + + struct resource_straps { +-- +2.7.4 + |