aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVasily Averin <vvs@parallels.com>2014-07-21 12:30:23 +0400
committerChristoph Hellwig <hch@lst.de>2014-07-24 06:18:12 -0400
commit295dc39d941dc2ae53d5c170365af4c9d5c16212 (patch)
tree5f2b9e64cd719ca76760812a0d143d6817216624
parent6fcc5420bfb91049a318bb4d88fe471248b5b391 (diff)
downloadlinux-yocto-295dc39d941dc2ae53d5c170365af4c9d5c16212.tar.gz
linux-yocto-295dc39d941dc2ae53d5c170365af4c9d5c16212.tar.bz2
linux-yocto-295dc39d941dc2ae53d5c170365af4c9d5c16212.zip
fs: umount on symlink leaks mnt count
Currently umount on symlink blocks following umount: /vz is separate mount # ls /vz/ -al | grep test drwxr-xr-x. 2 root root 4096 Jul 19 01:14 testdir lrwxrwxrwx. 1 root root 11 Jul 19 01:16 testlink -> /vz/testdir # umount -l /vz/testlink umount: /vz/testlink: not mounted (expected) # lsof /vz # umount /vz umount: /vz: device is busy. (unexpected) In this case mountpoint_last() gets an extra refcount on path->mnt Signed-off-by: Vasily Averin <vvs@openvz.org> Acked-by: Ian Kent <raven@themaw.net> Acked-by: Jeff Layton <jlayton@primarydata.com> Cc: stable@vger.kernel.org Signed-off-by: Christoph Hellwig <hch@lst.de>
-rw-r--r--fs/namei.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/namei.c b/fs/namei.c
index 985c6f368485..9eb787e5c167 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2256,9 +2256,10 @@ done:
goto out;
}
path->dentry = dentry;
- path->mnt = mntget(nd->path.mnt);
+ path->mnt = nd->path.mnt;
if (should_follow_link(dentry, nd->flags & LOOKUP_FOLLOW))
return 1;
+ mntget(path->mnt);
follow_mount(path);
error = 0;
out: