aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYingjoe Chen <yingjoe.chen@mediatek.com>2019-05-07 22:20:32 +0800
committerPaul Gortmaker <paul.gortmaker@windriver.com>2019-09-16 12:21:38 -0400
commitf55f39bae328303dd701a3f7bfc2bb7f95caec4b (patch)
treea6dea1590386c1cbc35929f81dc17c69543eccc4
parent1ffee5d9acf5597feef50368e746a7936dc4954c (diff)
downloadlinux-yocto-f55f39bae328303dd701a3f7bfc2bb7f95caec4b.tar.gz
linux-yocto-f55f39bae328303dd701a3f7bfc2bb7f95caec4b.tar.bz2
linux-yocto-f55f39bae328303dd701a3f7bfc2bb7f95caec4b.zip
i2c: dev: fix potential memory leak in i2cdev_ioctl_rdwr
commit a0692f0eef91354b62c2b4c94954536536be5425 upstream. If I2C_M_RECV_LEN check failed, msgs[i].buf allocated by memdup_user will not be freed. Pump index up so it will be freed. Fixes: 838bfa6049fb ("i2c-dev: Add support for I2C_M_RECV_LEN") Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
-rw-r--r--drivers/i2c/i2c-dev.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index ccd76c71af09..cb07651f4b46 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c-dev.c
@@ -283,6 +283,7 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client,
msgs[i].len < 1 || msgs[i].buf[0] < 1 ||
msgs[i].len < msgs[i].buf[0] +
I2C_SMBUS_BLOCK_MAX) {
+ i++;
res = -EINVAL;
break;
}