aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMax Uvarov <muvarov@gmail.com>2019-05-28 13:00:52 +0300
committerPaul Gortmaker <paul.gortmaker@windriver.com>2019-09-16 12:21:43 -0400
commit9336b513408375b2eb1ff7a6d30421c90cd90f7e (patch)
tree6e6d8e506380e02d5f2a35d42948df19f6db5d56
parentc0de0ca4f0760b1b45257be5c843514ceb4762df (diff)
downloadlinux-yocto-9336b513408375b2eb1ff7a6d30421c90cd90f7e.tar.gz
linux-yocto-9336b513408375b2eb1ff7a6d30421c90cd90f7e.tar.bz2
linux-yocto-9336b513408375b2eb1ff7a6d30421c90cd90f7e.zip
net: phy: dp83867: Set up RGMII TX delay
commit 2b892649254fec01678c64f16427622b41fa27f4 upstream. PHY_INTERFACE_MODE_RGMII_RXID is less then TXID so code to set tx delay is never called. Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy") Signed-off-by: Max Uvarov <muvarov@gmail.com> Cc: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
-rw-r--r--drivers/net/phy/dp83867.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index b3935778b19f..e4bf9e7d7583 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -260,10 +260,8 @@ static int dp83867_config_init(struct phy_device *phydev)
ret = phy_write(phydev, MII_DP83867_PHYCTRL, val);
if (ret)
return ret;
- }
- if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
- (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
+ /* Set up RGMII delays */
val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL);
if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)