diff options
authorJeffrin Jose T <jeffrin@rajagiritech.edu.in>2019-05-15 12:14:04 +0530
committerPaul Gortmaker <paul.gortmaker@windriver.com>2019-09-16 12:21:33 -0400
commit055f9f9565b032e84125f7a10270c16da089847b (patch)
parentd3eb2922e6f6ed0f634fde226ab971b58d9bea20 (diff)
selftests: netfilter: missing error check when setting up veth interface
commit 82ce6eb1dd13fd12e449b2ee2c2ec051e6f52c43 upstream. A test for the basic NAT functionality uses ip command which needs veth device. There is a condition where the kernel support for veth is not compiled into the kernel and the test script breaks. This patch contains code for reasonable error display and correct code exit. Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in> Acked-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
1 files changed, 5 insertions, 1 deletions
diff --git a/tools/testing/selftests/netfilter/nft_nat.sh b/tools/testing/selftests/netfilter/nft_nat.sh
index a39433761fed..32f502f4db87 100755
--- a/tools/testing/selftests/netfilter/nft_nat.sh
+++ b/tools/testing/selftests/netfilter/nft_nat.sh
@@ -23,7 +23,11 @@ ip netns add ns0
ip netns add ns1
ip netns add ns2
-ip link add veth0 netns ns0 type veth peer name eth0 netns ns1
+ip link add veth0 netns ns0 type veth peer name eth0 netns ns1 > /dev/null 2>&1
+if [ $? -ne 0 ];then
+ echo "SKIP: No virtual ethernet pair device support in kernel"
+ exit $ksft_skip
ip link add veth1 netns ns0 type veth peer name eth0 netns ns2
ip -net ns0 link set lo up