aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2014-08-08 14:19:17 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-09-05 16:34:18 -0700
commit07675d98fa2304b6c64ded1099f2b08777316241 (patch)
treeccde69f29ed979f21f185a05d900643d7acd138c
parentefe17240f3780af81ab8f410cabc825fe958ff9b (diff)
downloadlinux-yocto-07675d98fa2304b6c64ded1099f2b08777316241.tar.gz
linux-yocto-07675d98fa2304b6c64ded1099f2b08777316241.tar.bz2
linux-yocto-07675d98fa2304b6c64ded1099f2b08777316241.zip
vm_is_stack: use for_each_thread() rather then buggy while_each_thread()
commit 4449a51a7c281602d3a385044ab928322a122a02 upstream. Aleksei hit the soft lockup during reading /proc/PID/smaps. David investigated the problem and suggested the right fix. while_each_thread() is racy and should die, this patch updates vm_is_stack(). Signed-off-by: Oleg Nesterov <oleg@redhat.com> Reported-by: Aleksei Besogonov <alex.besogonov@gmail.com> Tested-by: Aleksei Besogonov <alex.besogonov@gmail.com> Suggested-by: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--mm/util.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/mm/util.c b/mm/util.c
index a24aa22f2473..c1010cb7ca0c 100644
--- a/mm/util.c
+++ b/mm/util.c
@@ -275,17 +275,14 @@ pid_t vm_is_stack(struct task_struct *task,
if (in_group) {
struct task_struct *t;
- rcu_read_lock();
- if (!pid_alive(task))
- goto done;
- t = task;
- do {
+ rcu_read_lock();
+ for_each_thread(task, t) {
if (vm_is_stack_for_task(t, vma)) {
ret = t->pid;
goto done;
}
- } while_each_thread(task, t);
+ }
done:
rcu_read_unlock();
}