aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorSowmini Varadhan <sowmini.varadhan@oracle.com>2017-07-06 08:15:06 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-07-21 06:59:05 +0200
commite8c11223242dae19b84f914e5829a26c38bde74c (patch)
tree1dc8d4770dfad3ca7bdec60d94e8c687b943ed45 /net
parent354934e1536aaefc00e47ce196e93383885041ac (diff)
downloadlinux-yocto-4.12-e8c11223242dae19b84f914e5829a26c38bde74c.tar.gz
linux-yocto-4.12-e8c11223242dae19b84f914e5829a26c38bde74c.tar.bz2
linux-yocto-4.12-e8c11223242dae19b84f914e5829a26c38bde74c.zip
rds: tcp: use sock_create_lite() to create the accept socket
[ Upstream commit 0933a578cd55b02dc80f219dc8f2efb17ec61c9a ] There are two problems with calling sock_create_kern() from rds_tcp_accept_one() 1. it sets up a new_sock->sk that is wasteful, because this ->sk is going to get replaced by inet_accept() in the subsequent ->accept() 2. The new_sock->sk is a leaked reference in sock_graft() which expects to find a null parent->sk Avoid these problems by calling sock_create_lite(). Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
-rw-r--r--net/rds/tcp_listen.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c
index 507678853e6c..9a1798d6ae94 100644
--- a/net/rds/tcp_listen.c
+++ b/net/rds/tcp_listen.c
@@ -125,7 +125,7 @@ int rds_tcp_accept_one(struct socket *sock)
if (!sock) /* module unload or netns delete in progress */
return -ENETUNREACH;
- ret = sock_create_kern(sock_net(sock->sk), sock->sk->sk_family,
+ ret = sock_create_lite(sock->sk->sk_family,
sock->sk->sk_type, sock->sk->sk_protocol,
&new_sock);
if (ret)